Re: [PATCH v1 3/3] arm64: dts: mediatek: Add device tree for MT8365-based Pumpkin i350

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 19/10/23 14:45, Alexandre Mergnat ha scritto:
> 
> 
> On 16/10/2023 23:51, Laurent Pinchart wrote:
>> Add a minimal device tree for the Genio i350 Pumpkin development board,
>> which is based on a MediaTek MT8365.
>>
>> The device tree is based on an initial version by Fabien Parent Based
>> written against the MediaTek BSP kernel ([1]). It has been cleaned up,
>> some features have been added (GPIO LEDs, ethernet), and some features
>> removed (audio, camera, display and dual-role USB). Those features will
>> be added back once the corresponding DT bindings and/or drivers become
>> available in the upstream kernel.
>>
>> [1] 
>> https://gitlab.com/mediatek/aiot/bsp/linux/-/blob/mtk-v5.15-dev/arch/arm64/boot/dts/mediatek/mt8365-pumpkin.dts
>>
>> Co-developed-by: Fabien Parent <fparent@baylibre.com>
>> Signed-off-by: Fabien Parent <fparent@baylibre.com>
>> Co-developed-by: Paul Elder <paul.elder@ideasonboard.com>
>> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> ---
>> Changes compared to the BSP version:
>>
>> - Add ethernet controller
>> - Add GPIO LEDs
>> - Add reserved memory region for BL31
>> - Update board model and compatible
>> - Rename enable-sdio-wakeup to wakeup-source
>> - Drop audio support
>> - Drop display support
>> - Drop dual role USB support
>> - Don't use underscores in node names
>> - Normalize pinmux node names
>> - Remove unneeded labels
>> - Drop unneeded always-on
>> - Drop unused pinmux nodes
>> - Drop camera GPIO hog
>> - Update copyright
>> - Fix formatting
>> - Sort alphabetically
>> ---
>>   arch/arm64/boot/dts/mediatek/Makefile         |   1 +
>>   .../boot/dts/mediatek/mt8365-pumpkin.dts      | 542 ++++++++++++++++++
>>   2 files changed, 543 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin.dts
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/Makefile 
>> b/arch/arm64/boot/dts/mediatek/Makefile
>> index c99c3372a4b5..bbc232bdadc4 100644
>> --- a/arch/arm64/boot/dts/mediatek/Makefile
>> +++ b/arch/arm64/boot/dts/mediatek/Makefile
>> @@ -53,4 +53,5 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8195-cherry-tomato-r3.dtb
>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt8195-demo.dtb
>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt8195-evb.dtb
>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-evk.dtb
>> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-pumpkin.dtb
>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8365-pumpkin.dts 
>> b/arch/arm64/boot/dts/mediatek/mt8365-pumpkin.dts
>> new file mode 100644
>> index 000000000000..88fa5d19c627
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/mediatek/mt8365-pumpkin.dts
>> @@ -0,0 +1,542 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (c) 2021 BayLibre, SAS.
>> + * Copyright (c) 2023 Ideas on Board Oy
>> + *
>> + * Author: Fabien Parent <fparent@baylibre.com>
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/input/input.h>
>> +#include <dt-bindings/leds/common.h>
>> +#include <dt-bindings/pinctrl/mt8365-pinfunc.h>
>> +
>> +#include "mt8365.dtsi"
>> +#include "mt6357.dtsi"
>> +
>> +/ {
>> +    model = "OLogic Pumpkin i350 EVK";
>> +    compatible = "ologic,pumpkin-i350", "mediatek,mt8365";
>> +
>> +    aliases {
>> +        ethernet0 = &ethernet_usb;
>> +        mmc0 = &mmc0;
>> +        mmc1 = &mmc1;
>> +        mmc2 = &mmc2;
> 
> Are mmc aliases needed ?
> 

This makes sure that, for example, the eMMC is always mmcblk0, and
that a (micro)SD card always has mmcblk1.

So yes, they are.

Cheers,
Angelo