From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>,
Srinivas Neeli <srinivas.neeli@amd.com>,
wim@linux-watchdog.org, shubhrajyoti.datta@amd.com,
michal.simek@amd.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
git@amd.com
Subject: Re: [PATCH 2/3] watchdog: xilinx_wwdt: Add Versal window watchdog support
Date: Mon, 3 Oct 2022 09:00:11 +0200 [thread overview]
Message-ID: <e92d1547-428c-0232-d769-9c342e3a0c88@linaro.org> (raw)
In-Reply-To: <1cb7fdb7-ebad-a61e-490c-80e6c9feab2b@roeck-us.net>
On 02/10/2022 18:29, Guenter Roeck wrote:
> On 9/30/22 03:35, Krzysztof Kozlowski wrote:
>> On 27/09/2022 13:02, Srinivas Neeli wrote:
>>> +
>>> +static void xwwdt_clk_disable_unprepare(void *data)
>>> +{
>>> + clk_disable_unprepare(data);
>>
>> If watchdog is stopped and then device unbound, don't you have double
>> disable? IOW, where is matching clk_enable?
>>
>
> After looking into the entire driver code, I see the problem:
> clk_disable() is called in the stop function. That is wrong;
> if the clock is disabled in the stop function, it needs to be
Yep. clk_disable and clk_enable are always paired. In probe they are
pared with remove() or reset-action. This one is in stop(), so it does
not have its pair.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-03 7:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 11:02 [PATCH 0/3] watchdog: xilinx_wwdt: Add Versal watchdog support Srinivas Neeli
2022-09-27 11:02 ` [PATCH 1/3] dt-bindings: watchdog: xlnx,versal-wwdt: Add binding documentation for xilinx window watchdog device Srinivas Neeli
2022-09-29 22:20 ` Rob Herring
2022-09-30 10:31 ` Krzysztof Kozlowski
2022-09-27 11:02 ` [PATCH 2/3] watchdog: xilinx_wwdt: Add Versal window watchdog support Srinivas Neeli
2022-09-30 10:35 ` Krzysztof Kozlowski
2022-10-02 16:06 ` Guenter Roeck
2022-10-02 16:29 ` Guenter Roeck
2022-10-03 7:00 ` Krzysztof Kozlowski [this message]
2022-10-02 16:25 ` Guenter Roeck
2022-10-11 6:27 ` Neeli, Srinivas
2022-11-03 16:51 ` Neeli, Srinivas
2022-11-03 17:24 ` Guenter Roeck
2022-11-06 15:16 ` Neeli, Srinivas
2022-12-01 11:08 ` Michal Simek
2022-12-01 15:56 ` Guenter Roeck
2022-10-03 2:06 ` kernel test robot
2022-09-27 11:02 ` [PATCH 3/3] MAINTAINERS: Add fragment for Xilinx watchdog drivers Srinivas Neeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e92d1547-428c-0232-d769-9c342e3a0c88@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michal.simek@amd.com \
--cc=robh+dt@kernel.org \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.neeli@amd.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).