From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB7DBC76186 for ; Fri, 10 Mar 2023 09:40:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229890AbjCJJk1 (ORCPT ); Fri, 10 Mar 2023 04:40:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230098AbjCJJji (ORCPT ); Fri, 10 Mar 2023 04:39:38 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 605B32CFCE for ; Fri, 10 Mar 2023 01:37:45 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id da10so18071086edb.3 for ; Fri, 10 Mar 2023 01:37:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678441064; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=72MIaSfWuU9e23TmX4jMSQ8I9cDWMHGQ0vlumsHCWRY=; b=oAdyF9OPlB0+VurFpfI9tL2uxeN9JTolrLXu424nx1gEhj+QjaA/1bvJ7DJBKjT/Vz V7SeOlcmUAsdK6CQhyEd2nBks0w+TzUHBmp+HaVN5zffM71mW+j6sTk9YFMO5STC2UVT 2OuSZpvpkUyJPsAvea1CgVh+Bx3S6F+tkmye74DpZjCqapcGkgcXcDoEfvVzts78zJTM Ce+pzxyf7gsWIn3arLSZ8lNXk6vNJKt9V+TJTSAPnQusSHKEXpXa4MXeR/veeNk74MYX 6PYpQKLC6/iTc11ClawHywABYhEnOV6DviLmOmzWtpJqTMCrSXlCaL+2YFKc1Cst2AbG Lm9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678441064; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=72MIaSfWuU9e23TmX4jMSQ8I9cDWMHGQ0vlumsHCWRY=; b=YBf4i5fTUC5kIOMpdPAM+Fruozkpw6Ha16XmHJiWiyB+nwmzRsuAr0GCkwQ/PFEjTz fhcuCGxLU4fDrxywnBrnjxsP3GM3Y237bbpXYLhTGAU2dhStqCLYUQYCZTj3URAlk9M+ bro07MxWAXBJhfrbFYd8JALHq4D4i0NGhObtxdI4KvvI22Rt1PHExdYvJBePISmvjUUE 6rhtWYuMswypkDKKab0GoS2xHZqvn4LQwP1tHd1RnMXrJ+e7XueBjvFnuGQW4WAivxk3 03TTWQRiLGeWhcEYlhjSHf+NptotJ//jOdXXZo5pFaJU/riamrAIN5XYS3cgWzocwKFS 3kUA== X-Gm-Message-State: AO0yUKXcpYPYQj0Ip+4/scdDvunsXUC7cqrMOQVNr8tnIaN+2Hegl/EM VVwUW9Q2Zuf9qPl9B/YSRN12Dw== X-Google-Smtp-Source: AK7set/eFfiMqvRDo7L2flhVa4/blql11k6Nnytdu12WJy0s9z80h3CK/JPZUQ2Clnp0i+jFDAmoew== X-Received: by 2002:a17:907:c24:b0:8aa:bf48:aae1 with SMTP id ga36-20020a1709070c2400b008aabf48aae1mr34138480ejc.6.1678441063852; Fri, 10 Mar 2023 01:37:43 -0800 (PST) Received: from ?IPV6:2a02:810d:15c0:828:2a59:841a:ebc:7974? ([2a02:810d:15c0:828:2a59:841a:ebc:7974]) by smtp.gmail.com with ESMTPSA id i9-20020a508709000000b004c0897f045bsm605087edb.56.2023.03.10.01.37.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Mar 2023 01:37:43 -0800 (PST) Message-ID: Date: Fri, 10 Mar 2023 10:37:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC PATCH v2 7/7] arm64: dts: qcom: Add the Inline Crypto Engine nodes Content-Language: en-US To: Abel Vesa Cc: Eric Biggers , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , Alim Akhtar , Avri Altman , Bart Van Assche , Adrian Hunter , "James E . J . Bottomley" , "Martin K . Petersen" , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org References: <20230308155838.1094920-1-abel.vesa@linaro.org> <20230308155838.1094920-8-abel.vesa@linaro.org> <4eab53fc-2d26-dc93-3ae6-c0b2546ad3e0@linaro.org> <4ea944dd-8a42-e83f-607c-1a36124d19bb@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/03/2023 10:34, Abel Vesa wrote: >>> I assume you mean it breaks if someone is using old approach DTS with a >>> kernel that would have ICE driver merged. Yes, that it does. And for >>> that, in the v3, I'll make of_qcom_ice_get check if there is a reg entry >>> with name "ice" and create an ICE instance but for the same dev as the >>> consumer driver. OTOH, if there is no reg entry called "ice", it will >>> look up a device based on phande of qcom,ice property. This will allow >>> legacy style DTS to work fine, while using the unified driver as a >>> library, in that case. For newer platforms, the recommended approach >>> will be to add a new ICE node and use qcom,ice property. >> >> For the driver this sounds good. I still think that existing (older) DTS >> should not have regs removed, because this affects other users of kernel >> DTS. > > Yes, that's what I meant, the already supported platforms will remain > with ice reg in the consumer node. ... unless you plan to add to them UFS ICE, which would be nice feature thus justifying DTS re-shuffle :) Best regards, Krzysztof