From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kamal Dasu <kdasu.kdev@gmail.com>,
ulf.hansson@linaro.org, robh+dt@kernel.org, krzk+dt@kernel.org,
alcooperx@gmail.com
Cc: f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com,
adrian.hunter@intel.com, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] dt-bindings: mmc: Add Broadcom optional sdio_freq clock
Date: Thu, 28 Apr 2022 10:12:57 +0200 [thread overview]
Message-ID: <e945cc6f-fd1b-5ba5-fab9-33672994d54b@linaro.org> (raw)
In-Reply-To: <20220427180853.35970-4-kdasu.kdev@gmail.com>
On 27/04/2022 20:08, Kamal Dasu wrote:
Thank you for your patch. There is something to discuss/improve.
>
> clocks:
> - maxItems: 1
> - description:
> - handle to core clock for the sdhci controller.
> + minItems: 1
> + items:
> + - description: handle to core clock for the sdhci controller
> + - description: improved 150Mhz clock for sdhci controller (Optional clock)
>
> clock-names:
> + minItems: 1
> items:
> - const: sw_sdio
> + - const: sdio_freq # Optional clock
>
> sdhci,auto-cmd12:
> type: boolean
> description: Specifies that controller should use auto CMD12
>
> +allOf:
> + - $ref: mmc-controller.yaml#
> + - if:
> + properties:
> + clock-names:
> + contains:
> + const: sdio_freq
> +
> + - then:
This won't work. Please test your bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-28 8:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 18:08 [PATCH v2 0/4] mmc: sdhci-brcmstb: host controller clock enhancements Kamal Dasu
2022-04-27 18:08 ` [PATCH v2 1/4] mmc: sdhci-brcmstb: Re-organize flags Kamal Dasu
2022-05-04 10:37 ` Ulf Hansson
2022-04-27 18:08 ` [PATCH v2 2/4] mmc: sdhci-brcmstb: Enable Clock Gating to save power Kamal Dasu
2022-04-27 21:39 ` Ulf Hansson
2022-04-27 21:43 ` Florian Fainelli
2022-05-04 10:37 ` Ulf Hansson
2022-04-27 18:08 ` [PATCH v2 3/4] dt-bindings: mmc: Add Broadcom optional sdio_freq clock Kamal Dasu
2022-04-28 8:12 ` Krzysztof Kozlowski [this message]
2022-04-28 8:14 ` Krzysztof Kozlowski
2022-04-27 18:08 ` [PATCH v2 4/4] mmc: sdhci-brcmstb: Add ability to increase max clock rate for 72116b0 Kamal Dasu
2022-04-27 21:49 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e945cc6f-fd1b-5ba5-fab9-33672994d54b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kdasu.kdev@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).