From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Changhuang Liang <changhuang.liang@starfivetech.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Jack Zhu <jack.zhu@starfivetech.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v1 1/4] riscv: dts: starfive: jh7110: Add aon syscon node
Date: Mon, 13 Feb 2023 10:28:08 +0100 [thread overview]
Message-ID: <e94c3d2c-10ab-01a6-ff41-cbca34b88fcf@linaro.org> (raw)
In-Reply-To: <20230210061713.6449-2-changhuang.liang@starfivetech.com>
On 10/02/2023 07:17, Changhuang Liang wrote:
> Add aon syscon node for the Starfive JH7110 SoC. It can be used by
> other modules such as DPHY.
>
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> ---
> arch/riscv/boot/dts/starfive/jh7110.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> index cfbaff4ea64b..bce3e407ab60 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> @@ -251,6 +251,11 @@ soc {
> #size-cells = <2>;
> ranges;
>
> + aon_syscon: aon_syscon@17010000 {
No underscores in node names, generic node names.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "syscon";
Nope. syscon cannot be alone. Run dtbs_check before sending DTS.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-13 9:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 6:17 [PATCH v1 0/4] Add JH7110 MIPI DPHY RX support Changhuang Liang
2023-02-10 6:17 ` [PATCH v1 1/4] riscv: dts: starfive: jh7110: Add aon syscon node Changhuang Liang
2023-02-13 9:28 ` Krzysztof Kozlowski [this message]
2023-02-14 2:18 ` Changhuang Liang
2023-02-10 6:17 ` [PATCH v1 2/4] dt-bindings: phy: Add starfive,jh7110-dphy-rx Changhuang Liang
2023-02-10 13:58 ` Rob Herring
2023-02-13 7:47 ` Changhuang Liang
2023-02-10 18:29 ` Rob Herring
2023-02-13 7:51 ` Changhuang Liang
2023-02-13 9:30 ` Krzysztof Kozlowski
2023-02-14 3:07 ` Changhuang Liang
2023-02-14 7:49 ` Krzysztof Kozlowski
2023-02-15 1:27 ` Changhuang Liang
2023-02-10 6:17 ` [PATCH v1 3/4] phy: starfive: Add mipi dphy rx support Changhuang Liang
2023-02-10 6:17 ` [PATCH v1 4/4] riscv: dts: starfive: Add dphy rx node Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e94c3d2c-10ab-01a6-ff41-cbca34b88fcf@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=changhuang.liang@starfivetech.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jack.zhu@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).