From: Thor Thayer <thor.thayer@linux.intel.com>
To: Dinh Nguyen <dinguyen@kernel.org>,
bp@alien8.de, mchehab@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, catalin.marinas@arm.com,
will.deacon@arm.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-edac@vger.kernel.org
Subject: Re: [PATCH 1/3] Documentation: dt: socfpga: Add Stratix10 ECC Manager binding
Date: Thu, 26 Apr 2018 09:43:54 -0500 [thread overview]
Message-ID: <e9606cfb-cee6-2e0c-cfe5-c91a537cb8a2@linux.intel.com> (raw)
In-Reply-To: <6528e94e-85ea-8015-5a3b-4e8a9ecc8dbd@kernel.org>
On 04/25/2018 09:16 PM, Dinh Nguyen wrote:
>
>
> On 04/24/2018 01:35 PM, thor.thayer@linux.intel.com wrote:
>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>
>> Add the device tree bindings needed to support the Stratix10
>> ECC Manager and SDRAM ECC to the existing bindings.
>>
>> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
>> ---
>> .../bindings/arm/altera/socfpga-eccmgr.txt | 47 ++++++++++++++++++++++
>> 1 file changed, 47 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt b/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt
>> index 4a1714f96bab..fe48ad293a24 100644
>> --- a/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt
>> +++ b/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt
>> @@ -231,3 +231,50 @@ Example:
>> <48 IRQ_TYPE_LEVEL_HIGH>;
>> };
>> };
>> +
>> +Stratix10 SoCFPGA ECC Manager
>> +The Stratix10 SoC ECC Manager handles the IRQs for each peripheral
>> +in a shared register similar to the Arria10. However, ECC requires
>> +access to registers that can only be read in EL3 with SMC calls.
>> +Therefore the device tree is slightly different.
>> +
>> +Required Properties:
>> +- compatible : Should be "altr,socfpga-s10-ecc-manager"
>
> Altera technically doesn't exist anymore, should this be
> "intel,stratix10-ecc-manager"?
>
I was trying to be consistent with the older names but I agree with your
argument. I will change this. Thanks
> Dinh
> --
> To unsubscribe from this list: send the line "unsubscribe linux-edac" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2018-04-26 14:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 18:35 [PATCH 0/3] Add SDRAM ECC support for Stratix10 thor.thayer
2018-04-24 18:35 ` [PATCH 1/3] Documentation: dt: socfpga: Add Stratix10 ECC Manager binding thor.thayer
2018-04-26 2:16 ` Dinh Nguyen
2018-04-26 14:43 ` Thor Thayer [this message]
2018-04-26 14:58 ` Thor Thayer
2018-04-26 15:01 ` Dinh Nguyen
2018-04-26 15:06 ` Rob Herring
2018-04-24 18:35 ` [PATCH 2/3] edac: altera: Add support for Stratix10 SDRAM EDAC thor.thayer
2018-04-26 2:14 ` Dinh Nguyen
2018-04-26 6:08 ` Borislav Petkov
2018-04-26 14:42 ` Thor Thayer
2018-04-24 18:35 ` [PATCH 3/3] arm64: dts: stratix10: add sdram ecc thor.thayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9606cfb-cee6-2e0c-cfe5-c91a537cb8a2@linux.intel.com \
--to=thor.thayer@linux.intel.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).