From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C3F6C67871 for ; Mon, 24 Oct 2022 22:28:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230243AbiJXW2Z (ORCPT ); Mon, 24 Oct 2022 18:28:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231204AbiJXW2J (ORCPT ); Mon, 24 Oct 2022 18:28:09 -0400 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11A673B46C for ; Mon, 24 Oct 2022 13:49:43 -0700 (PDT) Received: by mail-qk1-x72e.google.com with SMTP id t25so6861593qkm.2 for ; Mon, 24 Oct 2022 13:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GkmpsNViylq9BB1MxlxYNFU9pC/HN95G5AphBwXIurI=; b=PGDd8ik8IIwKMIUsrm1jKXFQuLvqCRne6jdZeJ4bATC8PlKLBy+xP6ra7bzvwU4EDY nG7fYF+SYQWA92kpD6XvUbVp9/qx/y3igNzKGu9EYc1cj6D3upzQNZFGXOoW1iSBTB5E fn+RNtDYNRhYQbHmf8/0aYChksmKoUhSIJ41QkPi/i8MY8PsPh0Zw8ecuMEi31Gei4Q6 nV5UIGT7Qjq2PgPXhjD4edUcxw/KIYWvXF4/hPeDoFxtrxAx4jgLDQA8cchQHhKLY/4v RCV0M9sfC1ZDdi/pnUjMyNcZYUD4ja8t8FS6F3Yoduk/RpvMADAyzhsyMc+XgIoLSXhG uFmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GkmpsNViylq9BB1MxlxYNFU9pC/HN95G5AphBwXIurI=; b=Yx8PWF1ONNWby5GRPghRuYFiatiq0RxtvrjbBtJDSYKu+SR4EJ3u9h7QVfXxa2z57o O6+IGKCG9yQ9YU7OY14z/Z4K6lyv7MkZ2EqYD2vZ3beRo0w8TfCNms64IlFssSF1y1cV d1ps7sIjkaSIpzywBq1QbweheT57l3J0ERmoDZzl0QXpxt/AVU1ALrZ4Uzcr5QyvM8o+ zdmlpu8tZXKvjC7IIw1kWOMstHrQsTvOSWow9cDIWmublAxId5JkvX4F0ydtpKOJlYod vOKF8Bx5Ro6DUPdUR/4rZMKzdcIZqaTY0YgfBLuMNxVjQs1ZbCAKiBObSAZjB86OLTpQ BJbA== X-Gm-Message-State: ACrzQf37h5SnQnKCuA0gDpL1wFifaaHW6oMjOtQv2EgRM5+k8UB60r1q 4iylOcj8RXH1X6RLS2XSDGji7A== X-Google-Smtp-Source: AMsMyM6ZkZ/psZ7xFtzSk2+QefOCkJiSaxQwDA09YPJIno7suqbPrkOOfDSNwZb+THNYQaurWqW+lA== X-Received: by 2002:a05:620a:28d2:b0:6ef:a7f:dee4 with SMTP id l18-20020a05620a28d200b006ef0a7fdee4mr16570214qkp.400.1666644475623; Mon, 24 Oct 2022 13:47:55 -0700 (PDT) Received: from [192.168.1.8] ([64.57.193.93]) by smtp.gmail.com with ESMTPSA id w3-20020ac857c3000000b0039442ee69c5sm490305qta.91.2022.10.24.13.47.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Oct 2022 13:47:55 -0700 (PDT) Message-ID: Date: Mon, 24 Oct 2022 16:47:53 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 1/1] dt-bindings: net: snps,dwmac: Document queue config subnodes Content-Language: en-US To: Rob Herring Cc: Sebastian Reichel , Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20221021171055.85888-1-sebastian.reichel@collabora.com> <761d6ae2-e779-2a4b-a735-960c716c3024@linaro.org> <20221024185312.GA2037160-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20221024185312.GA2037160-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/10/2022 14:53, Rob Herring wrote: > On Sat, Oct 22, 2022 at 12:05:15PM -0400, Krzysztof Kozlowski wrote: >> On 21/10/2022 13:10, Sebastian Reichel wrote: >>> The queue configuration is referenced by snps,mtl-rx-config and >>> snps,mtl-tx-config. Most in-tree DTs put the referenced object >>> as child node of the dwmac node. >>> >>> This adds proper description for this setup, which has the >>> advantage of properly making sure only known properties are >>> used. >>> >>> Signed-off-by: Sebastian Reichel >>> --- >>> .../devicetree/bindings/net/snps,dwmac.yaml | 154 ++++++++++++------ >>> 1 file changed, 108 insertions(+), 46 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> index 13b984076af5..0bf6112cec2f 100644 >>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> @@ -167,56 +167,118 @@ properties: >>> snps,mtl-rx-config: >>> $ref: /schemas/types.yaml#/definitions/phandle >>> description: >>> - Multiple RX Queues parameters. Phandle to a node that can >>> - contain the following properties >>> - * snps,rx-queues-to-use, number of RX queues to be used in the >>> - driver >>> - * Choose one of these RX scheduling algorithms >>> - * snps,rx-sched-sp, Strict priority >>> - * snps,rx-sched-wsp, Weighted Strict priority >>> - * For each RX queue >>> - * Choose one of these modes >>> - * snps,dcb-algorithm, Queue to be enabled as DCB >>> - * snps,avb-algorithm, Queue to be enabled as AVB >>> - * snps,map-to-dma-channel, Channel to map >>> - * Specifiy specific packet routing >>> - * snps,route-avcp, AV Untagged Control packets >>> - * snps,route-ptp, PTP Packets >>> - * snps,route-dcbcp, DCB Control Packets >>> - * snps,route-up, Untagged Packets >>> - * snps,route-multi-broad, Multicast & Broadcast Packets >>> - * snps,priority, bitmask of the tagged frames priorities assigned to >>> - the queue >>> + Multiple RX Queues parameters. Phandle to a node that >>> + implements the 'rx-queues-config' object described in >>> + this binding. >>> + >>> + rx-queues-config: >> >> If this field is specific to this device, then you need vendor prefix: >> snps,rq-queues-config > > Not for a node name... Right. Best regards, Krzysztof