From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 069CE3D8907 for ; Thu, 2 Apr 2026 10:18:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775125089; cv=none; b=qbKku/YUnCwMks2ppzDKH+wyxRtoKtcdzCGoQ+FOytblxPTKsQ/iq6Z1Ur09b8uv771CkFQvuk3ZO0XRMaxE05tTyRyJ6UPyGBArQs0f3Z1hJoFVfxB+2Cdku2Cm4eFiNMstJ4aAodk7uF+0AS3nBDqoelmxUVjqHudppio8DgM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775125089; c=relaxed/simple; bh=FCW+QEqAKG4hH9LnpegUY4FB9hpvqVVZgYJXOi9VoZM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=coT6lFQUG4bKM8/FRCc/ZkNSodYjoZu8NZmlCj0JoOBrSLDSj/Ktgj1y9EAoIijK5A+Aupj0OjRgfO4o0xuaYSqh3lepY5C9dt/38lVB6U+WFkbPt204SUHofsXD+XB4UCAL5PhYNReassVeN1HA3EoyZh9lupS6dXtLdpGJxW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Dw3tIUJP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Syf+83yd; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Dw3tIUJP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Syf+83yd" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6326nDqC1965355 for ; Thu, 2 Apr 2026 10:18:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0uG7ywldOjaUzeof/WNjOjTtdACVD5rMx6FLWvsBrfA=; b=Dw3tIUJPBonguF/a pcBCLU6rKaGB3GO8S6EhXEtOzfrit5UUdEXKxZvWxEy7gHcv7p00MZlBhEXH82DW 29jLg8VWJv+qOoNhFIdWfd3XpNkcb0jixI0pE8VuFLIfHwNCWt4NtRKxzzx04Djv ulksf7aYDpkH0jME2bRibQeXqQ/c3VTtpN0SkoA1FGS0pJvB7+pa3KwB67zQjelJ MynkTCxMQYaurjeSDKNr5t7mZjx+fM+Vmfj0UvL6NcBL+2kDX8nZ67oA2IC8TCM9 cD44iUrTe+C8haMH5cXhNhB7Y5Wx5Al3Zqn8+Y/MqeW9Qx7rG/QrrCAEv0LNmWNb 3FjJfQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d9b9h2kgn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Apr 2026 10:18:07 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3568090851aso1545744a91.1 for ; Thu, 02 Apr 2026 03:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775125087; x=1775729887; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0uG7ywldOjaUzeof/WNjOjTtdACVD5rMx6FLWvsBrfA=; b=Syf+83ydNW1D8Os2D/yvuXV5BAfRDpXqXK5Cn1xAy7iASqqjg0PVlulJi1GaVg6K0o S8Hdm9RiN8Uq1N2cAfOJRdJunk2DYT+Ca86RH8vkqfEYQBte94JpwBKD6xOi/Q9PFzpI KYNF3CBoPK9U7skppaPWxFHpSs+rAAzS7WWCGJDeX8WrZapPpjiDpYiQ8LT7a5C9PJF3 yBfXV+TcXfMSUyfm+H6tK/B5UU2qTDLIN7e1Av2MmQKsPPt2Z3pGC1noOAse9nAS25Wi NHZxbb8aKsqGmQwxEgIG+k+KvyO0QbMV1kJR+khsieLLZe9TjeCFqBrNjn+AAv2ziWyD lqbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775125087; x=1775729887; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0uG7ywldOjaUzeof/WNjOjTtdACVD5rMx6FLWvsBrfA=; b=YwU08lgV6dzmufC3OdCl0CKhef8FpP1EUyQmlkD+sfEFcoyoK6QtEGpXSXIqC1qonT ZqLQVTzDUnfRU6I1f9kNxaWwZVNgrvtccZviv4hf1M//X2z8yfb6JJm7jj8Z3HjuQ/uY tPGPXXWKT78tVdVqWa+5hNokAvFZlq+WpCYZJLSq4Ko3abgsJ4AqXq5tlyD57ewvLaEw rY9CS51QiTb9MXdvrF/Jesqvr06C6Wff7XimhcyWJJdDVDbTdRIiPJ5u81mUSwVF/jD9 PjVK6XYnBkWHXCJGq2kZIjfDIF7PBJC884WGriUsvNeYguK9ygIaXhzxfScL14ZtL8Hl rCcg== X-Forwarded-Encrypted: i=1; AJvYcCXIczY+EerG1XwUXW3+XbirSSiM+bgCAPG1jODqDXZCV6DwEyOUVhmRyVRaYxoWry1HtEXgzqM2ybYq@vger.kernel.org X-Gm-Message-State: AOJu0YztjSjrmqOMSpRlFHnSQxWKMVLoASnlfc1xuCMceJMZPxH/c8qZ QAJJ4aHK+X3qazCVJ2FNZIVp1BBl58xn3uek4Fa+J3kCxqu+5ZF6uYuVEbceD4IpBzIDHhEDjRY 4EcQN+O2YQlcMZFlSWaZ7UskjthLnOFUIg4c9I9LT/boBaOOklhVmyla1m42qZL4A X-Gm-Gg: AeBDievp5wZmz4QMJbp7YSDLwmV0ZUV89vSadVPB1Amsepw+mdZb5TCSQIGbv0sTZS6 QzMOethQXxBWpgEhBx88qSwqgRUuOed+yBDhjXUkuI7BA6FjuTKf7EbPospwyWReWSrS1rWvyz6 p+nZiBAIdiwio4qchHRagHK897ZvtO9n9LaqQpCrofEL7F339jq8bKnRZfoCmjD19CQgTlHqJhq brH7e2a6ohSryd6I882dx3swOdIqlpylQv3LTuLZEH+L5jBxTYgO97f6E9sYmIz5m6kTFIjseGv XSL0aH0Lqd4Ofq2EPXVqspxOUi+uB9+jIx9R+uCqNDhhQBq9jYfPwerJsUXYrtG8rYrgVhiTNZz EuMKNyRT/MSdtxN3cSQD3hC2fQkBgJX7km3ZzhY1TUKE0rEWZ0Bjk8vUw6EFDaCzcfZDiZvYlRJ MzSsCEdHg1v3s= X-Received: by 2002:a17:90b:2ec4:b0:34c:904a:d92 with SMTP id 98e67ed59e1d1-35dc6fdd803mr6465771a91.26.1775125086494; Thu, 02 Apr 2026 03:18:06 -0700 (PDT) X-Received: by 2002:a17:90b:2ec4:b0:34c:904a:d92 with SMTP id 98e67ed59e1d1-35dc6fdd803mr6465739a91.26.1775125085899; Thu, 02 Apr 2026 03:18:05 -0700 (PDT) Received: from [10.133.33.180] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dbe62f5dbsm7631844a91.8.2026.04.02.03.18.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2026 03:18:05 -0700 (PDT) Message-ID: Date: Thu, 2 Apr 2026 18:18:00 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 2/7] qcom-tgu: Add TGU driver To: Songwei Chai , andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, konrad.dybcio@oss.qualcomm.com, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org References: <20260402092838.341295-1-songwei.chai@oss.qualcomm.com> <20260402092838.341295-3-songwei.chai@oss.qualcomm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20260402092838.341295-3-songwei.chai@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=TqLrRTXh c=1 sm=1 tr=0 ts=69ce425f cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=RlaAdA2wXV2HMp-xn2gA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: 1rdpzvTzEdayvFjWHO5wjDcpvfNtnmhy X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAyMDA5MiBTYWx0ZWRfX4fPLeTY40Lz4 GfVWYUu8eDd+b5sVQUjf50BEgwm4PgAraSUZGHFoIAvRy5bbeGoq4UTg1Zdiv/R9TUiUQUcluGS RvbjY7m88tJyh1Ne+aQUaC8LSTcKX2sxzeV6GJARxq0PaDY3u0Qdwg9LUQS0+fFfSZEE7qQ8dXy dek5AIkVv7w1Hp10Dms1DhfKWkjIVMtvRpuywWEUDFhYmG6APwGO7MGa8Ca8mzvhOaz/jKmnrwW bF1a81Zi5LgbXZTYJco1WBMWP+dBhPYL9kGgN29OY1PxfSe/HBDnk50u/NrxGVmmnN2fOu2aljb 8wMyFDFjmrRgyFUEc/PynFHfy2X7ahaLH2TUTLW1ug/0pOFRbOukWf6unlBAYBoeNoTcvbxvYVR ewUw8NotAMvd2jd3PGrltW72CRrCnpsKRz2fW6Zd+IY9ezIhnlWYuw4LVBgGVonXEX84AD1H4SJ jw4Kmny7OKI3WkOmtmg== X-Proofpoint-GUID: 1rdpzvTzEdayvFjWHO5wjDcpvfNtnmhy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-02_01,2026-04-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020092 On 4/2/2026 5:28 PM, Songwei Chai wrote: > Add driver to support device TGU (Trigger Generation Unit). > TGU is a Data Engine which can be utilized to sense a plurality of > signals and create a trigger into the CTI or generate interrupts to > processors. Add probe/enable/disable functions for tgu. > > Signed-off-by: Songwei Chai > --- > .../ABI/testing/sysfs-bus-amba-devices-tgu | 9 + > drivers/Makefile | 1 + > drivers/hwtracing/Kconfig | 2 + > drivers/hwtracing/qcom/Kconfig | 18 ++ > drivers/hwtracing/qcom/Makefile | 3 + > drivers/hwtracing/qcom/tgu.c | 193 ++++++++++++++++++ > drivers/hwtracing/qcom/tgu.h | 51 +++++ > 7 files changed, 277 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > create mode 100644 drivers/hwtracing/qcom/Kconfig > create mode 100644 drivers/hwtracing/qcom/Makefile > create mode 100644 drivers/hwtracing/qcom/tgu.c > create mode 100644 drivers/hwtracing/qcom/tgu.h > > diff --git a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > new file mode 100644 > index 000000000000..f877a00fcaa5 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > @@ -0,0 +1,9 @@ > +What: /sys/bus/amba/devices//enable_tgu > +Date: April 2026 > +KernelVersion: 7.1 > +Contact: Jinlong Mao , Songwei Chai > +Description: > + (RW) Set/Get the enable/disable status of TGU > + Accepts only one of the 2 values - 0 or 1. > + 0 : disable TGU. > + 1 : enable TGU. > diff --git a/drivers/Makefile b/drivers/Makefile > index 53fbd2e0acdd..82b712a12a26 100644 > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -177,6 +177,7 @@ obj-$(CONFIG_RAS) += ras/ > obj-$(CONFIG_USB4) += thunderbolt/ > obj-$(CONFIG_CORESIGHT) += hwtracing/coresight/ > obj-y += hwtracing/intel_th/ > +obj-y += hwtracing/qcom/ > obj-$(CONFIG_STM) += hwtracing/stm/ > obj-$(CONFIG_HISI_PTT) += hwtracing/ptt/ > obj-y += android/ > diff --git a/drivers/hwtracing/Kconfig b/drivers/hwtracing/Kconfig > index 911ee977103c..8a640218eed8 100644 > --- a/drivers/hwtracing/Kconfig > +++ b/drivers/hwtracing/Kconfig > @@ -7,4 +7,6 @@ source "drivers/hwtracing/intel_th/Kconfig" > > source "drivers/hwtracing/ptt/Kconfig" > > +source "drivers/hwtracing/qcom/Kconfig" > + > endmenu > diff --git a/drivers/hwtracing/qcom/Kconfig b/drivers/hwtracing/qcom/Kconfig > new file mode 100644 > index 000000000000..d6f6d4b0f28e > --- /dev/null > +++ b/drivers/hwtracing/qcom/Kconfig > @@ -0,0 +1,18 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# QCOM specific hwtracing drivers > +# > +menu "Qualcomm specific hwtracing drivers" > + > +config QCOM_TGU > + tristate "QCOM Trigger Generation Unit driver" depends on ARCH_QCOM || COMPILE_TEST depends on ARM_AMBA > + help > + This driver provides support for Trigger Generation Unit that is > + used to detect patterns or sequences on a given set of signals. > + TGU is used to monitor a particular bus within a given region to > + detect illegal transaction sequences or slave responses. It is also > + used to monitor a data stream to detect protocol violations and to > + provide a trigger point for centering data around a specific event > + within the trace data buffer. > + > +endmenu > diff --git a/drivers/hwtracing/qcom/Makefile b/drivers/hwtracing/qcom/Makefile > new file mode 100644 > index 000000000000..5a0a868c1ea0 > --- /dev/null > +++ b/drivers/hwtracing/qcom/Makefile > @@ -0,0 +1,3 @@ > +# SPDX-License-Identifier: GPL-2.0 > + > +obj-$(CONFIG_QCOM_TGU) += tgu.o > diff --git a/drivers/hwtracing/qcom/tgu.c b/drivers/hwtracing/qcom/tgu.c > new file mode 100644 > index 000000000000..49c8f710b931 > --- /dev/null > +++ b/drivers/hwtracing/qcom/tgu.c > @@ -0,0 +1,193 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "tgu.h" > + > +static void tgu_write_all_hw_regs(struct tgu_drvdata *drvdata) > +{ > + TGU_UNLOCK(drvdata->base); > + /* Enable TGU to program the triggers */ > + writel(1, drvdata->base + TGU_CONTROL); > + TGU_LOCK(drvdata->base); > +} > + > +static int tgu_enable(struct device *dev) > +{ > + struct tgu_drvdata *drvdata = dev_get_drvdata(dev); > + > + guard(spinlock)(&drvdata->lock); > + drvdata->enabled = true; > + > + tgu_write_all_hw_regs(drvdata); > + > + return 0; > +} > + > +static void tgu_do_disable(struct tgu_drvdata *drvdata) > +{ > + TGU_UNLOCK(drvdata->base); > + writel(0, drvdata->base + TGU_CONTROL); > + TGU_LOCK(drvdata->base); > + > + drvdata->enabled = false; > +} > + > +static void tgu_disable(struct device *dev) > +{ > + struct tgu_drvdata *drvdata = dev_get_drvdata(dev); > + > + guard(spinlock)(&drvdata->lock); > + if (!drvdata->enabled) > + return; > + > + tgu_do_disable(drvdata); > +} > + > +static ssize_t enable_tgu_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct tgu_drvdata *drvdata = dev_get_drvdata(dev); > + bool enabled; > + > + guard(spinlock)(&drvdata->lock); > + enabled = drvdata->enabled; > + > + return sysfs_emit(buf, "%d\n", !!enabled); > +} > + > +/* enable_tgu_store - Configure Trace and Gating Unit (TGU) triggers. */ > +static ssize_t enable_tgu_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, > + size_t size) > +{ > + struct tgu_drvdata *drvdata = dev_get_drvdata(dev); > + unsigned long val; > + int ret; > + > + ret = kstrtoul(buf, 0, &val); > + if (ret || val > 1) > + return -EINVAL; > + > + if (val) { > + scoped_guard(spinlock, &drvdata->lock) { > + if (drvdata->enabled) > + return -EBUSY; > + } > + > + ret = pm_runtime_resume_and_get(dev); > + if (ret) > + return ret; > + > + ret = tgu_enable(dev); > + if (ret) { > + pm_runtime_put(dev); > + return ret; > + } > + } else { > + scoped_guard(spinlock, &drvdata->lock) { > + if (!drvdata->enabled) > + return -EINVAL; > + } > + > + tgu_disable(dev); > + pm_runtime_put(dev); > + } > + > + return size; > +} > +static DEVICE_ATTR_RW(enable_tgu); > + > +static struct attribute *tgu_common_attrs[] = { > + &dev_attr_enable_tgu.attr, > + NULL, > +}; > + > +static const struct attribute_group tgu_common_grp = { > + .attrs = tgu_common_attrs, > + NULL, > +}; > + > +static const struct attribute_group *tgu_attr_groups[] = { > + &tgu_common_grp, > + NULL, > +}; > + > +static int tgu_probe(struct amba_device *adev, const struct amba_id *id) > +{ > + struct device *dev = &adev->dev; > + struct tgu_drvdata *drvdata; > + int ret; > + > + drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > + if (!drvdata) > + return -ENOMEM; > + > + drvdata->dev = &adev->dev; > + dev_set_drvdata(dev, drvdata); > + > + drvdata->base = devm_ioremap_resource(dev, &adev->res); > + if (IS_ERR(drvdata->base)) > + return PTR_ERR(drvdata->base); pm_runtime_enable is called in amba_probe, and amba_probe calls pm_runtime_put_noidle only when tgu_probe succeeds. We need call the pm_runtime_put in error path to reset the runtime refcount. > + > + spin_lock_init(&drvdata->lock); > + > + ret = sysfs_create_groups(&dev->kobj, tgu_attr_groups); > + if (ret) { > + dev_err(dev, "failed to create sysfs groups: %d\n", ret); > + return ret; > + } > + > + drvdata->enabled = false; > + > + pm_runtime_put(&adev->dev); > + > + return 0; > +} > + > +static void tgu_remove(struct amba_device *adev) > +{ > + struct device *dev = &adev->dev; > + > + sysfs_remove_groups(&dev->kobj, tgu_attr_groups); > + > + tgu_disable(dev); > +} > + > +static const struct amba_id tgu_ids[] = { > + { > + .id = 0x000f0e00, > + .mask = 0x000fffff, > + }, > + { 0, 0, NULL }, > +}; > + > +MODULE_DEVICE_TABLE(amba, tgu_ids); > + > +static struct amba_driver tgu_driver = { > + .drv = { > + .name = "qcom-tgu", > + .suppress_bind_attrs = true, > + }, > + .probe = tgu_probe, > + .remove = tgu_remove, > + .id_table = tgu_ids, > +}; > + > +module_amba_driver(tgu_driver); > + > +MODULE_AUTHOR("Songwei Chai "); > +MODULE_AUTHOR("Jinlong Mao "); > +MODULE_DESCRIPTION("Qualcomm Trigger Generation Unit driver"); > +MODULE_LICENSE("GPL"); > diff --git a/drivers/hwtracing/qcom/tgu.h b/drivers/hwtracing/qcom/tgu.h > new file mode 100644 > index 000000000000..dd7533b9d735 > --- /dev/null > +++ b/drivers/hwtracing/qcom/tgu.h > @@ -0,0 +1,51 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +#ifndef _QCOM_TGU_H > +#define _QCOM_TGU_H > + > +/* Register addresses */ > +#define TGU_CONTROL 0x0000 > +#define TGU_LAR 0xfb0 nit: wrong indent here (you can check in vim) Thanks, Jie > +#define TGU_UNLOCK_OFFSET 0xc5acce55 > + > +static inline void TGU_LOCK(void __iomem *addr) > +{ > + do { > + /* Wait for things to settle */ > + mb(); > + writel_relaxed(0x0, addr + TGU_LAR); > + } while (0); > +} > + > +static inline void TGU_UNLOCK(void __iomem *addr) > +{ > + do { > + writel_relaxed(TGU_UNLOCK_OFFSET, addr + TGU_LAR); > + /* Make sure everyone has seen this */ > + mb(); > + } while (0); > +} > + > +/** > + * struct tgu_drvdata - Data structure for a TGU (Trigger Generator Unit) > + * @base: Memory-mapped base address of the TGU device > + * @dev: Pointer to the associated device structure > + * @lock: Spinlock for handling concurrent access to private data > + * @enabled: Flag indicating whether the TGU device is enabled > + * > + * This structure defines the data associated with a TGU device, > + * including its base address, device pointers, clock, spinlock for > + * synchronization, trigger data pointers, maximum limits for various > + * trigger-related parameters, and enable status. > + */ > +struct tgu_drvdata { > + void __iomem *base; > + struct device *dev; > + spinlock_t lock; > + bool enabled; > +}; > + > +#endif