From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD8AE409100 for ; Tue, 30 Jun 2026 12:08:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782821330; cv=none; b=aQ0MI7/DoAdzWVxw/OT4D8cLHZbLD97ZGgn4/jYlpfs9xjzX09F4gqeiBty8fn5GKMoSb31GXrW9CAyTs9JX1N7XXDORT882ck58/zHsDcnQhRPJn7UFfzyXiY6ADu+0+KAfIXQukxcshhLzWxuS5s7FXxcZ9rsITlK6712u/VY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782821330; c=relaxed/simple; bh=ONMuFW5EI8/RP0a/b2yROQE5ScuQZO1jXKqHS+L/EAo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cweKeRFZMKM9hoCol7qqelMgY7rD6bOGQAfWciTPyKuY0tpk+/UYhzU7hbmDyvRRtA0VctCX4DzBcaWSNTSlr5+ZPJOo87sA1Nv27OBsWehZiJY4Qgj7JCn4VH7nUlVaD2evi0/Ix+983GTUXZq2lqdPJUyraQrSVilj60juoSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dze2Zrv+; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dze2Zrv+" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-39b1eab2f29so4994181fa.0 for ; Tue, 30 Jun 2026 05:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782821327; x=1783426127; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0kJ9tc/96xskuFmv4hVq+DCV3Ln9QfqN1toGcCy1OAs=; b=dze2Zrv+xbMQdAeWIHdS/Qq93aPXXeVJY3Wf2zIZbHr0cc9/jHrP2THjGSOLtCG5WQ gLEv63V6odk0yx3H0SIBxKeb29/3AS4quGAzlorhVkXa472T0AI+R64OICrvn/PU7Eso FyRWtgdEmQpwqs8a4tZ7JH8Oin33EqawmZeKknqDnlt8yAxlp2w1MVx/zcqBfcFq9FT2 g/w0F/YfDt2NzXDsQZ5ZfYmlpBXXfdB/SvEGyCyPlRedpp0NHG40HtmLaCIhXRoJCtWv Iafs6osFPcC4bcqIAiqSFvoyz0qsNyVCqLtenB/Yr0AUCXxiNmZU3L9p4jdwLP56b47H KWZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782821327; x=1783426127; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0kJ9tc/96xskuFmv4hVq+DCV3Ln9QfqN1toGcCy1OAs=; b=YfzDy0ri1fQeCkJKVHZEll9/sM7WaoBBgMzlOty4+QiY/1jSXi+FhpPsHXwh9WQnBW 43afaw1Zgez0cUfjGKkLkFSDnxX1H3EwtEMRWY5xJZB56Ucx3DyHjF21NclMmrhXdulH GEfJnppRzh3f8w69/sLmMt36dvDZ9nCtHn3fNVNcu4gQ55G2hATXI/siUHkD15Cgpbde 9mib1yZSSl/X9sRduahgjhAIqKnMrxH5b7QG6XL/JtU4kqkeCSdAfVbzIhHOW1GNIQCQ 09ZZyOoRbzYlU0FGuxPZQ5fVa3dv275x2j5r91+rQxPgozZqWnu4LkwxdqdNGXckQZQ2 1bFg== X-Forwarded-Encrypted: i=1; AHgh+RpgGlFUc0GyUf+/bmbtk8780TxJrmi+HjWnATdYz7Pufp1OqaGsGuM0K1dNu4QJMU4SQK0opQ5+8ZKE@vger.kernel.org X-Gm-Message-State: AOJu0Yz3OTk0wCtNVzXl5qUfFHelR3JHLnU0VPPmeIXFxo/NT53b+S71 uAxVDN82s7FgVugR7yxaN6wQD8vH73pOKuqbTsxVThcbYptQrFrQp4uD X-Gm-Gg: AfdE7cmy1fmvbatOAV3lkZFCc7nWp22gEBOgtvmZRBG7sERgyp8BGK9nX6tStlhNIrs dUeHZHmCegRoqNEafngC1XZyMzFcIQyFHGOqxWct+d2PKjZdUoiP9LQw9T2Ina1hyKxBsUgedWm r9bKy6IQAS4lMx65wsMXsb1JhizEBWoi1FRqFOslEypBsofPy71Tluirgrfvvtw0XFJYGCtN1m/ zMvJSCUG036dPD01xcReI3xN1PupgoS9FGtrRaIoDeQWJmwuLc9EdztkysY9NJ4oc186LjRaV1B sYWaqlP+6EoFkAyP3dhNoogy7tPttwKcGt2lHLqR/RJkkjYhrbhnb6GZwzrr4KVbLnx1ZSoAxok 1Q5eb7YF6lMBHQSbKb7s+vxvcN/2G+4vo+P7LKZzT86h1r0b/EIyufc5VEvl7yqtBGCB1YgzOng KDL8BCY94uih5eZ35lM4nOv0hhTJuFV4tJtdnjQnYPa8VpBdiBOVVl3Q3EozTlAAwNpZujsw== X-Received: by 2002:a05:651c:150c:b0:399:7aad:889d with SMTP id 38308e7fff4ca-39b24973227mr4052271fa.12.1782821326539; Tue, 30 Jun 2026 05:08:46 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39b1da1d279sm4767611fa.21.2026.06.30.05.08.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 05:08:45 -0700 (PDT) Message-ID: Date: Tue, 30 Jun 2026 15:08:42 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] iio: adc: Fix incorrect reading when datarate changed in single mode To: Andy Shevchenko , Jonathan Cameron Cc: Jakub Szczudlo , linux-iio@vger.kernel.org, andy@kernel.org, antoniu.miclaus@analog.com, conor+dt@kernel.org, devicetree@vger.kernel.org, dlechner@baylibre.com, duje@dujemihanovic.xyz, jishnu.prakash@oss.qualcomm.com, jorge.marques@analog.com, joshua.crofts1@gmail.com, krzk+dt@kernel.org, linusw@kernel.org, linux-kernel@vger.kernel.org, marcelo.schmitt@analog.com, mike.looijmans@topic.nl, nuno.sa@analog.com, robh@kernel.org, sakari.ailus@linux.intel.com, wens@kernel.org References: <20260622221550.374235-1-jakubszczudlo40@gmail.com> <20260622221550.374235-2-jakubszczudlo40@gmail.com> <20260629235118.1abc4067@jic23-huawei> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30/06/2026 14:36, Andy Shevchenko wrote: > On Mon, Jun 29, 2026 at 11:51:18PM +0100, Jonathan Cameron wrote: // snip > >> PM_RUNTIME_ACQUIRE_AUTOSUSPEND(&data->client->dev, pm); >> ret = PM_RUNTIME_ACQUIRE_ERR(&pm); >> if (ret) >> return ret; > >> //note that we 'could' do what some other users of ACQUIRE_ERR() >> //have allowed >> if ((ret = PM_RUNTIME_ACQUIRE_ERR(&pm))) >> return ret; >> >> I'm open to hear if people think we should allow this or not. > > I'm against that. The style is prone for errors and readability issues. I used to use assignments in conditions a lot, long long time ago, when I worked in another company, far far away :) Andy, I promise you, you would get used to it ;) But for now I agree with Andy. As long as assignments in conditions are a No No everywhere else, then doing an odd exception sounds, as exceptions sound, unexpected. So, even if I am not strongly against assignments in conditions overall, I believe that doing it just in one odd case, indeed brings us readability issues. Just my random 5 (or so) cents. -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~