From: barnabas.czeman@mainlining.org
To: Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alejandro Tafalla <atafalla@dnyon.com>,
Luca Weiss <luca@lucaweiss.eu>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: msm8953-xiaomi-daisy: fix cd-gpios
Date: Mon, 01 Sep 2025 20:32:04 +0200 [thread overview]
Message-ID: <e9750a64c761c0e66a813e206696dc7f@mainlining.org> (raw)
In-Reply-To: <q4t2cmg5xtzbga2u3nnxayvb3mom5zaffhyidki2h7pmctk6f4@syj4byco3pwi>
On 2025-09-01 18:01, Bjorn Andersson wrote:
> On Sat, Aug 30, 2025 at 11:59:30PM +0200, Barnabás Czémán wrote:
>> Correct cd-gpios in xiaomi-daisy according to downstream sources
>> it is using GPIO_ACTIVE_HIGH instead of GPIO_ACTIVE_LOW.
>
> Is the problem you're solving that the DT doesn't match downstream, or
> that card detect doesn't work? Does it work after this patch, or is it
> just aligned with downstream?
>
> Regards,
> Bjorn
Both, it was not matching with downstream and card detect was not
working.
It is working with this patch.
>
>>
>> Fixes: 38d779c26395 ("arm64: dts: qcom: msm8953: Add device tree for
>> Xiaomi Mi A2 Lite")
>> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
>> ---
>> arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
>> b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
>> index
>> 336b916729e4721b5ba8f4f7e368d0d838aa54ab..ddd7af616794290aa1f06228a95cfa1d42b006e6
>> 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
>> +++ b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
>> @@ -296,7 +296,7 @@ &sdhc_2 {
>> vmmc-supply = <&pm8953_l11>;
>> vqmmc-supply = <&pm8953_l12>;
>>
>> - cd-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
>> + cd-gpios = <&tlmm 133 GPIO_ACTIVE_HIGH>;
>>
>> pinctrl-names = "default", "sleep";
>> pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>;
>>
>> ---
>> base-commit: 3cace99d63192a7250461b058279a42d91075d0c
>> change-id: 20250830-daisy-sd-fix-011c23468e2a
>>
>> Best regards,
>> --
>> Barnabás Czémán <barnabas.czeman@mainlining.org>
>>
next prev parent reply other threads:[~2025-09-01 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 21:59 [PATCH] arm64: dts: qcom: msm8953-xiaomi-daisy: fix cd-gpios Barnabás Czémán
2025-09-01 16:01 ` Bjorn Andersson
2025-09-01 18:32 ` barnabas.czeman [this message]
2025-09-02 10:20 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9750a64c761c0e66a813e206696dc7f@mainlining.org \
--to=barnabas.czeman@mainlining.org \
--cc=andersson@kernel.org \
--cc=atafalla@dnyon.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaweiss.eu \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).