From: "Nuno Sá" <noname.nuno@gmail.com>
To: Ramona Gradinariu <ramona.gradinariu@analog.com>,
jic23@kernel.org, nuno.sa@analog.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: adis16460: Add 'spi-cs-inactive-delay-ns' property
Date: Mon, 23 Oct 2023 16:27:48 +0200 [thread overview]
Message-ID: <e97ac024cb2654507ed8f7af715f3604efefbdbb.camel@gmail.com> (raw)
In-Reply-To: <20231023140534.704312-4-ramona.gradinariu@analog.com>
On Mon, 2023-10-23 at 17:05 +0300, Ramona Gradinariu wrote:
> The adis16460 device requires a stall time between SPI
> transactions (during which the chip select is inactive),
> with a minimum value equal to 16 microseconds.
> This commit adds 'spi-cs-inactive-delay-ns' property, which should
> indicate the stall time between consecutive SPI transactions.
>
> Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
> ---
> changes in v2:
> - added default value
> - updated description
> - updated commit message
> .../devicetree/bindings/iio/imu/adi,adis16460.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> index 4e43c80e5119..f10469b86ee0 100644
> --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> @@ -25,6 +25,12 @@ properties:
>
> spi-cpol: true
>
> + spi-cs-inactive-delay-ns:
> + minimum: 16000
> + default: 16000
> + description:
> + Indicates the stall time between consecutive SPI transactions.
> +
You should drop the description...
Also, give more time before posting a v2 so others get a chance to review your
patches. It's also better for you since you can gather more change requests.
- Nuno Sá
next prev parent reply other threads:[~2023-10-23 14:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 14:05 [PATCH v2 0/3] iio: imu: adis: Use spi cs inactive delay Ramona Gradinariu
2023-10-23 14:05 ` [PATCH v2 1/3] " Ramona Gradinariu
2023-10-23 14:05 ` [PATCH v2 2/3] dt-bindings: adis16475: Add 'spi-cs-inactive-delay-ns' property Ramona Gradinariu
2023-10-24 13:48 ` Krzysztof Kozlowski
2023-10-23 14:05 ` [PATCH v2 3/3] dt-bindings: adis16460: " Ramona Gradinariu
2023-10-23 14:27 ` Nuno Sá [this message]
2023-10-23 16:06 ` Conor Dooley
2023-10-24 6:53 ` Nuno Sá
2023-10-24 13:47 ` Krzysztof Kozlowski
2023-10-24 15:11 ` Conor Dooley
2023-10-25 7:41 ` Nuno Sá
2023-10-24 13:48 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e97ac024cb2654507ed8f7af715f3604efefbdbb.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=ramona.gradinariu@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).