From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C29E7C433F5 for ; Sat, 2 Apr 2022 15:50:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357457AbiDBPwS (ORCPT ); Sat, 2 Apr 2022 11:52:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357454AbiDBPwR (ORCPT ); Sat, 2 Apr 2022 11:52:17 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6F8BBC3A for ; Sat, 2 Apr 2022 08:50:24 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id bh17so11627923ejb.8 for ; Sat, 02 Apr 2022 08:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=6975MKU9sTkhbv+L8Y2u10WML0H3VB/iCkjt87HVcpo=; b=Uq6rZIzCcG2AALKeKDE+g/YwFx0tGeWA6eaEST4TXreWflRtRMKfMjC2DJ3/fkcY1n sPsVpDvCjUlKz7TFK4la4f75DBvo4iBuv3dFuB68E9HzMGUV0rVueljK6I81uWdV7qPk btZti3rQacMT3uQsMlYyBzJIBgsADoFB4raO9ib0WhiIuahEr55lRnq9sbGP9kfFRtZk P0n3DVTR2h8E5ZOuJMukHJzCM63tKkID6ddUVcwbcWMl8SoGAmyoaHjsiF+Vns5ASJfX 4w9nhuQPUkgGYgUDVBtTR/pP/E8v6Ugc6nBFH4Zw1HFoGO83LdjXRyh+WVHZ7UyNz4+o vYRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=6975MKU9sTkhbv+L8Y2u10WML0H3VB/iCkjt87HVcpo=; b=Kup3HBZ/viEUx8jMcWlwboXm82N2/QQIpNDawx6WiFbVXewRUsT0HgyFXqDcqh7x5K 9S6HnvzlnhAm97QDjKB/a/FyEYLco9uUnfDIFRUBS9XnqejH13a76xAsoJM7E0a+djov aiRmQSxvJZwlr3IupbmImCQx20o6biZDj9jle+p54S2sDJQF7Ae7VFHIoHgRpv/gBoDX d1s+NUITc+g4H+W94eHgTRR8kI1GQ2ouoK4eivSGbAC7MXRVaou8nxBtBscyiHLTg+B9 WIlTkWj7DVS8MIe4Yzz3OCKUyx9CqWRUuh9NORi4UQQXRIw8AZ3J7eg6nLuk6XOwnM+W GFBg== X-Gm-Message-State: AOAM531Pmzxsskta9XF3moN3SHWRCxOhMqs7uNJTQMxArm0xnGAMOQXP mB7ClpjxezRl7FVwTgT+d/cHlA== X-Google-Smtp-Source: ABdhPJx8QAoYvVoNwXcpqzI0cVtIj6iw6TjQJw6cn1Dy2UVjJulY+JTWr3wZAJBGvvRkcqAd9ZS9TQ== X-Received: by 2002:a17:906:32cf:b0:6d5:83bc:e962 with SMTP id k15-20020a17090632cf00b006d583bce962mr4390724ejk.108.1648914623488; Sat, 02 Apr 2022 08:50:23 -0700 (PDT) Received: from [192.168.0.33] (cpc78119-cwma10-2-0-cust590.7-3.cable.virginm.net. [81.96.50.79]) by smtp.gmail.com with ESMTPSA id s3-20020a1709067b8300b006e4a6dee49dsm2241404ejo.184.2022.04.02.08.50.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Apr 2022 08:50:23 -0700 (PDT) Message-ID: Date: Sat, 2 Apr 2022 16:50:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 6/6] dt-bindings: power: supply: qcom,smb2: add bindings for smb2 driver Content-Language: en-US To: Krzysztof Kozlowski , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: Amit Pundir , Sumit Semwal References: <20220401202643.877609-1-caleb.connolly@linaro.org> <20220401202643.877609-7-caleb.connolly@linaro.org> From: Caleb Connolly In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/04/2022 15:22, Krzysztof Kozlowski wrote: > On 01/04/2022 22:26, Caleb Connolly wrote: >> Add devicetree bindings for the Qualcomm PMI8998/PM660 SMB2 charger >> drivers. >> >> Signed-off-by: Caleb Connolly >> --- >> .../bindings/power/supply/qcom,smb2.yaml | 68 +++++++++++++++++++ >> 1 file changed, 68 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/supply/qcom,smb2.yaml >> >> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,smb2.yaml b/Documentation/devicetree/bindings/power/supply/qcom,smb2.yaml >> new file mode 100644 >> index 000000000000..1bea1fef78b8 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/supply/qcom,smb2.yaml >> @@ -0,0 +1,68 @@ >> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/power/supply/qcom,smb2.yaml# > > Hi, Hi Krzysztof, > > Are you sure "smb2" is a real Qualcomm versioning? IOW, is there going > to be smb3 in the future? If not, better to just name the file according > to model, so like compatible and like other existing schemas from Qualcomm. Qualcomm versioning is a complete mystery to me 😅, downstream kernels have a "pmi8998_charger" which uses the qpnp-smb2 driver, there is also an "smb5" driver presumably for newer PMICs. This driver is used for the charger block found on the PMI8998 and PM660 at least, a name like "pmi8998_charger" might be more suitable. > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm PMI8998/PM660 Switch-Mode Battery Charger "2" >> + >> +maintainers: >> + - Caleb Connolly >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,pmi8998-smb2 >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + items: >> + - description: usb plugin > > Just maxItems:1 (description is obvious and matches names). > >> + >> + interrupt-names: >> + items: >> + - const: usb-plugin >> + >> + io-channels: >> + items: >> + - description: USB in current in uA >> + - description: USB in voltage in uV >> + >> + io-channel-names: >> + items: >> + - const: usbin_i >> + - const: usbin_v >> + > > What about monitored-battery? How do you configure the battery > characteristics? > >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - interrupt-names >> + - io-channels >> + - io-channel-names >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + pmic { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + #interrupt-cells = <4>; >> + >> + smb2@1000 { > > Generic node name please, so "charger". > > > > Best regards, > Krzysztof -- Kind Regards, Caleb (they/them)