From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9460BC433E6 for ; Fri, 1 Jan 2021 11:28:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6749022203 for ; Fri, 1 Jan 2021 11:28:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727052AbhAAL2c (ORCPT ); Fri, 1 Jan 2021 06:28:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726134AbhAAL21 (ORCPT ); Fri, 1 Jan 2021 06:28:27 -0500 Received: from yawp.biot.com (yawp.biot.com [IPv6:2a01:4f8:10a:8e::fce2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 037C1C061575 for ; Fri, 1 Jan 2021 03:27:46 -0800 (PST) Received: from debian-spamd by yawp.biot.com with sa-checked (Exim 4.93) (envelope-from ) id 1kvIav-00B5K6-B2 for devicetree@vger.kernel.org; Fri, 01 Jan 2021 12:27:45 +0100 Received: from [2a02:578:460c:1:ae1f:6bff:fed1:9ca8] by yawp.biot.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1kvIas-00B5Js-4P; Fri, 01 Jan 2021 12:27:42 +0100 Subject: Re: [PATCH RESEND v2 2/2] Add support for Realtek RTL838x/RTL839x SoC SPI controllers To: Lukas Wunner Cc: Mark Brown , Rob Herring , Birger Koblitz , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201229231904.2558916-1-bert@biot.com> <20201229231904.2558916-2-bert@biot.com> <20201231142319.GA28104@wunner.de> From: Bert Vermeulen Message-ID: Date: Fri, 1 Jan 2021 12:27:41 +0100 MIME-Version: 1.0 In-Reply-To: <20201231142319.GA28104@wunner.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/31/20 3:23 PM, Lukas Wunner wrote: > On Wed, Dec 30, 2020 at 12:19:04AM +0100, Bert Vermeulen wrote: >> +static inline void wait_ready(struct rtspi *rtspi) >> +{ >> + while (!(readl(REG(RTL8380_SPI_SFCSR)) & RTL8380_SPI_SFCSR_RDY)) >> + ; >> +} > > I'd suggest calling cpu_relax() in the loop's body. > > >> + err = devm_spi_register_controller(&pdev->dev, ctrl); > > Since you're invoking devm_spi_register_controller() on probe, > the controller must not be unregistered explicitly on remove. > So the ->remove hook can be dropped altogether: > >> +static int realtek_spi_remove(struct platform_device *pdev) >> +{ >> + struct spi_controller *ctrl = platform_get_drvdata(pdev); >> + >> + spi_unregister_controller(ctrl); >> + >> + return 0; >> +} > [...] >> + .remove = realtek_spi_remove, > > The ->probe hook otherwise LGTM. Thanks Lukas, will fix those issues. -- Bert Vermeulen bert@biot.com