From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84879C433EF for ; Mon, 18 Apr 2022 16:08:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241266AbiDRQKl (ORCPT ); Mon, 18 Apr 2022 12:10:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237698AbiDRQKk (ORCPT ); Mon, 18 Apr 2022 12:10:40 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22509252AB for ; Mon, 18 Apr 2022 09:08:01 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id bv19so27666663ejb.6 for ; Mon, 18 Apr 2022 09:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=oqr9RmHje//A41kB9mudDF/N2i4dpqWGpoMvclyRrys=; b=D5mV/MiOY9iguNT01zT/1CcP4sM7iRKWyCf2F2T6IBarNp+wYt+DQAM96Vu/h2iChq b5SIAa3wllGjosZiZZyuURv2J4h+4gas9xUfIYd5MKDVQIwERkD2FDUqpxvphYpxw8KI LAebOIq/dlQlsYbhamvW4iWbj7B6wK9ryJPxZpcenzzTgSP0cXTSK3+6MMP6pS7WVui1 kNucxpmYEQxpYgaTlP8Wv1pCmKKLi5PMM2f6IXTkgSE/ZcV/KTmk0Bkois+wKSjDhFgg hqI2rsuNc+kGs/WSK3AfyIlq4B7gWloaR0xhW02uKUbtIOmfgpASJQtnQTDhT+r05Wug ygbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=oqr9RmHje//A41kB9mudDF/N2i4dpqWGpoMvclyRrys=; b=azFmHQZUCnYsqiGFNH/yfBKBVV8RqjQ/UwFjAVO01eDJatY+pb+Bbwy3VJ+JV49HU4 u53iAEreYFeXLnr7J3agRJkd5j8KnpN5aW4bQnk+hpBJoOIfvbNiCNIDRnNeimfvD9u5 yi9KIZFXcCjoReq/4vrXAvwUnFCcu9GJ1uWRfq3K2HtA1VVsIduYylr7BMx7jkQx3pUw vfdrJv9MIRvaU6zBxxF3G0kc8bX99iZ4sRPIoUus/s/vdhxG5AHOtW9g56FKuERoUta4 +uTUQ4eQ7tQ2YXGCE4J0K55jZBkjNfR49RT5RpgoawzWX5cKv7apoJ/NMhno/Ww95Qbx 6i7w== X-Gm-Message-State: AOAM530qCOcAXRcbzdgLW+EXGKqr44Mzmw/44tZYWaKKUCNCzktiAd5L sdv0Kl1Lw6LW2Wn1VJg5ohljvw== X-Google-Smtp-Source: ABdhPJyiAuU3xS4tpdFyuPzk78iTBtq/P/NHk2glXXCVSH23y2emo5i2nLoN6zJZsh/SVRzf43dXow== X-Received: by 2002:a17:907:3d8b:b0:6ef:ac6c:54de with SMTP id he11-20020a1709073d8b00b006efac6c54demr5086333ejc.292.1650298079665; Mon, 18 Apr 2022 09:07:59 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id gh9-20020a170906e08900b006e8662287edsm4642266ejb.54.2022.04.18.09.07.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Apr 2022 09:07:59 -0700 (PDT) Message-ID: Date: Mon, 18 Apr 2022 18:07:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH RESEND v2 8/9] arm64: dts: qcom: msm8996: Add MSM8996 Pro support Content-Language: en-US To: Yassine Oudjana , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Ilia Lin , Viresh Kumar , Nishanth Menon , "Rafael J. Wysocki" Cc: Konrad Dybcio , Dmitry Baryshkov , Loic Poulain , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, Yassine Oudjana References: <20220416025637.83484-1-y.oudjana@protonmail.com> <20220416025637.83484-9-y.oudjana@protonmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220416025637.83484-9-y.oudjana@protonmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/04/2022 04:56, Yassine Oudjana wrote: > Add a new DTSI for MSM8996 Pro (MSM8996SG) with msm-id and CPU/GPU OPPs. > CBF OPPs and CPR parameters will be added to it as well once support for > CBF scaling and CPR is introduced. > Thank you for your patch. There is something to discuss/improve. > + > +#include "msm8996.dtsi" > + > +/* > + * MSM8996 Pro (also known as MSM8996SG) is a revision of MSM8996 with > + * different CPU, CBF and GPU frequencies as well as CPR parameters. > + */ > +/delete-node/ &cluster0_opp; > +/delete-node/ &cluster1_opp; > + > +/ { > + qcom,msm-id = <305 0x10000>; > + > + cluster0_opp: opp_table0 { No underscores in node names. If this comes from original file, should be fixed in separate commit. Best regards, Krzysztof