From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5700EC433B4 for ; Fri, 14 May 2021 15:54:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3304E613B9 for ; Fri, 14 May 2021 15:54:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234735AbhENPzJ (ORCPT ); Fri, 14 May 2021 11:55:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233914AbhENPzJ (ORCPT ); Fri, 14 May 2021 11:55:09 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B8E2C061574; Fri, 14 May 2021 08:53:56 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id di13so35230301edb.2; Fri, 14 May 2021 08:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nJjqUh+eedhnbrR//6OaBv5/ZsdN4XZOU4mhcsRuoyg=; b=f5pKrku0e6EM6tOZFoRr8i5ryGCMprW/ArJmi1G1tF1P3P7TB/vGZt6eUZBeYX1OGP 4onTfNm+56vE+G3yKyyomtIVL/0TNH+IF3DEnOwqDIJ0EUpf+yDjVYVMnXLC0j8N9vlB 0LablOmpCVmnbJPG82EWGdqqbeH62hmqq9UT7wSqc5XZut/4D2/BTlqC4eYe0rLabD2v OFQOhntIB1I9aLkzF8xewSXdLpLPngab91x9DAK63/E85M4PiX9uswAdiBkxJTD159me eg2D15l8+0Xts9zanmFZyE/89732PpRS0TuLEsgtcyKUJAca/Yq+j0vuZGPanW1zZSNI 9gOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nJjqUh+eedhnbrR//6OaBv5/ZsdN4XZOU4mhcsRuoyg=; b=iBxSHTFSUkdblwtojqoFYQHFQyg29m6VLtqRfilNWXdi11BjuqAqEYhAcBSRT/4WZe K2Z5oqYRzDeOEcW5DT9sYYVZDf+/msQtRijZ3GAcxPcJaMOsJqqIu+tqDKhOEFWS/q54 zsA0MOOpNLYLOJYgAsROZsmecTHHPGWv7TVXTvUZWzRfzzc6aypxNcdpv4RTzB2ehVkk /yawg4bkKkvLWxApl5CMp9B5m0Jqd2LF9UHJQqlkBb0aUUjNJJPJ+yrHGIdcJaC0UVwn I/qebaDkvS+YbR7YBtQ3Xn+jE61FQh92hPesU4iLPLCdVdhqFTyVXma+K2IHYIIMgLXY yQ+g== X-Gm-Message-State: AOAM533mMctgnnb+S3nr/kskna/Rgmc1stPyZuDpir9g+HMnfE4Po0gg QBYOXu3fgw6b4NF2NN+IwiTGZiqkCFU= X-Google-Smtp-Source: ABdhPJxiEhDApEu75kJdXXESrqi6t2oBygLR+znc2KM99z8D4A006a1c0919pGQoeo6o0GXD+663Ew== X-Received: by 2002:a05:6402:2753:: with SMTP id z19mr56769103edd.158.1621007635210; Fri, 14 May 2021 08:53:55 -0700 (PDT) Received: from [192.168.2.2] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id ks10sm3911610ejb.41.2021.05.14.08.53.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 08:53:54 -0700 (PDT) Subject: Re: [PATCH v2 4/5] dt-bindings: soc: rockchip: grf: add compatible for RK3308 USB grf To: Tobias Schramm , linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org Cc: Rob Herring , Heiko Stuebner , Kishon Vijay Abraham I , Vinod Koul , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210514150044.2099298-1-t.schramm@manjaro.org> <20210514150044.2099298-5-t.schramm@manjaro.org> From: Johan Jonker Message-ID: Date: Fri, 14 May 2021 17:53:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210514150044.2099298-5-t.schramm@manjaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Tobias, The grf serie is currently still under review. So things can change. Must add a change log below a "---" in the commit message for rob+dt. Maybe add a patch that fixes the reg size of "rockchip,rk3308-grf" as well? Johan On 5/14/21 5:00 PM, Tobias Schramm wrote: > The RK3308 has a USB GRF. > This patch adds a compatible string for it. > > Signed-off-by: Tobias Schramm > --- > Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > index 84bdaf88d5a6..df77bd2e6752 100644 > --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > @@ -30,6 +30,7 @@ properties: > - rockchip,rk3288-grf > - rockchip,rk3308-core-grf > - rockchip,rk3308-detect-grf > + - rockchip,rk3308-usb2phy-grf > - rockchip,rk3308-grf Sort alphabetically. > - rockchip,rk3328-grf > - rockchip,rk3328-usb2phy-grf > Also allow usb2-phy as sub nodes name. + - if: + properties: + compatible: + contains: + enum: + - rockchip,px30-usb2phy-grf + - rockchip,rk3228-grf - rockchip,rk3308-usb2phy-grf + - rockchip,rk3328-usb2phy-grf + - rockchip,rk3399-grf + - rockchip,rv1108-grf + + then: + required: + - "#address-cells" + - "#size-cells" + + patternProperties: + "usb2-phy@[0-9a-f]+$": + type: object + + $ref: "/schemas/phy/phy-rockchip-inno-usb2.yaml#" + + unevaluatedProperties: false === Heiko's sort rules: compatible reg interrupts [alphabetical] status [if needed] === Sort #phy-cells below interrupt-names. + #phy-cells = <0>; + interrupts = ; + interrupt-names = "linestate";