From: Randy Dunlap <rdunlap@infradead.org>
To: Gabriel Somlo <gsomlo@gmail.com>, linux-kernel@vger.kernel.org
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
kgugala@antmicro.com, mholenko@antmicro.com,
krakoczy@antmicro.com, mdudek@internships.antmicro.com,
paulus@ozlabs.org, joel@jms.id.au, shorne@gmail.com,
geert@linux-m68k.org, david.abdurachmanov@sifive.com,
florent@enjoy-digital.fr
Subject: Re: [PATCH v2 3/3] mmc: Add driver for LiteX's LiteSDCard interface
Date: Sat, 4 Dec 2021 12:57:32 -0800 [thread overview]
Message-ID: <e99ad542-14f6-2a06-a83e-c5f4e945303c@infradead.org> (raw)
In-Reply-To: <20211204204121.2367127-4-gsomlo@gmail.com>
Hi Gabriel--
On 12/4/21 12:41, Gabriel Somlo wrote:
> +MODULE_DESCRIPTION("LiteX SDCard driver");
> +MODULE_AUTHOR("Antmicro <www.antmicro.com>");
Admittedly it's not documented, but we would prefer to have some contact info
in MODULE_AUTHOR(), like an email address or a person's name.
<linux/module.h> says:
/*
* Author(s), use "Name <email>" or just "Name", for multiple
* authors use multiple MODULE_AUTHOR() statements/lines.
*/
#define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
> +MODULE_LICENSE("GPL v2");
Also, it's up to the MMC maintainer (Ulf), but the function signature
style that is used in this driver is not the preferred style.
E.g.:
+static int
+litex_set_bus_width(struct litex_mmc_host *host)
+{
should be
+static int litex_set_bus_width(struct litex_mmc_host *host)
+{
thanks.
--
~Randy
next prev parent reply other threads:[~2021-12-04 20:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 20:41 [PATCH v2 0/3] mmc: Add LiteSDCard mmc driver Gabriel Somlo
2021-12-04 20:41 ` [PATCH v2 1/3] MAINTAINERS: co-maintain LiteX platform Gabriel Somlo
2021-12-06 23:59 ` Joel Stanley
2021-12-07 22:11 ` Gabriel L. Somlo
2021-12-04 20:41 ` [PATCH v2 2/3] dt-bindings: mmc: Add bindings for LiteSDCard Gabriel Somlo
2021-12-06 9:39 ` Geert Uytterhoeven
2021-12-06 10:18 ` Geert Uytterhoeven
2021-12-06 15:36 ` Gabriel L. Somlo
2021-12-06 15:44 ` Geert Uytterhoeven
2021-12-04 20:41 ` [PATCH v2 3/3] mmc: Add driver for LiteX's LiteSDCard interface Gabriel Somlo
2021-12-04 20:57 ` Randy Dunlap [this message]
2021-12-05 1:37 ` Gabriel L. Somlo
2021-12-06 10:07 ` Geert Uytterhoeven
2021-12-06 18:40 ` Gabriel L. Somlo
2021-12-08 20:14 ` Gabriel L. Somlo
2021-12-09 8:31 ` Geert Uytterhoeven
2021-12-09 20:58 ` Gabriel L. Somlo
2021-12-10 8:04 ` Geert Uytterhoeven
2021-12-06 12:24 ` Geert Uytterhoeven
2021-12-07 14:10 ` Gabriel L. Somlo
2021-12-07 14:16 ` Geert Uytterhoeven
2021-12-07 21:30 ` Gabriel L. Somlo
2021-12-08 9:35 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e99ad542-14f6-2a06-a83e-c5f4e945303c@infradead.org \
--to=rdunlap@infradead.org \
--cc=david.abdurachmanov@sifive.com \
--cc=devicetree@vger.kernel.org \
--cc=florent@enjoy-digital.fr \
--cc=geert@linux-m68k.org \
--cc=gsomlo@gmail.com \
--cc=joel@jms.id.au \
--cc=kgugala@antmicro.com \
--cc=krakoczy@antmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mdudek@internships.antmicro.com \
--cc=mholenko@antmicro.com \
--cc=paulus@ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=shorne@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).