From: Krzysztof Kozlowski <krzk@kernel.org>
To: arm@kernel.org, soc@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>
Cc: devicetree@vger.kernel.org, Will Deacon <will@kernel.org>,
Daniele Alessandrelli <daniele.alessandrelli@intel.com>,
"Paul J. Murphy" <paul.j.murphy@intel.com>,
linux-kernel@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 03/11] arm64: dts: intel: socfpga: override clocks by label
Date: Wed, 3 Mar 2021 19:15:31 +0100 [thread overview]
Message-ID: <e9a88bad-fb08-f028-bfe1-6d008dbfe1de@kernel.org> (raw)
In-Reply-To: <20210210171823.333802-3-krzk@kernel.org>
On 10/02/2021 18:18, Krzysztof Kozlowski wrote:
> Using full paths to extend or override a device tree node is error
> prone. If there was a typo error, a new node will be created instead of
> extending the existing node. This will lead to run-time errors that
> could be hard to detect.
>
> A mistyped label on the other hand, will cause a dtc compile error
> (during build time).
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts | 12 ++++--------
> .../boot/dts/intel/socfpga_agilex_socdk_nand.dts | 12 ++++--------
> arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts | 12 ++++--------
> 3 files changed, 12 insertions(+), 24 deletions(-)
Hi Arnd and Olof,
There was no response from Intel SoCFPGA maintainers for the DTS
patches, so maybe you could take it directly? I can provide you pull
request with these, if that's preferred. They apply cleanly.
You could also take the dt-bindings 2/11 or it could go via Rob.
About the defconfig patch (1/11) I will work on it more and resend it
with your comments (you gave me review).
Best regards,
Krzysztof
prev parent reply other threads:[~2021-03-03 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210210171823.333802-1-krzk@kernel.org>
[not found] ` <20210210171823.333802-2-krzk@kernel.org>
2021-02-11 15:03 ` [PATCH 02/11] dt-bindings: arm: intel,keembay: limit the dtschema to root node Alessandrelli, Daniele
[not found] ` <20210210171823.333802-3-krzk@kernel.org>
2021-03-03 18:15 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9a88bad-fb08-f028-bfe1-6d008dbfe1de@kernel.org \
--to=krzk@kernel.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=daniele.alessandrelli@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=paul.j.murphy@intel.com \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).