Re: [PATCH 02/11] dt-bindings: arm: intel,keembay: limit the dtschema to root node

Re: [PATCH 02/11] dt-bindings: arm: intel,keembay: limit the dtschema to root node

[Alessandrelli, Daniele]

Hi Krzysztof,

Thanks for the fix.


On Wed, 2021-02-10 at 18:18 +0100, Krzysztof Kozlowski wrote:
> The check for the board compatible should be limited only to the root
> node.  Any other nodes with such compatible are not part of this schema
> and should not match.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/arm/intel,keembay.yaml | 2 ++
>  1 file changed, 2 insertions(+)

Acked-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com>

> 
> diff --git a/Documentation/devicetree/bindings/arm/intel,keembay.yaml b/Documentation/devicetree/bindings/arm/intel,keembay.yaml
> index 69cd30872928..107e686ab207 100644
> --- a/Documentation/devicetree/bindings/arm/intel,keembay.yaml
> +++ b/Documentation/devicetree/bindings/arm/intel,keembay.yaml
> @@ -11,6 +11,8 @@ maintainers:
>    - Daniele Alessandrelli <daniele.alessandrelli@intel.com>
>  
>  properties:
> +  $nodename:
> +    const: '/'
>    compatible:
>      items:
>        - enum:

Re: [PATCH 03/11] arm64: dts: intel: socfpga: override clocks by label

[Krzysztof Kozlowski]

On 10/02/2021 18:18, Krzysztof Kozlowski wrote:
> Using full paths to extend or override a device tree node is error
> prone.  If there was a typo error, a new node will be created instead of
> extending the existing node.  This will lead to run-time errors that
> could be hard to detect.
> 
> A mistyped label on the other hand, will cause a dtc compile error
> (during build time).
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>   arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts   | 12 ++++--------
>   .../boot/dts/intel/socfpga_agilex_socdk_nand.dts     | 12 ++++--------
>   arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts      | 12 ++++--------
>   3 files changed, 12 insertions(+), 24 deletions(-)

Hi Arnd and Olof,

There was no response from Intel SoCFPGA maintainers for the DTS 
patches, so maybe you could take it directly? I can provide you pull 
request with these, if that's preferred. They apply cleanly.

You could also take the dt-bindings 2/11 or it could go via Rob.

About the defconfig patch (1/11) I will work on it more and resend it 
with your comments (you gave me review).

Best regards,
Krzysztof