Re: [PATCH v4 3/6] iio: adc: ad7173: refactor ain and vref selection

["Nuno Sá" <noname.nuno@gmail.com>]

On Sat, 2024-06-01 at 19:49 +0100, Jonathan Cameron wrote:
> On Fri, 31 May 2024 22:42:29 +0300
> Dumitru Ceclan via B4 Relay <devnull+dumitru.ceclan.analog.com@kernel.org> wrote:
> 
> > From: Dumitru Ceclan <dumitru.ceclan@analog.com>
> > 
> > Move validation of analog inputs and reference voltage selection to
> > separate functions to reduce the size of the channel config parsing
> > function and improve readability.
> > Add defines for the number of analog inputs in a channel.
> > 
> > Reviewed-by: David Lechner <dlechner@baylibre.com>
> > Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
> > ---
> >  drivers/iio/adc/ad7173.c | 71 ++++++++++++++++++++++++++++++++++--------------
> >  1 file changed, 50 insertions(+), 21 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> > index 6e249628bc64..a20831d99aa5 100644
> > --- a/drivers/iio/adc/ad7173.c
> > +++ b/drivers/iio/adc/ad7173.c
> > @@ -60,6 +60,7 @@
> >  #define AD7173_CH_SETUP_AINPOS_MASK	GENMASK(9, 5)
> >  #define AD7173_CH_SETUP_AINNEG_MASK	GENMASK(4, 0)
> >  
> > +#define AD7173_NO_AINS_PER_CHANNEL	2
> >  #define AD7173_CH_ADDRESS(pos, neg) \
> >  	(FIELD_PREP(AD7173_CH_SETUP_AINPOS_MASK, pos) | \
> >  	 FIELD_PREP(AD7173_CH_SETUP_AINNEG_MASK, neg))
> > @@ -623,6 +624,7 @@ static int ad7173_setup(struct iio_dev *indio_dev)
> >  static unsigned int ad7173_get_ref_voltage_milli(struct ad7173_state *st,
> >  						 u8 reference_select)
> >  {
> > +	struct device *dev = &st->sd.spi->dev;
> >  	int vref;
> >  
> >  	switch (reference_select) {
> > @@ -646,9 +648,11 @@ static unsigned int ad7173_get_ref_voltage_milli(struct
> > ad7173_state *st,
> >  		return -EINVAL;
> >  	}
> >  
> > -	if (vref < 0)
> > +	if (vref < 0) {
> > +		dev_err(dev, "Cannot use reference %u. Error:%d\n",
> > +			reference_select, vref);
> >  		return vref;
> > -
> > +	}
> >  	return vref / (MICRO / MILLI);
> >  }
> >  
> > @@ -905,13 +909,50 @@ static int ad7173_register_clk_provider(struct iio_dev
> > *indio_dev)
> >  					   &st->int_clk_hw);
> >  }
> >  
> > +static int ad7173_validate_voltage_ain_inputs(struct ad7173_state *st,
> > +					      const unsigned int
> > ain[AD7173_NO_AINS_PER_CHANNEL])
> I was late to the game in replying to previous thread.
> 
> This is neater without the loop and with 2 parameters.  Anyhow see reply to v3.
> 

Yeps, even more given that we're passing/copying the complete array which always
fells awkward to me :)

- Nuno Sá