From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>,
marcel@holtmann.org, luiz.dentz@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org
Cc: linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
amitkumar.karwar@nxp.com, rohit.fule@nxp.com, sherry.sun@nxp.com,
ziniu.wang_1@nxp.com, haibo.chen@nxp.com, LnxRevLi@nxp.com
Subject: Re: [PATCH v2 1/2] dt-bindings: net: bluetooth: btnxpuart: Add firmware-name property
Date: Mon, 8 Apr 2024 15:29:32 +0200 [thread overview]
Message-ID: <e9cef5dd-c4fc-43c0-839b-d311d87a28ca@linaro.org> (raw)
In-Reply-To: <20240408132241.750792-2-neeraj.sanjaykale@nxp.com>
On 08/04/2024 15:22, Neeraj Sanjay Kale wrote:
> This adds a new optional device tree property called firware-name.
>
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
BTW, there is no such device as btnxpuart. Bindings are for hardware.
With corrected subject:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> v2: Add maxItems, simplify description, remove "nxp/". (Krzysztof)
> ---
> .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> index f01a3988538c..6774cc4d6a9e 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> @@ -31,6 +31,11 @@ properties:
> This property depends on the module vendor's
> configuration.
>
> + firmware-name:
> + maxItems: 1
> + description:
> + Specify firmware file name.
Drop description, redundant. You did not say anything different than
property is saying already.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-08 13:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 13:22 [PATCH v2 0/2] Bluetooth: btnxpuart: Update firmware names Neeraj Sanjay Kale
2024-04-08 13:22 ` [PATCH v2 1/2] dt-bindings: net: bluetooth: btnxpuart: Add firmware-name property Neeraj Sanjay Kale
2024-04-08 13:29 ` Krzysztof Kozlowski [this message]
2024-04-10 8:13 ` Neeraj Sanjay Kale
2024-04-08 13:22 ` [PATCH v2 2/2] Bluetooth: btnxpuart: Update firmware names Neeraj Sanjay Kale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9cef5dd-c4fc-43c0-839b-d311d87a28ca@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=LnxRevLi@nxp.com \
--cc=amitkumar.karwar@nxp.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=haibo.chen@nxp.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=neeraj.sanjaykale@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=rohit.fule@nxp.com \
--cc=sherry.sun@nxp.com \
--cc=ziniu.wang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox