From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [121.127.44.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93FFB547048 for ; Sat, 19 Sep 2026 09:41:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=121.127.44.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789810906; cv=none; b=AP8S941fIZDD4e8RWpT2O6UaSRrAcM/zfj8sdnApU480ubwfxTXoz9r4tDY66YHCKWvKqkq/w96jQTr71F7omy273ilawm/AvcvJKertw22UI5UjA/5mXnf0jDdHvG/ljJ7zDFeSIRhVhS/2ju1B5Xg5xwauHux9rac3FV0cIcg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789810906; c=relaxed/simple; bh=wIp7G28DL4IC3oZG+axVcFKF6+HCBhhpjFhZVeSPKTA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VC3mLBsI2BucIFSZuBTLx3NobjoES0GthSh7LcdO6kprDSb1yBGqVCPUHJF/WVwBN8QKfrBAhoIfENU+b7gq6BmPx07Kr40+aF1CCl/gX3Q2IXDjZ5XWvhLI4wbWPLhGXQ13bpkmN5S9u0ILykw1IO40vyomrrv2JgHba9d0PEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kwiboo.se; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b=GumwsOZi; arc=none smtp.client-ip=121.127.44.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kwiboo.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b="GumwsOZi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: Cc: To: Subject: MIME-Version: Date: Message-ID; q=dns/txt; s=fe-e1b5cab7be; t=1789810902; bh=DQzV+C6vNOMiJSlMbb5WYGSJ6UwSGQKE9h7pya059wo=; b=GumwsOZiuTB6g8bZDPb2iNT/L0K7a8/H2z8XW9dXRE7wOnJ9XcWcRNBjdwHs5CjUC+je5WCRt Dnyf3H/1uQ9Zq682Ca6a+ZmJacdIKVXK7tnrKSeB5Zmlzz9j0SiGMZQnG14cSmC3w9LBJ/hJ/qa xEkGBkaXxpCYkSBo6EbMknD9LRb0WEJP4PTf+5gTVbfyLlM8MD/pH2lheZDqdATVe446XxIbzpk +IgRRdq5A0Jy/tddDb17CTFRgRO/5Tk0JZxBLn0w7VPAdMbRvUEU8wGUXLrLxgWD49Xua35NspH 8olKhvBWi/li3Xu5ykNV1aB42j6erY1SH79vMI2xm+DA== X-Forward-Email-ID: 6aae587fa917c0722b38310e X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 121.127.44.73 X-Forward-Email-Version: 2.14.2 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Message-ID: Date: Sat, 19 Sep 2026 11:40:11 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/3] arm64: dts: rockchip: Add devicetree for the FriendlyElec NanoPi R28S To: HystericalDragons@proton.me, Heiko Stuebner Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Chukun Pan , jensen , Andrey Korshunov , Diederik de Haas References: <20260914-r28s-upstream-v6-0-ea9edd75c126@proton.me> <20260914-r28s-upstream-v6-3-ea9edd75c126@proton.me> Content-Language: en-US From: Jonas Karlman In-Reply-To: <20260914-r28s-upstream-v6-3-ea9edd75c126@proton.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, On 9/14/2026 3:35 PM, 安容 via B4 Relay wrote: > From: 安容 > > The NanoPi R28S is a dual gigabit Ethernet router board based on the > Rockchip RK3528 SoC, designed and developed by FriendlyElec. It shares > most of its design with the NanoPi Zero2, so it builds on the common > rk3528-nanopi.dtsi. > > Specification: > - Rockchip RK3528 > - 1GB RAM > - eMMC socket (optional) > - MicroSD slot > - 1x 1000Base-T (GMAC1, Realtek RTL8211F) > - 1x 1000Base-T (PCIe, Realtek RTL8111H) > - AICSemi AIC8800D80 SDIO WiFi > - 3x LEDs (SYS, LAN, WAN) > - 1x USB 2.0 Type-C, peripheral only, shared with the 5V power input > - User and MaskROM buttons > - Haoyu HYM8563 RTC > - 1x USB Type-C debug UART (onboard WCH CH340E) > > Assisted-by: LLM > Signed-off-by: 安容 > --- > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../arm64/boot/dts/rockchip/rk3528-nanopi-r28s.dts | 146 +++++++++++++++++++++ > 2 files changed, 147 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index b677914cd3..51a9889088 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -94,6 +94,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-vicharak-vaaman.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3528-armsom-sige1.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3528-hinlink-h28k.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3528-nanopi-r28s.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3528-nanopi-zero2.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3528-radxa-e20c.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3528-rock-2a.dtb > diff --git a/arch/arm64/boot/dts/rockchip/rk3528-nanopi-r28s.dts b/arch/arm64/boot/dts/rockchip/rk3528-nanopi-r28s.dts > new file mode 100644 > index 0000000000..a453a990b3 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3528-nanopi-r28s.dts > @@ -0,0 +1,146 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2022 Rockchip Electronics Co., Ltd. > + * Copyright (c) 2026 FriendlyElec Computer Tech. Co., Ltd. > + * Copyright (c) 2026 安容 > + */ > + > +/dts-v1/; > + > +#include This is already included from rk3528-nanopi.dtsi, so this can be dropped or we should possible also include input and gpio symbols used in this board DT. > +#include "rk3528-nanopi.dtsi" > + > +/ { > + model = "FriendlyElec NanoPi R28S"; > + compatible = "friendlyarm,nanopi-r28s", "rockchip,rk3528"; > + > + aliases { > + mmc2 = &sdio0; > + serial2 = &uart2; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio4_b2_usr_btn>; > + > + button-user { > + debounce-interval = <50>; > + gpios = <&gpio4 RK_PB2 GPIO_ACTIVE_LOW>; > + label = "USER"; > + linux,code = ; > + wakeup-source; > + }; > + }; > + > + sdio_pwrseq: sdio-pwrseq { > + compatible = "mmc-pwrseq-simple"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pwr_wf>; > + post-power-on-delay-ms = <100>; > + reset-gpios = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>; > + }; > +}; > + > +&combphy { > + status = "okay"; > +}; > + > +&leds { This should also include a 'pinctrl-names = "default"', as we are re-defining pinctrl-0 here. > + pinctrl-0 = <&led1>, <&led2>, <&led_sys>; > + > + led-1 { > + color = ; > + default-state = "off"; > + function = LED_FUNCTION_WAN; > + gpios = <&gpio4 RK_PB1 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "netdev"; > + }; > + > + led-2 { > + color = ; > + default-state = "off"; > + function = LED_FUNCTION_LAN; > + gpios = <&gpio4 RK_PB3 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "netdev"; > + }; > +}; > + > +&pcie { > + pinctrl-names = "default"; > + pinctrl-0 = <&pcie_eth_perstb>; > + reset-gpios = <&gpio4 RK_PC0 GPIO_ACTIVE_HIGH>; > + vpcie3v3-supply = <&vcc_3v3>; > + status = "okay"; > +}; > + > +&pinctrl { This is still missing the bluetooth and wifi pins. We know the pins from the schematics and already describe remaining pins and devices used by the onboard WiFi+BT chip. Please also include the four missing pins. bluetooth { bt_wake_host: bt-wake-host { rockchip,pins = <1 RK_PB5 RK_FUNC_GPIO &pcfg_pull_down>; }; host_wake_bt: host-wake-bt { rockchip,pins = <1 RK_PB4 RK_FUNC_GPIO &pcfg_pull_none>; }; }; > + gpio-keys { > + gpio4_b2_usr_btn: gpio4-b2-usr-btn { > + rockchip,pins = <4 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>; > + }; > + }; > + > + leds { > + led2: led2 { > + rockchip,pins = <4 RK_PB3 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > + > + pcie { > + pcie_eth_perstb: pcie-eth-perstb { > + rockchip,pins = <4 RK_PC0 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > + > + wifi { and: host_wake_wl: host-wake-wl { rockchip,pins = <1 RK_PA6 RK_FUNC_GPIO &pcfg_pull_none>; }; > + pwr_wf: pwr-wf { > + rockchip,pins = <1 RK_PC2 RK_FUNC_GPIO &pcfg_pull_none>; > + }; and: wl_wake_host: wl-wake-host { rockchip,pins = <1 RK_PA7 RK_FUNC_GPIO &pcfg_pull_down>; }; > + }; > +}; > + > +&sdio0 { > + bus-width = <4>; > + cap-sd-highspeed; > + cap-sdio-irq; > + keep-power-in-suspend; > + mmc-pwrseq = <&sdio_pwrseq>; > + no-mmc; > + no-sd; > + non-removable; > + sd-uhs-sdr104; > + vmmc-supply = <&vcc_3v3>; > + vqmmc-supply = <&vcc_1v8>; > + status = "okay"; > +}; > + > +&uart2 { > + dma-names = "tx", "rx"; > + pinctrl-names = "default"; > + pinctrl-0 = <&uart2m1_xfer>, <&uart2m1_ctsn>, <&uart2m1_rtsn>; > + uart-has-rtscts; > + status = "okay"; > +}; > + > +&usb_host0_xhci { > + /* > + * The Type-C port is also the 5V power input. Both CC pins have a > + * 5.1k pull-down, the ID pin is not connected and VBUS only feeds > + * the 5V rail, so the port can only ever be a device. > + */ > + dr_mode = "peripheral"; The CC and ID pins only help signal the initial state, device mode. The DWC3 controller can still work in dual role mode. With dr_mode=otg and a Belkin USB-C 4-in-1 Multiport Adapter [1] hooked up the OTG port on my R28S, I can access the storage device attached to the hub, with dr_mode=peripheral mode it does not. ~ # lsusb Bus 001 Device 005: ID 2109:8817 VIA Labs, Inc. USB Billboard Device Bus 001 Device 001: ID 1d6b:0002 Linux 7.1.0-next-20260619 xhci-hcd xHCI Host Controller Bus 001 Device 003: ID 050d:006b Belkin USB-C 4-in-1 Multiport Bus 001 Device 002: ID 2109:2817 VIA Labs, Inc. USB2.0 Hub Bus 001 Device 004: ID 1b1c:1a14 Corsair Voyager VEGA [ 10.219627] usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 7.01 [ 10.219691] usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 10.220672] usb usb1: Product: xHCI Host Controller [ 10.223000] usb usb1: Manufacturer: Linux 7.1.0-next-20260619 xhci-hcd [ 10.223814] usb usb1: SerialNumber: xhci-hcd.1.auto [ 10.260442] hub 1-0:1.0: USB hub found [ 10.534737] usb 1-1: new high-speed USB device number 2 using xhci-hcd [ 10.690464] usb 1-1: New USB device found, idVendor=2109, idProduct=2817, bcdDevice= 1.24 [ 10.691662] usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 10.692557] usb 1-1: Product: USB2.0 Hub [ 10.693209] usb 1-1: Manufacturer: VIA Labs, Inc. [ 10.693910] usb 1-1: SerialNumber: 000000000 [ 10.768322] hub 1-1:1.0: USB hub foundiver hub [ 11.910478] usb 1-1.3: new full-speed USB device number 3 using xhci-hcd [ 12.090565] usb 1-1.3: not running at top speed; connect to a high speed hub [ 12.148576] usb 1-1.3: New USB device found, idVendor=050d, idProduct=006b, bcdDevice= 2.01 [ 12.149670] usb 1-1.3: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 12.151418] usb 1-1.3: Product: USB-C 4-in-1 Multiport [ 12.152164] usb 1-1.3: Manufacturer: Belkin [ 12.152731] usb 1-1.3: SerialNumber: 000000000005 [ 12.326468] usb 1-1.4: new high-speed USB device number 4 using xhci-hcd [ 12.491207] usb 1-1.4: New USB device found, idVendor=1b1c, idProduct=1a14, bcdDevice= 1.10 [ 12.492298] usb 1-1.4: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 12.493213] usb 1-1.4: Product: Voyager VEGA [ 12.493777] usb 1-1.4: Manufacturer: Corsair [ 12.494489] usb 1-1.4: SerialNumber: 070894224D1DDF08 [ 12.526029] usb-storage 1-1.4:1.0: USB Mass Storage device detected [ 12.540646] scsi host0: usb-storage 1-1.4:1.0 [ 12.658716] usb 1-1.5: new high-speed USB device number 5 using xhci-hcd [ 12.759957] usb 1-1.5: New USB device found, idVendor=2109, idProduct=8817, bcdDevice= 0.01 [ 12.761051] usb 1-1.5: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 12.761966] usb 1-1.5: Product: USB Billboard Device [ 12.762748] usb 1-1.5: Manufacturer: VIA Labs, Inc. [ 12.763476] usb 1-1.5: SerialNumber: 0000000000000001 [1] https://www.belkin.com/p/usb-c-4-in-1-multiport-adapter/AVC006btSGY.html Regards, Jonas > + extcon = <&usb2phy>; > + maximum-speed = "high-speed"; > + phys = <&usb2phy_otg>; > + phy-names = "usb2-phy"; > + status = "okay"; > +}; > + > +&usb2phy { > + status = "okay"; > +}; > + > +&usb2phy_otg { > + status = "okay"; > +}; >