From: Krzysztof Kozlowski <krzk@kernel.org>
To: Luo Jie <quic_luoj@quicinc.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Lei Wei <quic_leiwei@quicinc.com>,
Suruchi Agarwal <quic_suruchia@quicinc.com>,
Pavithra R <quic_pavir@quicinc.com>,
Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-hardening@vger.kernel.org,
quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com,
srinivas.kandagatla@linaro.org, bartosz.golaszewski@linaro.org,
john@phrozen.org
Subject: Re: [PATCH net-next v4 01/14] dt-bindings: net: Add PPE for Qualcomm IPQ9574 SoC
Date: Sat, 24 May 2025 08:25:51 +0200 [thread overview]
Message-ID: <e9dac160-f90a-48e2-9269-245b36c3aefe@kernel.org> (raw)
In-Reply-To: <a182df27-5b0d-42d1-8f58-4e7a913bb12d@quicinc.com>
On 23/05/2025 12:28, Luo Jie wrote:
>>> + interconnect-names:
>>> + items:
>>> + - const: ppe
>>> + - const: ppe_cfg
>>> + - const: qos_gen
>>> + - const: timeout_ref
>>> + - const: nssnoc_memnoc
>>> + - const: memnoc_nssnoc
>>> + - const: memnoc_nssnoc_1
>>> +
>>> + ethernet-dma:
>>
>> I don't get why this is a separate node.
>>
>
> We used a separate node because the EDMA (Ethernet DMA)
> is a separate block within the PPE block, with specific
> functions like ports-to-host-CPU packet transfer and
> hardware packet steering. We felt that a separate node
> would depict the hierarchy more clearly. Could you please
> suggest if a single node is recommended instead?
Since it is a separate block and it has its own resources, it is fine.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-24 6:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 9:58 [PATCH net-next v4 00/14] Add PPE driver for Qualcomm IPQ9574 SoC Luo Jie
2025-05-13 9:58 ` [PATCH net-next v4 01/14] dt-bindings: net: Add PPE " Luo Jie
2025-05-19 8:16 ` Krzysztof Kozlowski
2025-05-23 10:28 ` Luo Jie
2025-05-24 6:25 ` Krzysztof Kozlowski [this message]
2025-05-26 7:25 ` Luo Jie
2025-05-13 9:58 ` [PATCH net-next v4 02/14] docs: networking: Add PPE driver documentation " Luo Jie
2025-05-13 9:58 ` [PATCH net-next v4 03/14] net: ethernet: qualcomm: Add PPE driver for " Luo Jie
2025-05-13 9:58 ` [PATCH net-next v4 04/14] net: ethernet: qualcomm: Initialize PPE buffer management for IPQ9574 Luo Jie
2025-05-13 9:58 ` [PATCH net-next v4 05/14] net: ethernet: qualcomm: Initialize PPE queue " Luo Jie
2025-05-13 9:58 ` [PATCH net-next v4 06/14] net: ethernet: qualcomm: Initialize the PPE scheduler settings Luo Jie
2025-05-13 9:58 ` [PATCH net-next v4 07/14] net: ethernet: qualcomm: Initialize PPE queue settings Luo Jie
2025-05-13 9:58 ` [PATCH net-next v4 08/14] net: ethernet: qualcomm: Initialize PPE service code settings Luo Jie
2025-05-13 9:58 ` [PATCH net-next v4 09/14] net: ethernet: qualcomm: Initialize PPE port control settings Luo Jie
2025-05-13 9:58 ` [PATCH net-next v4 10/14] net: ethernet: qualcomm: Initialize PPE RSS hash settings Luo Jie
2025-05-13 9:58 ` [PATCH net-next v4 11/14] net: ethernet: qualcomm: Initialize PPE queue to Ethernet DMA ring mapping Luo Jie
2025-05-13 9:58 ` [PATCH net-next v4 12/14] net: ethernet: qualcomm: Initialize PPE L2 bridge settings Luo Jie
2025-05-13 9:58 ` [PATCH net-next v4 13/14] net: ethernet: qualcomm: Add PPE debugfs support for PPE counters Luo Jie
2025-05-13 9:58 ` [PATCH net-next v4 14/14] MAINTAINERS: Add maintainer for Qualcomm PPE driver Luo Jie
2025-05-15 2:58 ` [PATCH net-next v4 00/14] Add PPE driver for Qualcomm IPQ9574 SoC Jakub Kicinski
2025-05-15 14:19 ` Luo Jie
2025-05-15 14:24 ` Jakub Kicinski
2025-05-16 10:59 ` Luo Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9dac160-f90a-48e2-9269-245b36c3aefe@kernel.org \
--to=krzk@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=horms@kernel.org \
--cc=john@phrozen.org \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_luoj@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox