From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Paweł Anikiel" <pan@semihalf.com>
Cc: Conor Dooley <conor@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, dinguyen@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, mchehab@kernel.org, upstream@semihalf.com,
amstan@chromium.org, ribalda@chromium.org
Subject: Re: [RFC PATCH 3/3] ARM: dts: Add Chameleon v3 video node
Date: Tue, 4 Jul 2023 18:23:10 +0200 [thread overview]
Message-ID: <e9fe352a-92fc-023b-8ce2-9a82cbeaada9@linaro.org> (raw)
In-Reply-To: <CAF9_jYSwDdyE6mj8+1bA23MWmFHdm16jTSYaRQiF1kzpUtkMNQ@mail.gmail.com>
On 04/07/2023 18:16, Paweł Anikiel wrote:
>>>>> + soc {
>>>>> + video@c0060500 {
>>>>> + compatible = "google,chv3-video";
>>>>
>>>> This compatible does not seem to be documented & I did not see a comment
>>>> about the lack of a binding in the cover letter. What am I missing?
>>>
>>> Yes, the compatible is not documented for now (I'll do that in a later
>>> patchset), sorry for not mentioning that in the cover letter.
>>
>> You cannot add undocumented compatible. This cannot be fixed in "a later
>> patchset".
>
> I meant later revision, I'm certainly not expecting this one to land
> (I sent is as an RFC).
That's not clear. RFC is interpreted differently by different people.
Some just ignore it entirely, some still review.
> Is it really necessary to document the
> compatible to get any form of feedback on the overall structure of the
> driver?
Depends on the person. Anyway no problem for me - I will just ignore the
patchset.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-04 16:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 14:40 [RFC PATCH 0/3] Google Chameleon v3 video driver Paweł Anikiel
2023-06-30 14:40 ` [RFC PATCH 1/3] media: Add 10, 12, and 16 bit RGB formats Paweł Anikiel
2023-07-07 18:34 ` Nicolas Dufresne
2023-09-06 10:37 ` Hans Verkuil
2023-06-30 14:40 ` [RFC PATCH 2/3] media: Add Google Chameleon v3 video driver Paweł Anikiel
2023-09-06 11:14 ` Hans Verkuil
2023-09-06 16:27 ` Paweł Anikiel
2023-09-07 7:47 ` Hans Verkuil
2023-06-30 14:40 ` [RFC PATCH 3/3] ARM: dts: Add Chameleon v3 video node Paweł Anikiel
2023-06-30 18:25 ` Conor Dooley
2023-07-03 11:44 ` Paweł Anikiel
2023-07-03 12:33 ` Krzysztof Kozlowski
2023-07-04 16:16 ` Paweł Anikiel
2023-07-04 16:23 ` Krzysztof Kozlowski [this message]
2023-07-04 16:27 ` Conor Dooley
2023-07-05 14:45 ` [RFC PATCH 0/3] Google Chameleon v3 video driver Alexandru M Stan
2023-09-06 11:15 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9fe352a-92fc-023b-8ce2-9a82cbeaada9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=amstan@chromium.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pan@semihalf.com \
--cc=ribalda@chromium.org \
--cc=robh+dt@kernel.org \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).