From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79100EB64D9 for ; Tue, 4 Jul 2023 16:23:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231544AbjGDQXQ (ORCPT ); Tue, 4 Jul 2023 12:23:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231533AbjGDQXP (ORCPT ); Tue, 4 Jul 2023 12:23:15 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07AEFE5 for ; Tue, 4 Jul 2023 09:23:14 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-992acf67388so555035566b.1 for ; Tue, 04 Jul 2023 09:23:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688487792; x=1691079792; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=87qn+jDFmVjTjNNSNN4hyKbPaUWhaGHKw5mutwlghV0=; b=thqIhKjk+3/lpsVetwxdSSKRYKPie8Yu9UjOxT00FG6lJDDk+cB3qEV8ST5s9r03JU zJIWyZwoj7zgqNV4bVsM0ZKU6pegDD8RoYyBaeV+OdqsSSJNWLtOKI1BzQyrNXYdlUzu 0+tW8+zN/UVYPusbOoYjuF7FHBglodu34DadggW6qU5Z8lTaemgfwtHHvwM+nXm/62NQ ucCACu17Lx2174722iVdgZe3uTnikofS/iVLJ3dnQ2u0z5zvdUqVVbE9DBx90Gtr0vLR 3B+ySh7CwpA6V/Ikw0og//MbN/8mYOifyyxu2UHjVprnWfLvCkPSaoHBUSSwEZRicFYB LUYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688487792; x=1691079792; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=87qn+jDFmVjTjNNSNN4hyKbPaUWhaGHKw5mutwlghV0=; b=fW0B59ZfwOBjSJfO+jWoQgp5DHGZXUEJidcYAKDGz6PuPJRO2r91FDLGo5CkhMkWCd NsQDcWCaO1dGrE/g7LDLt7RtvKYD6DmFiyQq+P7kSsx203V4c5UIy6USP5KNK9a3tyLs vccqj36IshMtn5WWyzJUqnsOG4IHyzwhUFvb8cPpcjwhy0rq2Uk9ODOVh+JEqVJLkMYX rZRStVbdEp7GxW9bkk8P0IuiaPrIMPGYZsd3VNTyjSEUlCpMKhrpEQFJujntcnVj+J/M o1rWIcWyNCAV+1OWZsJJYuprguO8IUqrmQLBltZVQBHwpc8TGOGGpaTnh1J21ZNIrFV+ F4rQ== X-Gm-Message-State: ABy/qLY/N9BLkpxTbREf+SmQZDYHHdSzLmWzjY3uSuIr1PnW5NBzg6LC 6ERnvqpuECIH78BBwjXoid7YyQ== X-Google-Smtp-Source: ACHHUZ7/NIpswkXshblERoeHprWOJkw+WrHbAmIg2j08RnIJ3GKG/arya5htPe+byj4V25F0fpNT4A== X-Received: by 2002:a17:907:9867:b0:97e:56d5:b885 with SMTP id ko7-20020a170907986700b0097e56d5b885mr8788602ejc.60.1688487792504; Tue, 04 Jul 2023 09:23:12 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id ha22-20020a170906a89600b0098e0c0cfb66sm12873649ejb.38.2023.07.04.09.23.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jul 2023 09:23:12 -0700 (PDT) Message-ID: Date: Tue, 4 Jul 2023 18:23:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RFC PATCH 3/3] ARM: dts: Add Chameleon v3 video node Content-Language: en-US To: =?UTF-8?Q?Pawe=c5=82_Anikiel?= Cc: Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dinguyen@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, mchehab@kernel.org, upstream@semihalf.com, amstan@chromium.org, ribalda@chromium.org References: <20230630144006.1513270-1-pan@semihalf.com> <20230630144006.1513270-4-pan@semihalf.com> <20230630-scrimmage-antelope-7d1f82d491fc@spud> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/07/2023 18:16, Paweł Anikiel wrote: >>>>> + soc { >>>>> + video@c0060500 { >>>>> + compatible = "google,chv3-video"; >>>> >>>> This compatible does not seem to be documented & I did not see a comment >>>> about the lack of a binding in the cover letter. What am I missing? >>> >>> Yes, the compatible is not documented for now (I'll do that in a later >>> patchset), sorry for not mentioning that in the cover letter. >> >> You cannot add undocumented compatible. This cannot be fixed in "a later >> patchset". > > I meant later revision, I'm certainly not expecting this one to land > (I sent is as an RFC). That's not clear. RFC is interpreted differently by different people. Some just ignore it entirely, some still review. > Is it really necessary to document the > compatible to get any form of feedback on the overall structure of the > driver? Depends on the person. Anyway no problem for me - I will just ignore the patchset. Best regards, Krzysztof