From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B42B5C77B6D for ; Mon, 3 Apr 2023 09:20:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231954AbjDCJUr (ORCPT ); Mon, 3 Apr 2023 05:20:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231734AbjDCJUp (ORCPT ); Mon, 3 Apr 2023 05:20:45 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91DF593FA for ; Mon, 3 Apr 2023 02:20:23 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id h8so114577841ede.8 for ; Mon, 03 Apr 2023 02:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680513618; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TmSyxcm8BJSoYWuOuSBcSo8zV/M9qb7hhSq19YND1UY=; b=xJebsaKdcz+6FXuLTQL4cNTwcf9BqrdATMXAVznxn3dS2rZvbkicpPhLO2I6a3U4jy 1oq9eiT3inXdEjJ67eMfWWL2hRBRg44FG2L2dUbCzy4z+u14y5tZPVtmtemO9uQ6GCXJ kgTbDKTlr7djkkBFxjH2ZAbtppi02p8LFONRDaAEPppWRhLVL805Bopmz86k44BpDUI+ fpC+xDJk7otRslhj5i9RfBe/bfHvGyCz/Z6rX9K9ocbGQ059CE7Hu0/ElgGTvRvOCxKz vd/YNRIKTvIyksyvaKvFQBAvQZ3QmosmZpXE21wOaLINgMRJE2bBaCvCEBvWOwcvUL/n XM5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680513618; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TmSyxcm8BJSoYWuOuSBcSo8zV/M9qb7hhSq19YND1UY=; b=pM3NgxG+UgyyWFEIcjdGj4ewQaTpjIRro8CL0KaJbGej1pzOt4YfrwFg/3f6p0HcR4 SFonx0zaXJSlAVmyQzQGZidcTSOjAEXZnqJOPShca5apmpy9hEIS9zhbYr/K6APV4OtO BtLPqULrTdHrBnJ4mJzs2hQK76QbXj5vQYjdDxh1RM1cyHXBVa9iXrJGzPb6egFF0IPA FVVFKR4GnX2Rb4g0M0jQ9a5rX+YR4qmXgBd/2vY0jgZg8DYARth5DFHVIHx7brNoO7kN v8x47NBA9rEXtEW0sdCmoQsbpuODRe/z1b54dUF3mrqAhmm2kmP2bhRKqzCoyPejYVPs 3ggg== X-Gm-Message-State: AAQBX9czJ/aGta7MiFKlSD3/VvcgQ4Y8TvZ4gydMkjHRjIfJ7NRV4fer T5s57BzfWjC3UNE0JjKYPE4oVg== X-Google-Smtp-Source: AKy350Z7UeDN3d513QyXyVVdtex7nqmjclKXJK4+cizpiT6KXI/PnQhltSjZ4t/EL9+4vzq5ib3EEw== X-Received: by 2002:a17:907:9c08:b0:93f:9b4a:12f3 with SMTP id ld8-20020a1709079c0800b0093f9b4a12f3mr33288504ejc.10.1680513617877; Mon, 03 Apr 2023 02:20:17 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:ae90:d80:1069:4805? ([2a02:810d:15c0:828:ae90:d80:1069:4805]) by smtp.gmail.com with ESMTPSA id j18-20020a17090623f200b00947a749fc3esm4040880ejg.33.2023.04.03.02.20.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 02:20:17 -0700 (PDT) Message-ID: Date: Mon, 3 Apr 2023 11:20:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v4 4/6] dts: qcom: arm64: qcom: sdm845: use defines for VMIDs Content-Language: en-US To: Dylan Van Assche , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20230401173523.15244-1-me@dylanvanassche.be> <20230401173523.15244-5-me@dylanvanassche.be> From: Krzysztof Kozlowski In-Reply-To: <20230401173523.15244-5-me@dylanvanassche.be> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/04/2023 19:35, Dylan Van Assche wrote: > Use VMID defines for SLPI's FastRPC node in the Qualcomm SDM845 DTS > instead of hardcoded magic values. > > Signed-off-by: Dylan Van Assche > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 1f25a7f4e02b..dc4b553cbe2e 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -3372,7 +3373,8 @@ fastrpc { > qcom,glink-channels = "fastrpcglink-apps-dsp"; > label = "sdsp"; > qcom,non-secure-domain; > - qcom,vmids = <0x3 0xF 0x5 0x6>; Didn't you just add it in previous patch? Don't add incorrect code which you immediately change. Best regards, Krzysztof