From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E336C7EE21 for ; Thu, 4 May 2023 13:50:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231264AbjEDNu6 (ORCPT ); Thu, 4 May 2023 09:50:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230366AbjEDNu5 (ORCPT ); Thu, 4 May 2023 09:50:57 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F7BF12A for ; Thu, 4 May 2023 06:50:56 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3f3331f928cso4131815e9.2 for ; Thu, 04 May 2023 06:50:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683208254; x=1685800254; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=CBa5yf09RWH4yiJkKKfGA5cpxuaznqIjeI5vqh5jKnc=; b=xXTCdKLJQRFOFCzlTq25XVRG7iQ2YTig8JrOBlX202YIt83MpXRScjaLxgVkY0zWnX DAVukRu+mKp/O1lsgwViKkyFW5TflkdO+9RSnOsPHJf1UAuvmWhLpdvus2AS6Xx56NDm CfWYEWqfh/q/sQRS9cAWeu5+0DKAw8bGkidhmv8yzMLKCAVlMYDjKTkaErzmqMlx9vh1 DbS/JUBo+CCNe2h2qgjAEEJuEUOYtQ2xsNqwMrt8nEvQB4N73in46NuRPL+RS0Rw5t61 ZjElPUzI86zAglFLOI5kjjaAYdQ2zK8mOxkBdMX3cvwx4ZC5ZEWZEDh6z887sMcghrwC EYaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683208254; x=1685800254; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CBa5yf09RWH4yiJkKKfGA5cpxuaznqIjeI5vqh5jKnc=; b=llHJiKQEyXWy8hb+LUNF5buMTYyXTKxmx0MQ3MB0VzuvjTBM0HFHUVszkITVzjvpQO q6xcbGkVBPsADtuCpJsa/xB+9S6sMcyGbx2ZLHrocHDcf1q/7PAWuUKO+oF5SibXTU0Y pz4JqzOqJ1zA47dD3ZbUDDaV82in9cSiSHMBkHi9oig+ufDi7EeN9azAZrqMqMZbgEEe 6lEmiHkVyrW41p5b4vWicAbVE21JrBtlu8XpxLXqXwpXLoDupI/nm2SH87quErS1VWsR BZU0TGEzmDEQwYcrPuZQqz6FEJdgA3R5hjd5UJc9vwimT0HpINvZrxmz5PMOOEpUsEua 5xxw== X-Gm-Message-State: AC+VfDy4rNvL4+Z2yDvgj4K5SB9yw5luZcsTgpsdCPOXhOZnDoMgMyWO gJ8kJASVvmGg7coWn45MhRjgog== X-Google-Smtp-Source: ACHHUZ5cfrBrKo0XKh8lYl7HP9vVSfMA8XPRqej+s9gQ4qUP1IFXfzgg0heMVynEUJsKqQXaLU6aZw== X-Received: by 2002:a05:6000:1b82:b0:306:2a21:b5ff with SMTP id r2-20020a0560001b8200b003062a21b5ffmr2371851wru.17.1683208254591; Thu, 04 May 2023 06:50:54 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:52fb:80bd:bee3:f741? ([2a01:e0a:982:cbb0:52fb:80bd:bee3:f741]) by smtp.gmail.com with ESMTPSA id y6-20020a1c4b06000000b003f17131952fsm4982246wma.29.2023.05.04.06.50.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 May 2023 06:50:54 -0700 (PDT) Message-ID: Date: Thu, 4 May 2023 15:50:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/7] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp: Add ports and orientation-switch Content-Language: en-US To: Bjorn Andersson , Bryan O'Donoghue Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Johan Hovold , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230425034010.3789376-1-quic_bjorande@quicinc.com> <20230425034010.3789376-2-quic_bjorande@quicinc.com> <20230427195232.GB870858@hu-bjorande-lv.qualcomm.com> From: Neil Armstrong Organization: Linaro Developer Services In-Reply-To: <20230427195232.GB870858@hu-bjorande-lv.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/04/2023 21:52, Bjorn Andersson wrote: > On Wed, Apr 26, 2023 at 11:21:29AM +0100, Bryan O'Donoghue wrote: >> On Tue, Apr 25, 2023 at 4:40 AM Bjorn Andersson >> wrote: >>> >>> The QMP combo phy can be connected to a TCPM, a USB controller and a >>> DisplayPort controller for handling USB Type-C orientation switching >>> and propagating HPD signals. >>> >>> Extend the binding to allow these connections to be described. >>> >>> Signed-off-by: Bjorn Andersson >>> --- >>> .../phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml | 51 +++++++++++++++++++ >>> 1 file changed, 51 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml >>> index 3cd5fc3e8fab..c037ac90ce7f 100644 >>> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml >>> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml >>> @@ -60,6 +60,26 @@ properties: >>> description: >>> See include/dt-bindings/dt-bindings/phy/phy-qcom-qmp.h >>> >>> + orientation-switch: >>> + description: >>> + Flag the PHY as possible handler of USB Type-C orientation switching >>> + type: boolean >>> + >>> + ports: >>> + $ref: /schemas/graph.yaml#/properties/ports >>> + properties: >>> + port@0: >>> + $ref: /schemas/graph.yaml#/properties/port >>> + description: Output endpoint of the PHY >>> + >>> + port@1: >>> + $ref: /schemas/graph.yaml#/$defs/port-base >>> + description: Incoming endpoint from the USB controller >> >> Do you really need this one ? >> >> The controller doesn't process orientation switching. >> > > I don't have a need for it, as we can deal with role switching by > connecting connector/port@0 to the dwc3. > > But if we ever have a need to describe the dwc3 -> QMP -> connector path > in the of_graph I think it would look prettier to have USB input as > port@1 and DP input as port@2... I think it would be great to have port@1 for USB SS and port@2 for DP, otherwise we need to add 2 endpoints as I sent in https://lore.kernel.org/all/20230503-topic-sm8450-graphics-dp-next-v1-1-d1ee9397f2a6@linaro.org/ since we split USB HS and SS streams on SM8[345]50 platforms. > > Do you have a concern with keeping it around in the DT (the > implementation doesn't need to care)? > > Regards, > Bjorn