Re: [PATCH 1/2] dt-bindings: interconnect: qcom: Add Qualcomm MSM8953 NoC

[Krzysztof Kozlowski <krzk@kernel.org>]

On 26/06/2024 22:35, Barnabás Czémán wrote:
> From: Vladimir Lypak <vladimir.lypak@gmail.com>
> 
> Add the device-tree bindings for interconnect providers
> used on MSM8953 platform.
> 
> Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---
>  .../bindings/interconnect/qcom,msm8953.yaml        | 100 +++++++++++++++++++++
>  include/dt-bindings/interconnect/qcom,msm8953.h    |  93 +++++++++++++++++++
>  2 files changed, 193 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8953.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8953.yaml
> new file mode 100644
> index 000000000000..c24339f37233
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8953.yaml
> @@ -0,0 +1,100 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interconnect/qcom,msm8953.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm MSM8953 Network-On-Chip interconnect
> +
> +maintainers:
> +  - Barnabas Czeman <barnabas.czeman@mainlining.org>
> +
> +description: |
> +  The Qualcomm MSM8953 interconnect providers support adjusting the
> +  bandwidth requirements between the various NoC fabrics.
> +
> +  See also:
> +  - dt-bindings/interconnect/qcom,msm8953.h
> +
> +allOf:

Please move this entire "allOf:" after "required:" block.

> +  - $ref: qcom,rpm-common.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          const: qcom,msm8953-pcnoc
> +
> +    then:
> +      properties:
> +        clocks:
> +          items:
> +            - description: PCNOC USB3 AXI Clock.
> +
> +        clock-names:
> +          const: pcnoc_usb3_axi
> +
> +      required:
> +        - compatible

Drop

> +        - reg

Drop

> +        - clocks
> +        - clock-names
> +        - '#interconnect-cells'

Drop


    else:
      properties:
        clocks: false
        clocks-names: false

> +
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,msm8953-bimc
> +      - qcom,msm8953-pcnoc
> +      - qcom,msm8953-snoc
> +

> 

Best regards,
Krzysztof