From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03D1577F10; Thu, 21 Dec 2023 22:25:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=flygoat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flygoat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flygoat.com header.i=@flygoat.com header.b="rwOmRmKv"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="bFmVs5qV" Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id E38625C012A; Thu, 21 Dec 2023 17:25:08 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 21 Dec 2023 17:25:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1703197508; x=1703283908; bh=eH8YlOHbyQF9nz7myzuZh9BOJuRmKavlURr+Ne9G3Js=; b= rwOmRmKvfbDKKnZKykFLnnXxny/Pt9hSZ0mjRJNW8nGu7G9kVvB1GwD6qT7c5qdT fkpz2pxofb05LgQd1nSj4CTr5tz7FkErqJdKFbxIXbyFXhOW0PW/IKP2kmVgQulP m3wpPyOm/8Tj58azIC7dICkj/qUp+9c2XDWxGmAw5tyTMimdFeCkpD1WAzXKx5pc Bjt7E5zIWEqjNe4yQe7U2MBOY7a8lIe/RbSxY1K2olmql/Vp21FBmEmXcZ+gNiNZ 5MTA7FrjvVbLMnuEpayNZxgF9sFDyL3jhTkqFmJD7LY9tew6wvCGF1ozGrQPQrIy pmaMsMOcMpWfgrGwL1C97Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1703197508; x= 1703283908; bh=eH8YlOHbyQF9nz7myzuZh9BOJuRmKavlURr+Ne9G3Js=; b=b FmVs5qVIdMVjg5r7l2zjyENguY0VWijM/7Mj25tb/Y2UQZYkFMAFL9cGishPVJ7E vWuqJsSCs/KsULp1IV7QSo2PdRaDyLU3yOCut5ueHFM96GOs5SRAEGX58Tbyzzwl /ybskaDf5kv8o6sN3J5FEZytg1yzxCHXi06OWjVfNJST4oAerwJZJslLz2NuQS2i 0XVqsoi6btNeZkg4H+nPyQmHZGE4Cwmv0lLEfKK19mFOGbDBrIg0ulkITCRBVyCk PntZ5VSZmad2Ww4KbJW4nM+ov0wPHrrHga24DBiP/KL2nsN7WvPyIPpE1YqbFewV shQMXK/akkn4GMEdgy2Vw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdduhedgudefhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthekredttddvjeenucfhrhhomheplfhi rgiguhhnucgjrghnghcuoehjihgrgihunhdrhigrnhhgsehflhihghhorghtrdgtohhmqe enucggtffrrghtthgvrhhnpeelueffheehgeeluedvlefghfeukeejteeuveeuhffftdfg uefhgefgueekffeftdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehjihgrgihunhdrhigrnhhgsehflhihghhorghtrdgtohhm X-ME-Proxy: Feedback-ID: ifd894703:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 21 Dec 2023 17:25:06 -0500 (EST) Message-ID: Date: Thu, 21 Dec 2023 22:25:04 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 00/22] Add support for the Mobileye EyeQ5 SoC Content-Language: en-US To: Thomas Bogendoerfer , Gregory CLEMENT Cc: Paul Burton , linux-mips@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vladimir Kondratiev , Tawfik Bayouk , Alexandre Belloni , =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Thomas Petazzoni References: <20231212163459.1923041-1-gregory.clement@bootlin.com> <878r5vctdg.fsf@BL-laptop> <87frzwasxo.fsf@BL-laptop> From: Jiaxun Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2023/12/21 14:55, Thomas Bogendoerfer 写道: > On Thu, Dec 21, 2023 at 08:57:55AM +0100, Gregory CLEMENT wrote: >> I do not oppose the addition of a new platform, even though, like >> Jiaxun, I would prefer to avoid duplicating code. The only thing >> preventing the use of the same kernel for EyeQ5 and other platforms is >> the starting address. > there shouldn't be code duplication. > > My rough idea would be something like > > diff --git a/arch/mips/Kbuild b/arch/mips/Kbuild > index af2967bffb73..d683993ed331 100644 > --- a/arch/mips/Kbuild > +++ b/arch/mips/Kbuild > @@ -17,6 +17,7 @@ obj- := $(platform-y) > # mips object files > # The object files are linked as core-y files would be linked > > +obj-y += generic/ > obj-y += kernel/ > obj-y += mm/ > obj-y += net/ > diff --git a/arch/mips/generic/Makefile b/arch/mips/generic/Makefile > index e37a59bae0a6..56011d738441 100644 > --- a/arch/mips/generic/Makefile > +++ b/arch/mips/generic/Makefile > @@ -4,9 +4,9 @@ > # Author: Paul Burton > # > > -obj-y += init.o > -obj-y += irq.o > -obj-y += proc.o > +obj-$(CONFIG_MACH_GENERIC_CORE) += init.o > +obj-$(CONFIG_MACH_GENERIC_CORE) += irq.o > +obj-$(CONFIG_MACH_GENERIC_CORE) += proc.o > > obj-$(CONFIG_YAMON_DT_SHIM) += yamon-dt.o > obj-$(CONFIG_LEGACY_BOARD_SEAD3) += board-sead3.o > > so everyboady needing these parts of a generic kernel is able > to take it. > >> Therefore, if it were possible to have a relocatable kernel, this >> issue would disappear. > yes. There is support for relocatable kernel, so what are we missing > there ? It does not handle 64 bit relocations currently. I tried to look into it and it's not a easy fix. Thanks - Jiaxun > Thomas. >