From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lelv0142.ext.ti.com ([198.47.23.249]:59174 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725869AbfHMUbO (ORCPT ); Tue, 13 Aug 2019 16:31:14 -0400 Subject: Re: [PATCH v4 1/2] dt-bindings: Add docs for EL15203000 References: <20190808203204.8614-1-oleg@kaa.org.ua> From: Dan Murphy Message-ID: Date: Tue, 13 Aug 2019 15:31:05 -0500 MIME-Version: 1.0 In-Reply-To: <20190808203204.8614-1-oleg@kaa.org.ua> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: devicetree-owner@vger.kernel.org To: Oleh Kravchenko , devicetree@vger.kernel.org, linux-leds@vger.kernel.org List-ID: Jacek Need your input below On 8/8/19 3:32 PM, Oleh Kravchenko wrote: > Add documentation and example for dt-bindings EL15203000. > LED board (aka RED LED board) from Crane Merchandising Systems. > > Signed-off-by: Oleh Kravchenko > --- > .../bindings/leds/leds-el15203000.txt | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-el15203000.txt > > diff --git a/Documentation/devicetree/bindings/leds/leds-el15203000.txt b/Documentation/devicetree/bindings/leds/leds-el15203000.txt > new file mode 100644 > index 000000000000..4c2245babfdc > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-el15203000.txt > @@ -0,0 +1,47 @@ > +Crane Merchandising System - el15203000 LED driver > +-------------------------------------------------- > + > +This LED Board (aka RED LEDs board) is widely used in > +coffee vending machines produced by Crane Merchandising Systems. > + > +Required properties: > +- compatible : "crane,el15203000" > +- reg : > + see Documentation/devicetree/bindings/spi/spi-bus.txt > +- spi-max-frequency : (optional) > + see Documentation/devicetree/bindings/spi/spi-bus.txt > + > +Optional LED sub-node properties: > +- label : > + see Documentation/devicetree/bindings/leds/common.txt > +- linux,default-trigger : > + see Documentation/devicetree/bindings/leds/common.txt > + > +Example > +------- > + > +led-controller@0 { > + compatible = "crane,el15203000"; > + reg = <0>; > + spi-max-frequency = <50000>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* water pipe */ > + pipe@50 { > + reg = <0x50>; > + label = "red:pipe"; Should we use the color and function property here? Not sure what function would be for pipe, screen or vending but there may be comparable functions that may fit. Dan