From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9173C001B2 for ; Wed, 14 Dec 2022 10:26:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237521AbiLNK0M (ORCPT ); Wed, 14 Dec 2022 05:26:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229662AbiLNK0L (ORCPT ); Wed, 14 Dec 2022 05:26:11 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D33C62F8; Wed, 14 Dec 2022 02:26:11 -0800 (PST) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BE3w769001066; Wed, 14 Dec 2022 10:25:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=Y9OrsWUQOhpGD0F4VnWAF1+/2i9E5gP+zihLAdq4O6I=; b=WXusX9MRNDL4TJA2QIzWwZKKRNNpvrKfohhiV3pVdvMM+oYVJAmDOBSvK6sYODOe272v wvGyFvbMOra4tcn5AIxmalSKLtSmyAaHz1Pe7R9mKZlNIyKlRIGFsH9yYyvuwyLUAM+3 wg2CmZMjmpjtV/zKmUAg3/LqK7SCAr/dDUW4rza2CcbORqweA/n94xkK1m3E4tAZG6JL 6HdZkZTQAA9fe+hqdPJvigJAKq4kfT1U0QurK7yA/kZyWCfLRKeL34tvR2491u4TPywK ICWvZt//MuVJkDhTgR9nYgn+u5ZXqIGmH2MAZ6oEfVeAMkcknVMUIwocREUjd7m75XOA mg== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3mf6rf8r3j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Dec 2022 10:25:49 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2BEAPmYJ004697 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Dec 2022 10:25:48 GMT Received: from [10.79.43.91] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 14 Dec 2022 02:25:44 -0800 Message-ID: Date: Wed, 14 Dec 2022 15:55:41 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 2/4] dt-bindings: remoteproc: qcom: sc7180: Update memory-region requirements Content-Language: en-US To: Krzysztof Kozlowski , , , , CC: , , , , , , , , , , References: <20221213140724.8612-1-quic_sibis@quicinc.com> <20221213140724.8612-3-quic_sibis@quicinc.com> <612c1019-11c0-38b6-e1d5-1a52f1456989@linaro.org> From: Sibi Sankar In-Reply-To: <612c1019-11c0-38b6-e1d5-1a52f1456989@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: gW8JAOFPVlseI5FPxY4dStgWZ9hcBwBd X-Proofpoint-ORIG-GUID: gW8JAOFPVlseI5FPxY4dStgWZ9hcBwBd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-14_04,2022-12-14_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 mlxscore=0 impostorscore=0 adultscore=0 spamscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212140082 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/14/22 01:11, Krzysztof Kozlowski wrote: > On 13/12/2022 15:07, Sibi Sankar wrote: >> Update the bindings to reflect the addition of the new modem metadata >> carveout reference to the memory-region property. >> >> Signed-off-by: Sibi Sankar >> --- >> .../devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml | 3 ++- >> .../devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml | 3 ++- >> 2 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml >> index e4a7da8020f4..b1402bef0ebe 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml >> @@ -95,6 +95,7 @@ properties: >> items: >> - description: MBA reserved region >> - description: modem reserved region >> + - description: metadata reserved region > > Which makes the third item now required, also for all out of tree DTS > and other users of the bindings. Please write a bit more in commit msg > why this is necessary (e.g. was it broken before?). I assume the driver > does not break the ABI? I'll pad the commit msg with some of the additional info from patch 4. commit c44094eee32f "arm64: dma: Drop cache invalidation from arch_dma_prep_coherent()" exposed a bug in the driver affecting SoCs from msm8996 on wards. The application processor accessing the dynamically allocated region after giving control to the modem results in a XPU violation. The recommended fix was to use a no-map carveout instead and memunmap before giving control to the modem. The future kernels that are paired with an older dtbs would crash during modem bootup since we would continue to use dma_alloc_attr. But all the other combinations (old kernel/new dtb) will continue to work. - Sibi > > Best regards, > Krzysztof >