* [PATCH] arm64: dts: qcom: sc7280: Add support for two additional DDR frequencies
@ 2025-07-01 7:43 Pushpendra Singh
2025-07-01 7:56 ` Krzysztof Kozlowski
2025-07-01 18:13 ` Trilok Soni
0 siblings, 2 replies; 5+ messages in thread
From: Pushpendra Singh @ 2025-07-01 7:43 UTC (permalink / raw)
To: cros-qcom-dts-watchers, andersson, konradybcio, robh, krzk+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: Pushpendra Singh, kernel
Cc: kernel@quicinc.com, kernel@oss.qualcomm.com
The SC7280 SoC now supports two additional frequencies. This patch
add those frequencies to the BWMON OPP table and updates the frequency
mapping table accordingly.
These changes do not impact existing platforms, as the updated mapping
only affects the highest OPP. On any given platform, this will continue
to vote for the maximum available OPP.
Change-Id: Id3a91e065c49848d9af18e5c3edee0836cb693e5
Signed-off-by: Pushpendra Singh <quic_pussin@quicinc.com>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 64a2abd30100..cb945abf0475 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -620,12 +620,12 @@ cpu4_opp_2208mhz: opp-2208000000 {
cpu4_opp_2400mhz: opp-2400000000 {
opp-hz = /bits/ 64 <2400000000>;
- opp-peak-kBps = <8532000 48537600>;
+ opp-peak-kBps = <12787200 48537600>;
};
cpu4_opp_2611mhz: opp-2611200000 {
opp-hz = /bits/ 64 <2611200000>;
- opp-peak-kBps = <8532000 48537600>;
+ opp-peak-kBps = <12787200 48537600>;
};
};
@@ -685,22 +685,22 @@ cpu7_opp_2381mhz: opp-2380800000 {
cpu7_opp_2400mhz: opp-2400000000 {
opp-hz = /bits/ 64 <2400000000>;
- opp-peak-kBps = <8532000 48537600>;
+ opp-peak-kBps = <12787200 48537600>;
};
cpu7_opp_2515mhz: opp-2515200000 {
opp-hz = /bits/ 64 <2515200000>;
- opp-peak-kBps = <8532000 48537600>;
+ opp-peak-kBps = <12787200 48537600>;
};
cpu7_opp_2707mhz: opp-2707200000 {
opp-hz = /bits/ 64 <2707200000>;
- opp-peak-kBps = <8532000 48537600>;
+ opp-peak-kBps = <12787200 48537600>;
};
cpu7_opp_3014mhz: opp-3014400000 {
opp-hz = /bits/ 64 <3014400000>;
- opp-peak-kBps = <8532000 48537600>;
+ opp-peak-kBps = <12787200 48537600>;
};
};
@@ -4013,6 +4013,12 @@ opp-6 {
opp-7 {
opp-peak-kBps = <8532000>;
};
+ opp-8 {
+ opp-peak-kBps = <10944000>;
+ };
+ opp-9 {
+ opp-peak-kBps = <12787200>;
+ };
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sc7280: Add support for two additional DDR frequencies
2025-07-01 7:43 [PATCH] arm64: dts: qcom: sc7280: Add support for two additional DDR frequencies Pushpendra Singh
@ 2025-07-01 7:56 ` Krzysztof Kozlowski
2025-07-03 9:45 ` Pushpendra Singh
2025-07-01 18:13 ` Trilok Soni
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-01 7:56 UTC (permalink / raw)
To: Pushpendra Singh, cros-qcom-dts-watchers, andersson, konradybcio,
robh, krzk+dt, conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: kernel
On 01/07/2025 09:43, Pushpendra Singh wrote:
> Cc: kernel@quicinc.com, kernel@oss.qualcomm.com
>
> The SC7280 SoC now supports two additional frequencies. This patch
> add those frequencies to the BWMON OPP table and updates the frequency
> mapping table accordingly.
>
> These changes do not impact existing platforms, as the updated mapping
> only affects the highest OPP. On any given platform, this will continue
> to vote for the maximum available OPP.
>
> Change-Id: Id3a91e065c49848d9af18e5c3edee0836cb693e5
> Signed-off-by: Pushpendra Singh <quic_pussin@quicinc.com>
Doesn't your internal guideline tell you to run checkpatch before sending?
Also it mentions many other things, so read entire guideline prior to
posting.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7280: Add support for two additional DDR frequencies
2025-07-01 7:56 ` Krzysztof Kozlowski
@ 2025-07-03 9:45 ` Pushpendra Singh
0 siblings, 0 replies; 5+ messages in thread
From: Pushpendra Singh @ 2025-07-03 9:45 UTC (permalink / raw)
To: Krzysztof Kozlowski, cros-qcom-dts-watchers, andersson,
konradybcio, robh, krzk+dt, conor+dt, linux-arm-msm, devicetree,
linux-kernel
On 7/1/2025 1:26 PM, Krzysztof Kozlowski wrote:
> On 01/07/2025 09:43, Pushpendra Singh wrote:
>> Cc: kernel@quicinc.com, kernel@oss.qualcomm.com
>>
>> The SC7280 SoC now supports two additional frequencies. This patch
>> add those frequencies to the BWMON OPP table and updates the frequency
>> mapping table accordingly.
>>
>> These changes do not impact existing platforms, as the updated mapping
>> only affects the highest OPP. On any given platform, this will continue
>> to vote for the maximum available OPP.
>>
>> Change-Id: Id3a91e065c49848d9af18e5c3edee0836cb693e5
>> Signed-off-by: Pushpendra Singh <quic_pussin@quicinc.com>
>
> Doesn't your internal guideline tell you to run checkpatch before sending?
>
> Also it mentions many other things, so read entire guideline prior to
> posting.
>
You're absolutely right, I should have run checkpatch before submitting. I appreciate you pointing that out. I've reviewed the internal guidelines more thoroughly now and will make sure to follow them closely in future submissions. Also, the issues are addressed in v2.
Thanks,
Pushpendra
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7280: Add support for two additional DDR frequencies
2025-07-01 7:43 [PATCH] arm64: dts: qcom: sc7280: Add support for two additional DDR frequencies Pushpendra Singh
2025-07-01 7:56 ` Krzysztof Kozlowski
@ 2025-07-01 18:13 ` Trilok Soni
2025-07-02 9:57 ` Pushpendra Singh
1 sibling, 1 reply; 5+ messages in thread
From: Trilok Soni @ 2025-07-01 18:13 UTC (permalink / raw)
To: Pushpendra Singh, cros-qcom-dts-watchers, andersson, konradybcio,
robh, krzk+dt, conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: kernel
On 7/1/2025 12:43 AM, Pushpendra Singh wrote:
> Cc: kernel@quicinc.com, kernel@oss.qualcomm.com
>
> The SC7280 SoC now supports two additional frequencies. This patch
> add those frequencies to the BWMON OPP table and updates the frequency
> mapping table accordingly.
>
> These changes do not impact existing platforms, as the updated mapping
> only affects the highest OPP. On any given platform, this will continue
> to vote for the maximum available OPP.
>
> Change-Id: Id3a91e065c49848d9af18e5c3edee0836cb693e5
Why Change-Id?
> Signed-off-by: Pushpendra Singh <quic_pussin@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 64a2abd30100..cb945abf0475 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -620,12 +620,12 @@ cpu4_opp_2208mhz: opp-2208000000 {
>
> cpu4_opp_2400mhz: opp-2400000000 {
> opp-hz = /bits/ 64 <2400000000>;
> - opp-peak-kBps = <8532000 48537600>;
> + opp-peak-kBps = <12787200 48537600>;
> };
>
> cpu4_opp_2611mhz: opp-2611200000 {
> opp-hz = /bits/ 64 <2611200000>;
> - opp-peak-kBps = <8532000 48537600>;
> + opp-peak-kBps = <12787200 48537600>;
> };
> };
>
> @@ -685,22 +685,22 @@ cpu7_opp_2381mhz: opp-2380800000 {
>
> cpu7_opp_2400mhz: opp-2400000000 {
> opp-hz = /bits/ 64 <2400000000>;
> - opp-peak-kBps = <8532000 48537600>;
> + opp-peak-kBps = <12787200 48537600>;
> };
>
> cpu7_opp_2515mhz: opp-2515200000 {
> opp-hz = /bits/ 64 <2515200000>;
> - opp-peak-kBps = <8532000 48537600>;
> + opp-peak-kBps = <12787200 48537600>;
> };
>
> cpu7_opp_2707mhz: opp-2707200000 {
> opp-hz = /bits/ 64 <2707200000>;
> - opp-peak-kBps = <8532000 48537600>;
> + opp-peak-kBps = <12787200 48537600>;
> };
>
> cpu7_opp_3014mhz: opp-3014400000 {
> opp-hz = /bits/ 64 <3014400000>;
> - opp-peak-kBps = <8532000 48537600>;
> + opp-peak-kBps = <12787200 48537600>;
> };
> };
>
> @@ -4013,6 +4013,12 @@ opp-6 {
> opp-7 {
> opp-peak-kBps = <8532000>;
> };
> + opp-8 {
> + opp-peak-kBps = <10944000>;
> + };
> + opp-9 {
> + opp-peak-kBps = <12787200>;
> + };
> };
> };
>
--
---Trilok Soni
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sc7280: Add support for two additional DDR frequencies
2025-07-01 18:13 ` Trilok Soni
@ 2025-07-02 9:57 ` Pushpendra Singh
0 siblings, 0 replies; 5+ messages in thread
From: Pushpendra Singh @ 2025-07-02 9:57 UTC (permalink / raw)
To: Trilok Soni, cros-qcom-dts-watchers, andersson, konradybcio, robh,
krzk+dt, conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: kernel
On 7/1/2025 11:43 PM, Trilok Soni wrote:
> On 7/1/2025 12:43 AM, Pushpendra Singh wrote:
>> Cc: kernel@quicinc.com, kernel@oss.qualcomm.com
>>
>> The SC7280 SoC now supports two additional frequencies. This patch
>> add those frequencies to the BWMON OPP table and updates the frequency
>> mapping table accordingly.
>>
>> These changes do not impact existing platforms, as the updated mapping
>> only affects the highest OPP. On any given platform, this will continue
>> to vote for the maximum available OPP.
>>
>> Change-Id: Id3a91e065c49848d9af18e5c3edee0836cb693e5
>
> Why Change-Id?
CC is a typo and fixed the Change-id in V2.
>> Signed-off-by: Pushpendra Singh <quic_pussin@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 18 ++++++++++++------
>> 1 file changed, 12 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 64a2abd30100..cb945abf0475 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -620,12 +620,12 @@ cpu4_opp_2208mhz: opp-2208000000 {
>>
>> cpu4_opp_2400mhz: opp-2400000000 {
>> opp-hz = /bits/ 64 <2400000000>;
>> - opp-peak-kBps = <8532000 48537600>;
>> + opp-peak-kBps = <12787200 48537600>;
>> };
>>
>> cpu4_opp_2611mhz: opp-2611200000 {
>> opp-hz = /bits/ 64 <2611200000>;
>> - opp-peak-kBps = <8532000 48537600>;
>> + opp-peak-kBps = <12787200 48537600>;
>> };
>> };
>>
>> @@ -685,22 +685,22 @@ cpu7_opp_2381mhz: opp-2380800000 {
>>
>> cpu7_opp_2400mhz: opp-2400000000 {
>> opp-hz = /bits/ 64 <2400000000>;
>> - opp-peak-kBps = <8532000 48537600>;
>> + opp-peak-kBps = <12787200 48537600>;
>> };
>>
>> cpu7_opp_2515mhz: opp-2515200000 {
>> opp-hz = /bits/ 64 <2515200000>;
>> - opp-peak-kBps = <8532000 48537600>;
>> + opp-peak-kBps = <12787200 48537600>;
>> };
>>
>> cpu7_opp_2707mhz: opp-2707200000 {
>> opp-hz = /bits/ 64 <2707200000>;
>> - opp-peak-kBps = <8532000 48537600>;
>> + opp-peak-kBps = <12787200 48537600>;
>> };
>>
>> cpu7_opp_3014mhz: opp-3014400000 {
>> opp-hz = /bits/ 64 <3014400000>;
>> - opp-peak-kBps = <8532000 48537600>;
>> + opp-peak-kBps = <12787200 48537600>;
>> };
>> };
>>
>> @@ -4013,6 +4013,12 @@ opp-6 {
>> opp-7 {
>> opp-peak-kBps = <8532000>;
>> };
>> + opp-8 {
>> + opp-peak-kBps = <10944000>;
>> + };
>> + opp-9 {
>> + opp-peak-kBps = <12787200>;
>> + };
>> };
>> };
>>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-07-03 9:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-01 7:43 [PATCH] arm64: dts: qcom: sc7280: Add support for two additional DDR frequencies Pushpendra Singh
2025-07-01 7:56 ` Krzysztof Kozlowski
2025-07-03 9:45 ` Pushpendra Singh
2025-07-01 18:13 ` Trilok Soni
2025-07-02 9:57 ` Pushpendra Singh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox