From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 957A7C761AF for ; Fri, 31 Mar 2023 14:24:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231508AbjCaOYr (ORCPT ); Fri, 31 Mar 2023 10:24:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232728AbjCaOYp (ORCPT ); Fri, 31 Mar 2023 10:24:45 -0400 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D05C710AA8 for ; Fri, 31 Mar 2023 07:24:43 -0700 (PDT) Received: by mail-il1-x12c.google.com with SMTP id n1so10848882ili.10 for ; Fri, 31 Mar 2023 07:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680272683; x=1682864683; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=KLTALbZ3iWI28OvY1+0nhMvm9XJ3QRjCWYBqsta0epY=; b=UEfsqds9SPT+VVyaRR2lyLk+gB8SnuhWaGL1k+gIPQxfo/3W75tA/g83to8hQEGqw9 pd5M/TXptL1kLZZoyd/mO23VsLEb+dLJezm6korh462D58rka4w0Fa3OvSaZ6+rNbuFH 1Xdm9k4icWYbzPoPN+c/7mtvXI4aZhI6fk/982YlvpekElzmgq3sHQn9PkuZsw+h8j4I ayhg59BWQVCPESfkD+KBRBhgRLShRMpS+81g6RgemMzx+VnU+vUHpmohP1dxzh/6ab4s gfCVQxDZYdd+9rPpD7froDdbjp8cEgg9u0yZzz0NERZQzFotGf23rkPKVXoR2sPRxmQC AgLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680272683; x=1682864683; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KLTALbZ3iWI28OvY1+0nhMvm9XJ3QRjCWYBqsta0epY=; b=pBgxCgym3umwHg3Um40cQgKxP7ulppascsCO3KxEq8k6nCKS0f+aqR11hEZHtigcT4 CNsUwJPsNwOIPNOxCn3/qW7CRYJCqA4ezcaeEt7HBni9bzxCiYSLpi4tvVKJbUbyonb5 qFS6kgdZAruEJjsfoQ444EoRDrRWBYeIEP6Qwovn6KwJGkmm/3MjhU1XoUTGfzyUV0sL V3lxvejMZuyQRP6lnfzy/TJwkuBlFS0QEq1zmNJS08Cw6e2oPjbOEeKkronbgbV9og6K 2hg/BLR6rxO39IP4dg+e9RYdH0UbwupKyIg6B0u76Fn9VUP3l+TNiP4MVaVY4i42zkUm OufQ== X-Gm-Message-State: AAQBX9d4UuGp1NOTHenbRY8uelU+0yMq/7cl46kjVxfpnw8TcsWp/UPO HF+Ec9jrV8tq87MRwQiyLkOkGw== X-Google-Smtp-Source: AKy350bit1MFzYAR/bHvDaXdvqv4ndlNkul2p0/ISTHL8LriewjkQbU4Hn+SvC5PTgM986/3Gqzhvg== X-Received: by 2002:a92:cb0a:0:b0:325:b32a:60fc with SMTP id s10-20020a92cb0a000000b00325b32a60fcmr13368695ilo.5.1680272683406; Fri, 31 Mar 2023 07:24:43 -0700 (PDT) Received: from [172.22.22.4] ([98.61.227.136]) by smtp.googlemail.com with ESMTPSA id n17-20020a056e02101100b0032648a86067sm515200ilj.4.2023.03.31.07.24.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 07:24:43 -0700 (PDT) Message-ID: Date: Fri, 31 Mar 2023 09:24:41 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Alex Elder Subject: Re: [PATCH v11 03/26] gunyah: Common types and error codes for Gunyah hypercalls To: Elliot Berman , Srinivas Kandagatla , Prakruthi Deepak Heragu Cc: Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Bagas Sanjaya , Will Deacon , Andy Gross , Catalin Marinas , Jassi Brar , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230304010632.2127470-1-quic_eberman@quicinc.com> <20230304010632.2127470-4-quic_eberman@quicinc.com> Content-Language: en-US In-Reply-To: <20230304010632.2127470-4-quic_eberman@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 3/3/23 7:06 PM, Elliot Berman wrote: > Add architecture-independent standard error codes, types, and macros for > Gunyah hypercalls. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Elliot Berman See a few comments below. -Alex > --- > include/linux/gunyah.h | 83 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 83 insertions(+) > create mode 100644 include/linux/gunyah.h > > diff --git a/include/linux/gunyah.h b/include/linux/gunyah.h > new file mode 100644 > index 000000000000..54b4be71caf7 > --- /dev/null > +++ b/include/linux/gunyah.h > @@ -0,0 +1,83 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +#ifndef _LINUX_GUNYAH_H > +#define _LINUX_GUNYAH_H > + > +#include > +#include > + > +/******************************************************************************/ > +/* Common arch-independent definitions for Gunyah hypercalls */ > +#define GH_CAPID_INVAL U64_MAX > +#define GH_VMID_ROOT_VM 0xff The above definition doesn't seem to be used anywhere, but seeing it begs the question to me of what type it is expected to have. If it were used, where would it be used in an 8 bit field? > + > +enum gh_error { > + GH_ERROR_OK = 0, > + GH_ERROR_UNIMPLEMENTED = -1, > + GH_ERROR_RETRY = -2, There might be nothing fundamentally wrong with this, but I dislike seeing negative values assigned to enums. These error values are returned from the hypervisor, and it looks like they'll likely truncated from a 64-bit unsigned value. Are they *sent* from the hypervisor as 64-bit signed values? Or 32-bit signed values? (In that case, the I just wonder if you can use 0xffffffff or 0xffff for example rather than -1, depending on the actual value that gets passed. > + > + GH_ERROR_ARG_INVAL = 1, > + GH_ERROR_ARG_SIZE = 2, > + GH_ERROR_ARG_ALIGN = 3, > + > + GH_ERROR_NOMEM = 10, > + > + GH_ERROR_ADDR_OVFL = 20, > + GH_ERROR_ADDR_UNFL = 21, > + GH_ERROR_ADDR_INVAL = 22, > + > + GH_ERROR_DENIED = 30, > + GH_ERROR_BUSY = 31, > + GH_ERROR_IDLE = 32, > + > + GH_ERROR_IRQ_BOUND = 40, > + GH_ERROR_IRQ_UNBOUND = 41, > + > + GH_ERROR_CSPACE_CAP_NULL = 50, > + GH_ERROR_CSPACE_CAP_REVOKED = 51, > + GH_ERROR_CSPACE_WRONG_OBJ_TYPE = 52, > + GH_ERROR_CSPACE_INSUF_RIGHTS = 53, > + GH_ERROR_CSPACE_FULL = 54, > + > + GH_ERROR_MSGQUEUE_EMPTY = 60, > + GH_ERROR_MSGQUEUE_FULL = 61, > +}; > + > +/** > + * gh_remap_error() - Remap Gunyah hypervisor errors into a Linux error code > + * @gh_error: Gunyah hypercall return value > + */ > +static inline int gh_remap_error(enum gh_error gh_error) Since you're remapping a gh_error, I would have named this gh_error_remap(). > +{ > + switch (gh_error) { > + case GH_ERROR_OK: > + return 0; > + case GH_ERROR_NOMEM: > + return -ENOMEM; > + case GH_ERROR_DENIED: > + case GH_ERROR_CSPACE_CAP_NULL: > + case GH_ERROR_CSPACE_CAP_REVOKED: > + case GH_ERROR_CSPACE_WRONG_OBJ_TYPE: > + case GH_ERROR_CSPACE_INSUF_RIGHTS: > + case GH_ERROR_CSPACE_FULL: > + return -EACCES; > + case GH_ERROR_BUSY: > + case GH_ERROR_IDLE: > + return -EBUSY; > + case GH_ERROR_IRQ_BOUND: > + case GH_ERROR_IRQ_UNBOUND: > + case GH_ERROR_MSGQUEUE_FULL: > + case GH_ERROR_MSGQUEUE_EMPTY: > + return -EIO; > + case GH_ERROR_UNIMPLEMENTED: > + case GH_ERROR_RETRY: > + return -EOPNOTSUPP; > + default: > + return -EINVAL; > + } > +} > + > +#endif