From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6054C46467 for ; Mon, 16 Jan 2023 09:19:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231872AbjAPJTE (ORCPT ); Mon, 16 Jan 2023 04:19:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232714AbjAPJSi (ORCPT ); Mon, 16 Jan 2023 04:18:38 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01F7218B33 for ; Mon, 16 Jan 2023 01:17:46 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id vw16so3407474ejc.12 for ; Mon, 16 Jan 2023 01:17:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ww7Hxrw6n0J7k//JManeo1d6RMBOH6s8LbvXGDtzj+w=; b=v5qDCDI2V1SvQnjE03DuLKYjo6tGrNOI1fmyfrbtX1bfPSDjMuEb6AkRNNQjQqF4w9 xvQA/XAhZyZU2S+cwiw5px7dPh6bGcR+xr6ngwFz5eeZXFQq5i9BbV7hirtq4T8QTrOJ 4hPL6DWur+wbtCguPVrmyHlClK3FNqe73Xvc3EDFkvIuCX9VLZhXiC8qbzyFAwlvPi12 AZXKsEJlsfb46On51cFyrW8NFIzom4xbLrii2c8cGPecK2Run3frV1V/pyOdDqs/qdwk WZqGxdYN+iUbvIBhL9SH0SnYV4aqeLBt8ThmSoPPW9TCZ4CRAwTB1bBAW2Ur3HV1UbxG tA1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ww7Hxrw6n0J7k//JManeo1d6RMBOH6s8LbvXGDtzj+w=; b=STn+Iia8wXFHhbqZbpzwZd0hFV3mehiXDxeveDOXUbOBohdHlgxBQwTisUcrT4xslG o3FOiXiWkl5pPVpm2mOHOokJLi9xpj33uIsoeZpw15XMsFoxiLkw2Vs7LpXJJg12XMof do+2QCJPVqR7MJQeXqcBQKNfK6HUDZbW9LkCy9fOC/6QvuPz9XazpSkTi9QAnnuEX18N O8Alz0xFL3LT1SfSRZco7jT3ZZNF/15aeJkjbgzwmw683n7wY/viV02nxaRSjHEllDCb atEobGiVRKYtkyjITBwEbHmatPNI7fOOt3y7ZnzX9ImUQCjcZRbI/onb7FgsQlwUU6vW 0Qug== X-Gm-Message-State: AFqh2kqCLnOrrTVCgD/eky2jJL5moRLcVmTR6dMOeu2zzFbnQwZN9tKj IfzSC7j77AGD0CLkGRMZdx06ag== X-Google-Smtp-Source: AMrXdXsKA+xBsKYbyxr+liaowz9b+i0Yta2/1SABcEZ2fAZj9G6NDYjCiRPwvXY9TodJyFWT6Ret/w== X-Received: by 2002:a17:906:4acc:b0:870:b53e:86b9 with SMTP id u12-20020a1709064acc00b00870b53e86b9mr2489239ejt.39.1673860665533; Mon, 16 Jan 2023 01:17:45 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id g13-20020a170906538d00b0085a958808c6sm6941007ejo.7.2023.01.16.01.17.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 01:17:45 -0800 (PST) Message-ID: Date: Mon, 16 Jan 2023 10:17:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RESEND v3 02/13] arm64: dts: mediatek: mt8195: add MDP3 nodes Content-Language: en-US To: =?UTF-8?B?TW91ZHkgSG8gKOS9leWul+WOnyk=?= , "matthias.bgg@gmail.com" , "mchehab@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-media@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , Project_Global_Chrome_Upstream_Group References: <20230116032147.23607-1-moudy.ho@mediatek.com> <20230116032147.23607-3-moudy.ho@mediatek.com> <63f3d41a-1aa3-396a-b515-bc805f4a19b4@linaro.org> <47f79e0ffda3fe72e574596aad8c4562a3b6e14a.camel@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <47f79e0ffda3fe72e574596aad8c4562a3b6e14a.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/01/2023 10:14, Moudy Ho (何宗原) wrote: >>> + mdp3-fg0@14002000 { >> >> Node names should be generic. >> > https://urldefense.com/v3/__https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html*generic-names-recommendation__;Iw!!CTRNKA9wMg0ARbw!gmuIIk9pHTEGcVTtOXNeP3a8XUucoiTd5vTmxNK8lCHtytRDc3R8Eh44WOWNEUkJlv_pPCtg_DvPCHsCHNscg6_0cfJe$  >> >> >> "0" suffix is definitely nothing generic. Drop such suffixes >> everywhere. >> Drop also "mdp3" prefix everywhere. >> >> >> Best regards, >> Krzysztof >> > > Hi Krzysztof, > > May I uniformly name all MediaTek's media data path ver.3(MDP3) nodes > as "mdp3@xxx"? No, because it does not describe generic class of a device. Some nodes are probably quite specific, thus we do not have generic names for them, but then any prefixes are also not neeeded. If node is image-scaler, it is just image-scaler, not "mdp3-image-scaler". If node is video-codec it is not mdp3-video-codec. etc. Best regards, Krzysztof