From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Subject: Re: [PATCH] fix ptr_ret.cocci warnings Date: Tue, 21 Mar 2017 15:07:26 +0000 Message-ID: References: <201703172233.osJjGFrP%fengguang.wu@intel.com> <1489607133-7870-3-git-send-email-olimpiu@arcticsand.com> <20170317144809.GA103304@lkp-hsx03.lkp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Olimpiu Dejeu , kbuild test robot , fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Cc: kbuild-all-JC7UmRfGjtg@public.gmane.org, Rob Herring , Lee Jones , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jingoohan1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Brian Dodge , joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org, Matthew D'Asaro List-Id: devicetree@vger.kernel.org On 21/03/17 14:58, Olimpiu Dejeu wrote: > On Fri, Mar 17, 2017 at 10:48 AM, kbuild test robot wrote: >> drivers/video/backlight/arcxcnn_bl.c:183:1-3: WARNING: PTR_ERR_OR_ZERO can be used >> >> >> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR >> >> Generated by: scripts/coccinelle/api/ptr_ret.cocci >> >> CC: Olimpiu Dejeu >> Signed-off-by: Fengguang Wu >> --- >> >> arcxcnn_bl.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> --- a/drivers/video/backlight/arcxcnn_bl.c >> +++ b/drivers/video/backlight/arcxcnn_bl.c >> @@ -180,10 +180,7 @@ static int arcxcnn_backlight_register(st >> >> lp->bl = devm_backlight_device_register(lp->dev, name, lp->dev, lp, >> &arcxcnn_bl_ops, props); >> - if (IS_ERR(lp->bl)) >> - return PTR_ERR(lp->bl); >> - >> - return 0; >> + return PTR_ERR_OR_ZERO(lp->bl); >> } >> >> static void arcxcnn_parse_dt(struct arcxcnn *lp) > > Acked-by: Olimpiu Dejeu Glad you approve! Could you apply this change and re-post the patch series? Thanks. Daniel. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html