From: Krzysztof Kozlowski <krzk@kernel.org>
To: Cristian Marussi <cristian.marussi@arm.com>,
"Rob Herring (Arm)" <robh@kernel.org>
Cc: etienne.carriere@st.com, Krzysztof Kozlowski <krzk+dt@kernel.org>,
d-gole@ti.com, linux-fsdevel@vger.kernel.org,
Conor Dooley <conor+dt@kernel.org>,
linux-doc@vger.kernel.org, f.fainelli@gmail.com,
vincent.guittot@linaro.org, philip.radford@arm.com,
souvik.chakravarty@arm.com, peng.fan@oss.nxp.com,
dan.carpenter@linaro.org, lukasz.luba@arm.com,
arm-scmi@vger.kernel.org, sudeep.holla@kernel.org,
michal.simek@amd.com, linux-kernel@vger.kernel.org,
jonathan.cameron@huawei.com, elif.topuz@arm.com,
linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com,
devicetree@vger.kernel.org, brauner@kernel.org
Subject: Re: [PATCH v3 06/24] dt-bindings: firmware: arm,scmi: Add support for telemetry protocol
Date: Mon, 30 Mar 2026 09:15:32 +0200 [thread overview]
Message-ID: <ea7cf74d-7b17-4b97-824f-d645b0a1a1ed@kernel.org> (raw)
In-Reply-To: <aclo1laTrsQFSan6@pluto>
On 29/03/2026 20:00, Cristian Marussi wrote:
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/firmware/arm,scmi.example.dtb: scmi (arm,scmi): protocol@19: Unevaluated properties are not allowed ('i2c2-pins', 'keys-pins', 'mdio-pins' were unexpected)
>> from schema $id: http://devicetree.org/schemas/firmware/arm,scmi.yaml
>>
>> doc reference errors (make refcheckdocs):
>>
>> See https://patchwork.kernel.org/project/devicetree/patch/20260329163337.637393-7-cristian.marussi@arm.com
>>
>> The base for the series is generally the latest rc1. A different dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>
> Yes...the new protocol block definition ended up intermixed with the
> previous protocol block...totally wrong.
This is not a problem. Problem was that you did not test it and sent
completely untested code to mailing list.
Add "RFC" prefix you subjects so we know that we can ignore the patchset
in the future.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-30 7:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260329163337.637393-1-cristian.marussi@arm.com>
2026-03-29 16:33 ` [PATCH v3 06/24] dt-bindings: firmware: arm,scmi: Add support for telemetry protocol Cristian Marussi
2026-03-29 17:31 ` Rob Herring (Arm)
2026-03-29 18:00 ` Cristian Marussi
2026-03-30 7:15 ` Krzysztof Kozlowski [this message]
2026-03-30 7:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea7cf74d-7b17-4b97-824f-d645b0a1a1ed@kernel.org \
--to=krzk@kernel.org \
--cc=arm-scmi@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=d-gole@ti.com \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=elif.topuz@arm.com \
--cc=etienne.carriere@st.com \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=jonathan.cameron@huawei.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=michal.simek@amd.com \
--cc=peng.fan@oss.nxp.com \
--cc=philip.radford@arm.com \
--cc=robh@kernel.org \
--cc=souvik.chakravarty@arm.com \
--cc=sudeep.holla@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox