From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vishwaroop A <va@nvidia.com>,
broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, thierry.reding@gmail.com,
jonathanh@nvidia.com, skomatineni@nvidia.com,
ldewangan@nvidia.com, kyarlagadda@nvidia.com,
smangipudi@nvidia.com, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: spi: nvidia,tegra210-quad: Add IOMMU property for Tegra234
Date: Tue, 6 May 2025 20:12:27 +0200 [thread overview]
Message-ID: <ea922410-d3e5-4406-9c16-3ac920caab89@kernel.org> (raw)
In-Reply-To: <20250506175813.3429319-1-va@nvidia.com>
On 06/05/2025 19:58, Vishwaroop A wrote:
> The Tegra210 Quad SPI controller uses internal DMA engines to efficiently transfer data between system memory and the SPI bus. On Tegra234 platform, DMA transactions must be properly mapped and protected through IOMMU to ensure system security and functional correctness. Tegra241 uses external DMA and doesn't require IOMMU.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
I don't think you read the review, just skimmed. I explained there how
to construct subject prefix and gave a link explaining it better.
Can you reach to your colleagues to help in upstreaming process to avoid
easy mistakes? Many companies have internal checklists or internal
guides helping in that...
>
> Add the iommus property to the device tree binding, making it required only for Tegra234 platform while explicitly disallowing it for other platforms including Tegra241.
Why requiring it for Tegra234? Do not explain what you did - we see it
easily. Explain what we do not see, so why you are breaking ABI.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-06 18:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 17:58 [PATCH v2] dt-bindings: spi: nvidia,tegra210-quad: Add IOMMU property for Tegra234 Vishwaroop A
2025-05-06 18:12 ` Krzysztof Kozlowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-05-06 18:08 Vishwaroop A
2025-05-06 18:14 ` Krzysztof Kozlowski
2025-05-14 19:01 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea922410-d3e5-4406-9c16-3ac920caab89@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=smangipudi@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=va@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox