From: Mark Brown <broonie@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
conor+dt@kernel.org, alim.akhtar@samsung.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, andre.draszik@linaro.org,
peter.griffin@linaro.org, semen.protsenko@linaro.org,
kernel-team@android.com, willmcvicker@google.com
Subject: Re: [PATCH 0/7] ARM: dts: samsung: specify the SPI fifosize
Date: Thu, 25 Jan 2024 15:53:08 +0000 [thread overview]
Message-ID: <eaa04bac-91dc-40e2-981d-e5f04f6ca19e@sirena.org.uk> (raw)
In-Reply-To: <20240125151630.753318-1-tudor.ambarus@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
On Thu, Jan 25, 2024 at 03:16:23PM +0000, Tudor Ambarus wrote:
> These patches close the circle and break the dependency between the SPI
> of_alias ID and the SPI driver. The SPI of_alias ID was used as an index
> into the fifo_lvl_mask to determine the FIFO depth of the SPI node.
> Changing the alias ID into the device tree would make the driver choose
> a wrong FIFO size configuration, if not accessing past the fifo_lvl_mask
> array boundaries. Not specifying an SPI alias would make the driver fail
> to probe, which was wrong too. Thus I updated the driver and I provided
Specifying a specific compatible is just good practice, it makes the DT
much more robust for when we discover new things about the hardware and
reduces the surface of the ABI.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-01-25 15:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 15:16 [PATCH 0/7] ARM: dts: samsung: specify the SPI fifosize Tudor Ambarus
2024-01-25 15:16 ` [PATCH 1/7] ARM: dts: samsung: s5pv210: " Tudor Ambarus
2024-01-25 15:16 ` [PATCH 2/7] ARM: dts: samsung: exynos3250: " Tudor Ambarus
2024-01-25 15:16 ` [PATCH 3/7] ARM: dts: samsung: exynos4: " Tudor Ambarus
2024-01-25 15:16 ` [PATCH 4/7] ARM: dts: samsung: exynos5250: " Tudor Ambarus
2024-01-25 15:16 ` [PATCH 5/7] ARM: dts: samsung: exynos5450: " Tudor Ambarus
2024-01-30 17:08 ` Henrik Grimler
2024-01-25 15:16 ` [PATCH 6/7] ARM: dts: samsung: exynos5433: " Tudor Ambarus
2024-01-25 15:16 ` [PATCH 7/7] ARM: dts: samsung: exynosautov9: " Tudor Ambarus
2024-01-25 15:53 ` Mark Brown [this message]
2024-01-25 15:56 ` [PATCH 0/7] ARM: dts: samsung: " Krzysztof Kozlowski
2024-02-01 10:33 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaa04bac-91dc-40e2-981d-e5f04f6ca19e@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox