From: Robert Marko <robimarko@gmail.com>
To: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Sricharan Ramabadhran <quic_srichara@quicinc.com>,
Anusha Rao <quic_anusha@quicinc.com>,
Devi Priya <quic_devipriy@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH RESEND 6/7] clk: qcom: apss-ipq6018: add the GPLL0 clock also as clock provider
Date: Sat, 9 Sep 2023 17:41:32 +0200 [thread overview]
Message-ID: <eaabca40-446d-effd-5d5f-f3e2618ff616@gmail.com> (raw)
In-Reply-To: <20230904-gpll_cleanup-v1-6-de2c448f1188@quicinc.com>
On 06. 09. 2023. 06:56, Kathiravan Thirumoorthy wrote:
> While the kernel is booting up, APSS PLL will be running at 800MHz with
> GPLL0 as source. Once the cpufreq driver is available, APSS PLL will be
> configured and select the rate based on the opp table and the source will
> be changed to APSS_PLL_EARLY.
>
> Without this patch, CPU Freq driver reports that CPU is running at 24MHz
> instead of the 800MHz.
>
> Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
I can confirm that this works on IPQ8074 as well, it now properly sees the
default CPU clock of 800MHz instead of XO rate.
Tested-by: Robert Marko <robimarko@gmail.com>
> ---
> drivers/clk/qcom/apss-ipq6018.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clk/qcom/apss-ipq6018.c b/drivers/clk/qcom/apss-ipq6018.c
> index f2f502e2d5a4..4e13a085a857 100644
> --- a/drivers/clk/qcom/apss-ipq6018.c
> +++ b/drivers/clk/qcom/apss-ipq6018.c
> @@ -20,16 +20,19 @@
>
> enum {
> P_XO,
> + P_GPLL0,
> P_APSS_PLL_EARLY,
> };
>
> static const struct clk_parent_data parents_apcs_alias0_clk_src[] = {
> { .fw_name = "xo" },
> + { .fw_name = "gpll0" },
> { .fw_name = "pll" },
> };
>
> static const struct parent_map parents_apcs_alias0_clk_src_map[] = {
> { P_XO, 0 },
> + { P_GPLL0, 4 },
> { P_APSS_PLL_EARLY, 5 },
> };
>
>
next prev parent reply other threads:[~2023-09-09 16:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 4:56 [PATCH RESEND 0/7] Add GPLL0 as clock provider for the Qualcomm's IPQ mailbox controller Kathiravan Thirumoorthy
2023-09-06 4:56 ` [PATCH RESEND 1/7] clk: qcom: ipq8074: drop the CLK_SET_RATE_PARENT flag from PLL clocks Kathiravan Thirumoorthy
2023-09-06 4:56 ` [PATCH RESEND 2/7] clk: qcom: ipq6018: " Kathiravan Thirumoorthy
2023-09-06 4:56 ` [PATCH RESEND 3/7] clk: qcom: ipq9574: drop the CLK_SET_RATE_PARENT flag from GPLL clocks Kathiravan Thirumoorthy
2023-09-06 4:56 ` [PATCH RESEND 4/7] clk: qcom: ipq5332: " Kathiravan Thirumoorthy
2023-09-06 4:56 ` [PATCH RESEND 5/7] dt-bindings: mailbox: qcom: add one more clock provider for IPQ mailbox Kathiravan Thirumoorthy
2023-09-06 8:06 ` Krzysztof Kozlowski
2023-09-06 4:56 ` [PATCH RESEND 6/7] clk: qcom: apss-ipq6018: add the GPLL0 clock also as clock provider Kathiravan Thirumoorthy
2023-09-09 15:41 ` Robert Marko [this message]
2023-09-11 10:26 ` Konrad Dybcio
2023-09-06 4:56 ` [PATCH RESEND 7/7] arm64: dts: qcom: include the GPLL0 as clock provider for IPQ mailbox Kathiravan Thirumoorthy
2023-09-06 9:33 ` Konrad Dybcio
2023-09-06 9:38 ` Kathiravan Thirumoorthy
2023-09-06 5:00 ` [PATCH RESEND 0/7] Add GPLL0 as clock provider for the Qualcomm's IPQ mailbox controller Kathiravan Thirumoorthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaabca40-446d-effd-5d5f-f3e2618ff616@gmail.com \
--to=robimarko@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_anusha@quicinc.com \
--cc=quic_devipriy@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).