From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52CF6CCA47C for ; Mon, 20 Jun 2022 13:10:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244520AbiFTNKh (ORCPT ); Mon, 20 Jun 2022 09:10:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245114AbiFTNIb (ORCPT ); Mon, 20 Jun 2022 09:08:31 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C56E21B7BC for ; Mon, 20 Jun 2022 06:01:42 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id o9so5773237edt.12 for ; Mon, 20 Jun 2022 06:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=tD9uUNT9XCLl71rBYEKigze1XhG3eLZdC6YZqfLDvzg=; b=BvQEWTHa4Iq1YBPiEICVFQd0aeeB3tGkxFn5lPUPTgkgrceHSOYPrAROHOGWWdMPEi 13VnmLoqusC3tD5yt4+1soGwUSzQWMpXWkWwHx17Rbj0+oa5tS2QuzISc65MiuUiKpDG qRSI2LJmI26nGTax3/hqjzIHGdO0XA4kS+mqHo0EWdMpdMTdcjSWn55OASJQtHABhWFX W6qjXtJ86BDGDVTW1RU59sxBdIxoMbwxcfXRlvW4+UT0aJuHNNKGscmdBCmta/uk8WSy DIgEGVRpzaRvswyyG2+LfH6ILLd0o/PZZcOL5RCLncEj0ircT7NnEC7Xn8Rc8aI+PN37 6Gew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tD9uUNT9XCLl71rBYEKigze1XhG3eLZdC6YZqfLDvzg=; b=aRx0ZjSgZZCeuRNOBvwdK62nxQI73Q+eee4QR2Ugz5isqI8M/Y4JKSKW2rgS35fVa/ 6nqxB/hQOY2w+pTDOsowQokKszHhvPvlH1hdIijtk1ANHfxYu0UKykztO8whiK9q1t0n loK8ok8pmRbguIKXQ6P6SRqb//Fwn9XpZN66EqW3YYaya5TwlE/5GVzFt95iXj4WRs9g u+shEdh9f39lv7SG4wDeck7HWTef512VOexlnQDo7EFMnSjksuiExxzKGK0Y+zNuLIbi OEnBOf8PpQ9L7gNrK/obovHCKV0ajagRPQO7BvdkJ2dz+taMAYP1j/Yyjb3yhmqzUxf8 NJEg== X-Gm-Message-State: AJIora+/aNMfdONGtAqzQGJcL+KU0sxXnChORGjap4Je4joJGde98YZk Bey/Mb7vP0ZLd0mTDR+LiBHL+A== X-Google-Smtp-Source: AGRyM1vW7T57TBehlpf2WN2b4z/6wROnJLNiUnGKA0BTpa7yikjOhmQJWvX3z5Qxz3LJ5QMdIe3mLQ== X-Received: by 2002:a05:6402:3329:b0:435:8136:cb70 with SMTP id e41-20020a056402332900b004358136cb70mr5587757eda.106.1655730050702; Mon, 20 Jun 2022 06:00:50 -0700 (PDT) Received: from [192.168.0.210] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id e27-20020a170906315b00b0071d3b6ed4eesm4758720eje.160.2022.06.20.06.00.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jun 2022 06:00:50 -0700 (PDT) Message-ID: Date: Mon, 20 Jun 2022 15:00:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5 07/15] dt-bindings: reset: amd,pensando-elbasr-reset: Add AMD Pensando SR Reset Controller bindings Content-Language: en-US To: Brad Larson , linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, alcooperx@gmail.com, andy.shevchenko@gmail.com, arnd@arndb.de, blarson@amd.com, brijeshkumar.singh@amd.com, catalin.marinas@arm.com, gsomlo@gmail.com, gerg@linux-m68k.org, krzk@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee.jones@linaro.org, broonie@kernel.org, yamada.masahiro@socionext.com, p.zabel@pengutronix.de, piotrs@cadence.com, p.yadav@ti.com, rdunlap@infradead.org, robh+dt@kernel.org, samuel@sholland.org, fancer.lancer@gmail.com, suravee.suthikulpanit@amd.com, thomas.lendacky@amd.com, ulf.hansson@linaro.org, will@kernel.org, devicetree@vger.kernel.org References: <20220613195658.5607-1-brad@pensando.io> <20220613195658.5607-8-brad@pensando.io> From: Krzysztof Kozlowski In-Reply-To: <20220613195658.5607-8-brad@pensando.io> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/06/2022 21:56, Brad Larson wrote: > From: Brad Larson > > Document bindings for AMD Pensando Elba SR Reset Controller > > Signed-off-by: Brad Larson > --- > .../reset/amd,pensando-elbasr-reset.yaml | 62 +++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > > diff --git a/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml b/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > new file mode 100644 > index 000000000000..03bb86ebcfd3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/amd,pensando-elbasr-reset.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AMD Pensando Elba SoC Reset Controller Device Tree Bindings Here and in all other patches: s/Device Tree Bindings// > + > +maintainers: > + - Brad Larson > + > +description: | > + AMD Pensando Elba SoC reset controller driver which supports a resource > + controller connected to the Elba SoC over a SPI bus. The Elba reset > + controller must be defined as a child node of the Elba SPI bus > + chip-select 0 node. > + > + See also: > + - dt-bindings/reset/amd,pensando-elba-reset.h > + > +properties: > + $nodename: > + pattern: "^reset-controller@[0-9a-f]+$" Skip the pattern. No particular need for it and unit address part is not correct (const: 0). > + > + compatible: > + const: amd,pensando-elbasr-reset > + > + reg: > + const: 0 > + > + '#reset-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + - '#reset-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include Missing file: ls: cannot access 'include/dt-bindings/reset/amd,pensando-elba-reset.h': No such file or directory Send complete bindings, not parts of it. Did you test it? I am pretty sure that this did not happen. :( > + spi0 { spi > + #address-cells = <1>; > + #size-cells = <0>; > + num-cs = <4>; > + > + spi@0 { > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + rstc: reset-controller@0 { > + compatible = "amd,pensando-elbasr-reset"; > + reg = <0>; > + #reset-cells = <1>; > + }; > + }; > + }; > + > +... Best regards, Krzysztof