From: Jakob Hauser <jahau@rocketmail.com>
To: Jessica Zhang <quic_jesszhan@quicinc.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 2/4] drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver
Date: Fri, 11 Oct 2024 21:42:07 +0200 [thread overview]
Message-ID: <eaf1994a-a85d-4dcd-b729-2dba8354e8cc@rocketmail.com> (raw)
In-Reply-To: <6d67c2c6-819b-481a-8cc9-e24ef8f6c142@quicinc.com>
Hi Jessica,
On 11.10.24 18:52, Jessica Zhang wrote:
>
>
> On 10/10/2024 11:31 AM, Jakob Hauser wrote:
...
>> +struct s6e88a0_ams427ap24 {
>> + struct drm_panel panel;
>> + struct mipi_dsi_device *dsi;
>> + struct regulator_bulk_data *supplies;
>> + struct gpio_desc *reset_gpio;
>> + bool prepared;
>
> Hi Jakob,
>
> I think you can drop the `prepared` here as it should be handled by
> framework now [1]
>
> Thanks,
>
> Jessica Zhang
>
> [1]
> https://elixir.bootlin.com/linux/v6.11.3/source/include/drm/drm_panel.h#L262
>
>> +};
Thanks for the hint. I'll change that in v2.
...
Kind regards,
Jakob
next prev parent reply other threads:[~2024-10-11 19:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1728582727.git.jahau.ref@rocketmail.com>
2024-10-10 18:31 ` [PATCH 0/4] Add new panel driver Samsung S6E88A0-AMS427AP24 Jakob Hauser
2024-10-10 18:31 ` [PATCH 1/4] dt-bindings: display: panel: Add Samsung S6E88A0-AMS427AP24 bindings Jakob Hauser
2024-10-11 14:27 ` Rob Herring
2024-10-11 19:38 ` Jakob Hauser
2024-10-10 18:31 ` [PATCH 2/4] drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver Jakob Hauser
2024-10-11 16:52 ` Jessica Zhang
2024-10-11 19:42 ` Jakob Hauser [this message]
2024-10-10 18:31 ` [PATCH 3/4] drm/panel: samsung-s6e88a0-ams427ap24: Add brightness control Jakob Hauser
2024-10-10 18:31 ` [PATCH 4/4] drm/panel: samsung-s6e88a0-ams427ap24: Add flip option Jakob Hauser
2024-10-11 17:17 ` Jessica Zhang
2024-10-11 19:58 ` Jakob Hauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaf1994a-a85d-4dcd-b729-2dba8354e8cc@rocketmail.com \
--to=jahau@rocketmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).