From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Wesley Cheng <wcheng@codeaurora.org>,
sboyd@kernel.org, heikki.krogerus@linux.intel.com,
agross@kernel.org, robh+dt@kernel.org,
gregkh@linuxfoundation.org, bjorn.andersson@linaro.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v8 4/4] arm64: boot: dts: qcom: pm8150b: Add DTS node for PMIC VBUS booster
Date: Thu, 20 Aug 2020 12:06:23 +0300 [thread overview]
Message-ID: <eaf4618c-54da-c522-52c6-1edec7744872@gmail.com> (raw)
In-Reply-To: <02111c69-73fd-5e8c-5594-27393865d458@codeaurora.org>
On 20.08.2020 10:47, Wesley Cheng wrote:
[...]
>>> Add the required DTS node for the USB VBUS output regulator, which is
>>> available on PM8150B. This will provide the VBUS source to connected
>>> peripherals.
>>>
>>> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
>>> ---
>>> arch/arm64/boot/dts/qcom/pm8150b.dtsi | 6 ++++++
>>> arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 4 ++++
>>> 2 files changed, 10 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi
>>> b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
>>> index 053c659734a7..9e560c1ca30d 100644
>>> --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
>>> @@ -53,6 +53,12 @@ power-on@800 {
>>> status = "disabled";
>>> };
>>> + pm8150b_vbus: dcdc@1100 {
>>
>> s/dcdc/regulator/? What is "dcdc", anyway?
>> The device nodes must have the generic names, according to the DT spec.
>>
>
> Hi Sergei,
>
> Thanks for the comment!
You're welcome.
> DCDC is the label that we use for the DC to DC converter block, since
> the VBUS booster will output 5V to the connected devices. Would it make
> more sense to have "dc-dc?"
Better use s/th like "regulator-dcdc". As I said, the names should be
generic, reflecting the device class.
> Thanks
> Wesley
>
>>> + compatible = "qcom,pm8150b-vbus-reg";
>>> + status = "disabled";
>>> + reg = <0x1100>;
>>> + };
>>> +
>>> pm8150b_typec: typec@1500 {
>>> compatible = "qcom,pm8150b-usb-typec";
>>> status = "disabled";
>> [...]
MBR, Sergei
next prev parent reply other threads:[~2020-08-20 9:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 7:19 [PATCH v8 0/4] Introduce PMIC based USB type C detection Wesley Cheng
2020-08-12 7:19 ` [PATCH v8 1/4] usb: typec: Add QCOM PMIC typec detection driver Wesley Cheng
2020-08-30 18:54 ` Bjorn Andersson
2020-09-03 21:46 ` Wesley Cheng
2020-08-12 7:19 ` [PATCH v8 2/4] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding Wesley Cheng
2020-08-12 16:50 ` Rob Herring
2020-08-12 7:19 ` [PATCH v8 3/4] arm64: boot: dts: qcom: pm8150b: Add node for USB type C block Wesley Cheng
2020-08-30 18:55 ` Bjorn Andersson
2020-08-12 7:19 ` [PATCH v8 4/4] arm64: boot: dts: qcom: pm8150b: Add DTS node for PMIC VBUS booster Wesley Cheng
2020-08-12 9:34 ` Sergei Shtylyov
2020-08-20 7:47 ` Wesley Cheng
2020-08-20 9:06 ` Sergei Shtylyov [this message]
2020-08-30 17:52 ` Bjorn Andersson
2020-09-03 21:50 ` Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaf4618c-54da-c522-52c6-1edec7744872@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).