From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F2BCCA473 for ; Fri, 24 Jun 2022 17:18:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229928AbiFXRSA (ORCPT ); Fri, 24 Jun 2022 13:18:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229936AbiFXRR7 (ORCPT ); Fri, 24 Jun 2022 13:17:59 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BA1FE9B for ; Fri, 24 Jun 2022 10:17:57 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id e2so4412667edv.3 for ; Fri, 24 Jun 2022 10:17:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=QO2xbsZ3DwvoKI/D5PILJK1SdhtLthoBmyVWXf1LehI=; b=riSm0FlJgfp0dBXID4v2NQTo8SOXgPflsvQMGoR86iK28ba4yxmwUwoptM5dWWwqiK l92EzP4jSf90Vr6x5ir0jYK5+FZ4heKpnbMunI96UycBMM/+hJ215k0q1ix6PoOI2thy lF0Wa4WLjnysW1sJOztWQ+P7JfqPzrCtfa7vIQVND31KXECN2mFIKtRLXEmjAht+RmTi YCgR9I+Q1NnYWY0f23VoAhWfs5dezqTksdH8IFWUG4gdSQjTNv8d9dn1JHcvhEhfCxI3 aXbV6F/rzDH7S+weQyW9AQPMaB8I7rhhDZ6oT43UElcY5k5ZXd95jkJ9AVsarenT5E4O bzKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=QO2xbsZ3DwvoKI/D5PILJK1SdhtLthoBmyVWXf1LehI=; b=j2ousIA4P54pepBTv95mA8Kc3vN2GN01Iw52pUqdYVkrTb1OAHesYQ/xxCwnz5KnJb gN9ys6OciRSfLI8rSL4zaR8e0RHXDAl0KYBe96DEbZ+4Zy5TOgUyWGumP9h6PSFPxJCB 5hE3qW87ka001Oid/tRBHV8MZg/9dOwBGmy0G9dAV/YDo/cEmigNbUf9MDWVBiLTJlyB Ghei6PKyOw9pOFITDRbgPe5vxMHTtdSeKEqLKkR/QRi4VseXPqA6F/crGMhHfhGStjYQ 1w6EP7P/Ik3CioDK6Qy6ipHwrbiK4BMLZLrmG2ShFiq1EPrfABNyy5bqqndvspPLuApV 8plw== X-Gm-Message-State: AJIora8rIRCTrOSA5EZ4cF1P5pVbqHQrIeZohyI6TRoic+z7LJlF0xC4 COYQ4OikY1XXw1gyGUF3Nl7UeA== X-Google-Smtp-Source: AGRyM1vVErSqX7pCRC/e1QSjDBJkieHwm2TXbOHt/piwTVUPc3SDtWWTG3XRwFKOkHtmw9wUqQ2Gfw== X-Received: by 2002:aa7:c45a:0:b0:435:d7a4:99bc with SMTP id n26-20020aa7c45a000000b00435d7a499bcmr168035edr.158.1656091075738; Fri, 24 Jun 2022 10:17:55 -0700 (PDT) Received: from [192.168.0.237] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id z4-20020a1709060f0400b00722f069fd40sm1411264eji.159.2022.06.24.10.17.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jun 2022 10:17:55 -0700 (PDT) Message-ID: Date: Fri, 24 Jun 2022 19:17:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH RESEND v9 5/5] arm64: dts: apm: Harmonize DWC USB3 DT nodes name Content-Language: en-US To: Serge Semin , Andy Gross , Bjorn Andersson , Felipe Balbi , Michael Ellerman , Vladimir Zapolskiy , Alexey Brodkin , Vineet Gupta , Rob Herring , Rob Herring , Greg Kroah-Hartman , Krzysztof Kozlowski , linux-usb@vger.kernel.org, Khuong Dinh , Krzysztof Kozlowski Cc: Serge Semin , Patrice Chotard , Benjamin Herrenschmidt , Paul Mackerras , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220624141622.7149-1-Sergey.Semin@baikalelectronics.ru> <20220624141622.7149-6-Sergey.Semin@baikalelectronics.ru> From: Krzysztof Kozlowski In-Reply-To: <20220624141622.7149-6-Sergey.Semin@baikalelectronics.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/06/2022 16:16, Serge Semin wrote: > In accordance with the DWC USB3 bindings the corresponding node > name is suppose to comply with the Generic USB HCD DT schema, which > requires the USB nodes to have the name acceptable by the regexp: > "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly > named despite of the warning comment about possible backward > compatibility issues. Sometimes node name is exposed to user-space which depends on it. How did you check there is no issue here? > > Signed-off-by: Serge Semin > Acked-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++-- > arch/arm64/boot/dts/apm/apm-storm.dtsi | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi > index a83c82c50e29..832dd85b00bd 100644 > --- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi > +++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi > @@ -597,8 +597,8 @@ serial0: serial@10600000 { > interrupts = <0x0 0x4c 0x4>; > }; > > - /* Do not change dwusb name, coded for backward compatibility */ > - usb0: dwusb@19000000 { > + /* Node-name might need to be coded as dwusb for backward compatibility */ > + usb0: usb@19000000 { > status = "disabled"; > compatible = "snps,dwc3"; > reg = <0x0 0x19000000 0x0 0x100000>; > diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi > index 0f37e77f5459..1520a945b7f9 100644 > --- a/arch/arm64/boot/dts/apm/apm-storm.dtsi > +++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi > @@ -923,8 +923,8 @@ sata3: sata@1a800000 { > phy-names = "sata-phy"; > }; > > - /* Do not change dwusb name, coded for backward compatibility */ > - usb0: dwusb@19000000 { > + /* Node-name might need to be coded as dwusb for backward compatibility */ > + usb0: usb@19000000 { > status = "disabled"; > compatible = "snps,dwc3"; > reg = <0x0 0x19000000 0x0 0x100000>; > @@ -933,7 +933,7 @@ usb0: dwusb@19000000 { > dr_mode = "host"; > }; > > - usb1: dwusb@19800000 { > + usb1: usb@19800000 { > status = "disabled"; > compatible = "snps,dwc3"; > reg = <0x0 0x19800000 0x0 0x100000>; Best regards, Krzysztof