From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "J, KEERTHY" <j-keerthy@ti.com>,
robh+dt@kernel.org, daniel.lezcano@linaro.org,
rui.zhang@intel.com, amitk@kernel.org, kristo@kernel.org,
vigneshr@ti.com
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/4] dt-bindings: thermal: k3-j72xx: Add VTM bindings documentation
Date: Mon, 9 May 2022 08:42:34 +0200 [thread overview]
Message-ID: <eb0745a6-ecf2-4b70-368b-9ad8a322f208@linaro.org> (raw)
In-Reply-To: <5859fed0-82b7-95eb-5719-9b0016916c50@ti.com>
On 09/05/2022 05:18, J, KEERTHY wrote:
>
>
> On 4/27/2022 12:16 PM, Keerthy wrote:
>> Add VTM bindings documentation. In the Voltage Thermal
>> Management Module(VTM), K3 J72XX supplies a voltage
>> reference and a temperature sensor feature that are gathered in the band
>> gap voltage and temperature sensor (VBGAPTS) module. The band
>> gap provides current and voltage reference for its internal
>> circuits and other analog IP blocks. The analog-to-digital
>> converter (ADC) produces an output value that is proportional
>> to the silicon temperature.
>
> Hi krzysztof,
>
> Any comments on this version?
You got Rob's review, so you don't need also mine.
If you want, then in general look okay, except the description for "reg"
you could split per items:
reg:
items:
- description: VTM cfg1 register space
- description: VTM cfg2 register space
- description: efuse register space
It's more obvious what items you expect.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-09 6:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 6:46 [PATCH v6 0/4] thermal: k3_j72xx_bandgap: Add the bandgap driver support Keerthy
2022-04-27 6:46 ` [PATCH v6 1/4] dt-bindings: thermal: k3-j72xx: Add VTM bindings documentation Keerthy
2022-05-03 0:34 ` Rob Herring
2022-05-09 3:18 ` J, KEERTHY
2022-05-09 6:42 ` Krzysztof Kozlowski [this message]
2022-05-11 7:53 ` J, KEERTHY
2022-05-11 8:15 ` Krzysztof Kozlowski
2022-05-11 10:57 ` J, KEERTHY
2022-04-27 6:46 ` [PATCH v6 2/4] arm64: dts: ti: j721e: Add VTM node Keerthy
2022-04-27 6:46 ` [PATCH v6 3/4] arm64: dts: ti: j7200: " Keerthy
2022-04-27 6:46 ` [PATCH v6 4/4] thermal: k3_j72xx_bandgap: Add the bandgap driver support Keerthy
2022-05-04 8:00 ` Dan Carpenter
2022-05-09 5:20 ` Joe Perches
2022-05-09 3:10 ` J, KEERTHY
2022-05-10 15:25 ` Daniel Lezcano
2022-05-10 17:17 ` J, KEERTHY
2022-05-10 17:38 ` Daniel Lezcano
2022-05-11 4:57 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb0745a6-ecf2-4b70-368b-9ad8a322f208@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=kristo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).