From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75477C433FE for ; Mon, 9 May 2022 06:48:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229556AbiEIGue (ORCPT ); Mon, 9 May 2022 02:50:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233370AbiEIGqc (ORCPT ); Mon, 9 May 2022 02:46:32 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F18D8131F22 for ; Sun, 8 May 2022 23:42:37 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id y21so15083181edo.2 for ; Sun, 08 May 2022 23:42:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=uJOQksv/Nz7S6hCUok26zJ6fKbWWbQlYtjVxm6ipB6o=; b=rPQ7B5yo6cD6nD6lgS4qglTb9gjR27VlU5Ie1sQOZvcSpF+l8ZfE8rPTipH7OnrLRK zhl/da1BJmVs4UzWOoHQq6rfRV2XWth6NfQnge+zDf39c3wMYvt1OeqnHeN7r0o1UR1m 3b8x61LfsD5eo7AaltIOGOU7E70FHi+WRldTtz3+cIFQ14L0VeF6pvgMyPY5QFAGft5T vRYCmHluuHCvORXc6DVO2wxAi7voI9im5N0w1/xfY9cxNkkeDKRnPQs3tzCwXOzrQZHz YZtcXokO7fX+orSZXTie6NyyOS/8Nx4+zoOCpBv3SeLgQDkstwJILvL55tnoWBNtUPyJ SKCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=uJOQksv/Nz7S6hCUok26zJ6fKbWWbQlYtjVxm6ipB6o=; b=D/j0AS+5I/ZUm0OrC26eBuQQiSvgvCnR0EdeTQaRe0fOLbqRgCpeVo3VWBO+F3zbyL mCWtRe2olb4ahovOGw6kPXRa5dIv52u0vOcUtY6Um6E2a52wCVPaFZ4wVIfLNPbZQDWV WGHCdW8awG6hAJk592bEzZrxuGPpYqF+7Z4pBCYqeJx26cwYhXrr7sCYwOGiAXAS4Rdd K2x2+rmZXnG2oALhW+sEjh9lwUCdYsJotKfsAPDYX0MAjmgo3Hpj+A9KGfki9C+RLfC2 lPBBae0Gy9NJfC0csgFMEJ3TUphLf5t/kF7MnHF2ppheYQ1Lpnf9HIckfgEFCwLMHRJZ S5CQ== X-Gm-Message-State: AOAM53391buO3+rt4PmbG+WtgiypkYBqe6uUvA7LxCK28BSaeOng2DUB ovTkZb1ZCa6YIv1ysmKcq1wlaA== X-Google-Smtp-Source: ABdhPJxtgRhW3ZJj9MbSV+/lI8mw0cEll+Lr/P1aCjNSFND2BqVyrj1DygJfs/9L3aylDRAqiVBMVA== X-Received: by 2002:a05:6402:289a:b0:425:d682:105d with SMTP id eg26-20020a056402289a00b00425d682105dmr16072838edb.175.1652078556379; Sun, 08 May 2022 23:42:36 -0700 (PDT) Received: from [192.168.0.242] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id cn18-20020a0564020cb200b0042617ba639esm5764601edb.40.2022.05.08.23.42.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 May 2022 23:42:35 -0700 (PDT) Message-ID: Date: Mon, 9 May 2022 08:42:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v6 1/4] dt-bindings: thermal: k3-j72xx: Add VTM bindings documentation Content-Language: en-US To: "J, KEERTHY" , robh+dt@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, amitk@kernel.org, kristo@kernel.org, vigneshr@ti.com Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220427064635.24898-1-j-keerthy@ti.com> <20220427064635.24898-2-j-keerthy@ti.com> <5859fed0-82b7-95eb-5719-9b0016916c50@ti.com> From: Krzysztof Kozlowski In-Reply-To: <5859fed0-82b7-95eb-5719-9b0016916c50@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/05/2022 05:18, J, KEERTHY wrote: > > > On 4/27/2022 12:16 PM, Keerthy wrote: >> Add VTM bindings documentation. In the Voltage Thermal >> Management Module(VTM), K3 J72XX supplies a voltage >> reference and a temperature sensor feature that are gathered in the band >> gap voltage and temperature sensor (VBGAPTS) module. The band >> gap provides current and voltage reference for its internal >> circuits and other analog IP blocks. The analog-to-digital >> converter (ADC) produces an output value that is proportional >> to the silicon temperature. > > Hi krzysztof, > > Any comments on this version? You got Rob's review, so you don't need also mine. If you want, then in general look okay, except the description for "reg" you could split per items: reg: items: - description: VTM cfg1 register space - description: VTM cfg2 register space - description: efuse register space It's more obvious what items you expect. Best regards, Krzysztof