From: Mark Brown <broonie@kernel.org>
To: samuel.kayode@savoirfairelinux.com
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, linux-pm@vger.kernel.org,
Abel Vesa <abelvesa@kernel.org>, Abel Vesa <abelvesa@linux.com>,
Robin Gong <b38343@freescale.com>,
Enric Balletbo i Serra <eballetbo@gmail.com>
Subject: Re: [PATCH v4 3/6] regulator: pf1550: add support for regulator
Date: Wed, 4 Jun 2025 12:35:21 +0100 [thread overview]
Message-ID: <eb1fb4e2-42aa-4795-bc6c-dbcf1fa04f11@sirena.org.uk> (raw)
In-Reply-To: <20250603-pf1550-v4-3-bfdf51ee59cc@savoirfairelinux.com>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
On Tue, Jun 03, 2025 at 02:27:47PM -0400, Samuel Kayode via B4 Relay wrote:
> +static int pf1550_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
> +{
> + int id = rdev_get_id(rdev);
> + unsigned int ramp_bits = 0;
> + int ret;
> +
> + if (id > PF1550_VREFDDR)
> + return -EACCES;
> +
> + if (ramp_delay > 0) {
> + ramp_delay = 6250 / ramp_delay;
> + ramp_bits = ramp_delay >> 1;
> + }
I'm not seeing validation of the maximum ramp_delay value here?
> + switch (irq_type) {
> + case PF1550_PMIC_IRQ_SW1_LS:
> + event = REGULATOR_EVENT_OVER_CURRENT;
> + case PF1550_PMIC_IRQ_SW1_HS:
> + event = REGULATOR_EVENT_OVER_CURRENT;
> + case PF1550_PMIC_IRQ_LDO1_FAULT:
> + event = REGULATOR_EVENT_OVER_CURRENT;
You appear to be flagging all these events as over current events which
doesn't seem entirely plausible.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-06-04 11:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 18:27 [PATCH v4 0/6] add support for pf1550 PMIC MFD-based drivers Samuel Kayode via B4 Relay
2025-06-03 18:27 ` [PATCH v4 1/6] dt-bindings: mfd: add pf1550 Samuel Kayode via B4 Relay
2025-06-04 6:47 ` Krzysztof Kozlowski
2025-06-03 18:27 ` [PATCH v4 2/6] mfd: pf1550: add core mfd driver Samuel Kayode via B4 Relay
2025-06-04 14:19 ` Mark Brown
2025-06-03 18:27 ` [PATCH v4 3/6] regulator: pf1550: add support for regulator Samuel Kayode via B4 Relay
2025-06-04 11:35 ` Mark Brown [this message]
2025-06-04 14:03 ` Samuel Kayode
2025-06-04 14:25 ` Mark Brown
2025-06-04 14:48 ` Samuel Kayode
2025-06-03 18:27 ` [PATCH v4 4/6] input: pf1550: add onkey support Samuel Kayode via B4 Relay
2025-06-03 18:27 ` [PATCH v4 5/6] power: supply: pf1550: add battery charger support Samuel Kayode via B4 Relay
2025-06-03 18:27 ` [PATCH v4 6/6] MAINTAINERS: add an entry for pf1550 mfd driver Samuel Kayode via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb1fb4e2-42aa-4795-bc6c-dbcf1fa04f11@sirena.org.uk \
--to=broonie@kernel.org \
--cc=abelvesa@kernel.org \
--cc=abelvesa@linux.com \
--cc=b38343@freescale.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eballetbo@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=samuel.kayode@savoirfairelinux.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).