From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA3FC269AFB for ; Mon, 25 Aug 2025 12:01:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756123289; cv=none; b=SzjromJ5anulUEITpqDV0uWo3tux5Rjk4jfWSnVr0oe8EkxdVlzQ6Udj3UihbbVHrIvrwR3579S3qnN4+i2aAyT6YRYycYXPSQ0W6ZeUfwxbW+3l/PSl1s3XA3t9QPQPSvT8LN1fb91+PFllbL3BXOQmrYlp7BOp9lVK4uP288s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756123289; c=relaxed/simple; bh=RFnXtMO9EySymNwVyAhdrrY0RQvFJ6yjd44teuvucr4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eP9ptryntmhAtRjWpOU/mfIF/4VYmnxQ1Xy+vRmWKM9DvYKv/4wy391TDkpFrZzdEux9qIXscscPny7ogwBgyx+I4BnoiE/v/f6uMUlMDYT9YkMxsWuiTJr4Qpy5Ts0rTm+OwvRzJfMnPHhFt6d2LdHi/9ggSSHvU+5pvVyCbFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YRtzrO/j; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YRtzrO/j" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-45a20c51c40so34203545e9.3 for ; Mon, 25 Aug 2025 05:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756123286; x=1756728086; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rRcckAhyKKIfk/Fgtz+kopwNbFInJmosFYKCEYbjFWg=; b=YRtzrO/jDKlz3r0pEj/sMPXB4DkzBkCQUs4Hmwo6OqzT8RueL3ftkhhQZpFlICsVrB sFXHrKq42Bo7RD5vsmWC8AToIzNUd0rk3lN8NrlFcc2ng0RRC6PudrifMGzEGg1YR5Qj 6awUXTqk5M2lTDF7MvowAAJeXkf2kMw1r8fMCdBY/NP5Rq4UiecJUmVJhjDdI4P+fv7I 5Pg22tUzVkRdjncv2ypuCHcVcJLc2FUnt9xFUbKu38jK5FocEHxuItIM/NlNrLIIs6nt FDuLHa6mgyUqTSTMw1sQTTzXxRgINKXkBN2wXUeJnQUScZzxFOVvhcgk/IxGg4xphdgb AmXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756123286; x=1756728086; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rRcckAhyKKIfk/Fgtz+kopwNbFInJmosFYKCEYbjFWg=; b=i1lV+haoGBb5zUp/wmD7Yw20Q+UALDBpVccupGZfdHXeGlAyZuKLqxse0/UHq0L+aV dcht6Sgr/2jsEY44jLbERxefOlrAiEIooV76XncsciHDz5F0o/J2/k3YIFDgR2EJo5eG Cl7xqZi+1j2NeGcMOr4SJrEPox4or3r+xCMS2nLPE22NxnGpL4sU0D7SbJNgckuxVXtZ /He/IiZPk637aico7nbeQVIU0lgzDpZAqABENtn35FzGAjE980HnOF6Ti7YprszK/f88 DuBrd5hgHwY/0sLX3dQt7r7KryfUSkgyEZuXUq5zENHWnWlqc05h2//5RRyv7TGKeLj4 bTqQ== X-Forwarded-Encrypted: i=1; AJvYcCVUy9T5p7Q5iBbwH+5mL6Un4aQS1EMYhDacA+d99bK7Y8DuNePotVeW+b28A9cVT9j/+r9FcWCQCz3q@vger.kernel.org X-Gm-Message-State: AOJu0Yzcx0WqSYT+EKCUZl/kGTKIz0A/5CJfXAk44nZ1G566fLLeSsp2 3cgS1JzwVWDfbhn1RYkoB4193MEfdVP0aI8Wq97hyf3CDyimOnEZ+TECm3mgnm8LC6A= X-Gm-Gg: ASbGnctau68cDkB+/AIo3y4vKpYKzfQQioZuVtUaSgJ3bkHlI7Mc/H0obYisVmHC11x K+h7jELifvj1xwZjG+8yH/AIL7e0NHkGwhLROeTkQuJlKin2iT+ceDfquMB3VdwToFbsh1ROIn9 FUbRVtF3KtMxWuGtzzOwC6zXUHXw08+krSzhCFRLnhejL3AMljckDyGVWTp9+XQZaclztkFvSv6 N6E5gq5yWR9v7l7j57jZBgka5ke83b2FKdbyJf6iA8lI9JJ72RWUUiPqn2aJ6nBihAOhf9ZKl5l 5CwHtLPWmYFzMR4oVJRh5d0FkPatneFnu6CaIrNRYu5Hn1C/pp98m6i+UvUrUVTRQU4KJs3N1nm 3lPJkpFV3TkpCn88yrYe0C32NiD2tLSg= X-Google-Smtp-Source: AGHT+IH62AfWArXNyegFI8zsNyQcP9qoQacs5w+PUV6JSw51oEdiaFXWL4IPdH3vJ0s3i8QgSe1+bQ== X-Received: by 2002:a05:600c:3590:b0:459:a1c7:99ad with SMTP id 5b1f17b1804b1-45b6133ff14mr19383645e9.22.1756123286249; Mon, 25 Aug 2025 05:01:26 -0700 (PDT) Received: from [192.168.0.251] ([82.76.204.34]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b6300da81sm19978265e9.23.2025.08.25.05.01.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Aug 2025 05:01:25 -0700 (PDT) Message-ID: Date: Mon, 25 Aug 2025 13:01:23 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: firmware: google,gs101-acpm-ipc: add clocks node To: Krzysztof Kozlowski , Rob Herring Cc: Krzysztof Kozlowski , Conor Dooley , Peter Griffin , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Michael Turquette , Stephen Boyd , Alim Akhtar , Sylwester Nawrocki , Chanwoo Choi , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, willmcvicker@google.com, kernel-team@android.com References: <20250819-acpm-clk-v1-0-6bbd97474671@linaro.org> <20250819-acpm-clk-v1-1-6bbd97474671@linaro.org> <20250822135521.GA3487754-robh@kernel.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/24/25 6:00 PM, Krzysztof Kozlowski wrote: > On 22/08/2025 17:03, Tudor Ambarus wrote: >> Hi, Rob, >> >> On 8/22/25 2:55 PM, Rob Herring wrote: >>> On Tue, Aug 19, 2025 at 11:45:36AM +0000, Tudor Ambarus wrote: >>>> The firmware exposes clocks that can be controlled via the ACPM >>>> interface. Describe the clocks exposed by the APM firmware. >>> >>> ACPM? APM is Advanced Power Management aka the predecessor to ACPI? >> >> ACPM (Alive Clock and Power Manager) is a firmware that operates on the > > Please unwrap the acronym in one place of bindings commit msgs. Okay. > >> APM (Active Power Management) module that handles overall power management >> activities. APM is built around a GREBE processor. >> >> In linux we have an ACPM protocol driver that communicates with the firmware >> via mailbox channels. It's similar to arm,scmi if you want. > > Rest of Rob's comment seems valid, so this also invalidates the DTS. > I assume Rob and you are suggesting to drop the child node and add #clock-cells to the parent. Then define the specific clock data in the parent and create a platform device by hand for the clocks with platform_device_register_data(). I think this works well as what's used in the kernel is just the clock mailbox channel id, clock IDs and clock names. And these can be defined with parent's compatible data. Please correct me if I understood it wrong. Cheers, ta