From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E685FC77B73 for ; Wed, 19 Apr 2023 07:50:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232587AbjDSHud (ORCPT ); Wed, 19 Apr 2023 03:50:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232428AbjDSHuW (ORCPT ); Wed, 19 Apr 2023 03:50:22 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B18F6E86 for ; Wed, 19 Apr 2023 00:50:02 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id kt6so41164851ejb.0 for ; Wed, 19 Apr 2023 00:50:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681890601; x=1684482601; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ex3FQYwjZBBRU/xF477+zVlaZW3BxZIMIDLhGEELcuU=; b=OxZ/WQz01SXrYObce2yJW9CAy2aOw6dw2vSElL7HKxUuk6uGq/tUS3XjmdGqD8R0Fe 3TfD9gBNBUJINE8p0WuEWKVWP+PCyhkWR8VMXbgVM5CVR/RXSxzH6vSQUni/Faz/KNEh 0FEmMLaRbbktdhDWVqgJXkRFOUaNf+e/etuOsL1JIfkBwtEDXYcRqmR8/ian+fA4mIGD jy1XUrPECRYhO1cceH2E2EG/7dZ9zGfGvzkBzsIpJnCq5wm2X4YkaA2u7v3SrTGTi1KO qRUjSNFgwocgx7ymMBA3u8xElw0q0TV389JWtVwsWbxsL68Hq9Y4zUvrbGERaWHvV7lH kRZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681890601; x=1684482601; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ex3FQYwjZBBRU/xF477+zVlaZW3BxZIMIDLhGEELcuU=; b=EYv6Lh9kRV0N58l9hRhIt4/fQ2paqJvSOZ6PeVf9AdtEQ1sKJoW+zV42G2ONmo7uSm oaWID0kh52/PyrqcABHPqMeEXdMThtuNvqPWM5SPCdgNBGMuFglZH3oc8GHdrvFNFX8a z8YMRyKeJxpxGPQva0fGjmstw8WfcRxZlVVrTSQtuj3qR/00kdwXq84Er0J8/MCVKnJB TWg5hBhC9u6LNAbvu3FkVpWvTGdm/5dEho/e2WXzHdm4BWLE1nG4w9PsOQG5C5VPXwrx RcGwDBTOklhbxgHmJUkoBaqSl0+vFIqJMrd+9JqkROw+1kT6I/HNMYMSrenP74im5xHz BjIg== X-Gm-Message-State: AAQBX9ct6RGHJzLZ5t7VyNRlNStau20YQRKHPbMGcZG2kVq33r2bPQ+S 6KFKYKb1bpBzY7QXQkbg0rhqWIHJRVog7PcF+HhkGg== X-Google-Smtp-Source: AKy350bYKg9848d4KXFH0IJZHSCHAmJ520zePJffoeMH2aWJrINnNuprN0NuepCabPPLCIjbLSbRtQ== X-Received: by 2002:a17:906:f14f:b0:94a:a6f0:876a with SMTP id gw15-20020a170906f14f00b0094aa6f0876amr13715223ejb.1.1681890600844; Wed, 19 Apr 2023 00:50:00 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:62f5:eb43:f726:5fee? ([2a02:810d:15c0:828:62f5:eb43:f726:5fee]) by smtp.gmail.com with ESMTPSA id rp26-20020a170906d97a00b0094f3132cb86sm5647711ejb.40.2023.04.19.00.50.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Apr 2023 00:50:00 -0700 (PDT) Message-ID: Date: Wed, 19 Apr 2023 09:49:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 1/5] arm64: dts: ti: k3-j784s4-main: Add system controller and SERDES lane mux Content-Language: en-US To: Jayesh Choudhary , nm@ti.com, vigneshr@ti.com, afd@ti.com Cc: s-vadapalli@ti.com, kristo@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, a-bhatia1@ti.com References: <20230419061710.290068-1-j-choudhary@ti.com> <20230419061710.290068-2-j-choudhary@ti.com> From: Krzysztof Kozlowski In-Reply-To: <20230419061710.290068-2-j-choudhary@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/04/2023 08:17, Jayesh Choudhary wrote: > From: Siddharth Vadapalli > > The system controller node manages the CTRL_MMR0 region. > Add serdes_ln_ctrl node which is used for controlling the SERDES lane mux. > > Signed-off-by: Siddharth Vadapalli > [j-choudhary@ti.com: Minor cleanup to fix dtc warnings] > Signed-off-by: Jayesh Choudhary > --- > arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi > index e9169eb358c1..5fb7edf4f5a0 100644 > --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi > @@ -5,6 +5,9 @@ > * Copyright (C) 2022 Texas Instruments Incorporated - https://www.ti.com/ > */ > > +#include > +#include > + > &cbass_main { > msmc_ram: sram@70000000 { > compatible = "mmio-sram"; > @@ -26,6 +29,25 @@ l3cache-sram@200000 { > }; > }; > > + scm_conf: syscon@100000 { > + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; > + reg = <0x00 0x00100000 0x00 0x1c000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x00 0x00 0x00100000 0x1c000>; > + > + serdes_ln_ctrl: mux-controller-4080 { Does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof