From: Dmitry Osipenko <digetx@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Dan Murphy <dmurphy@ti.com>, Sebastian Reichel <sre@kernel.org>,
Lubomir Rintel <lkundrak@v3.sk>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-leds@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/6] leds: Add driver for Acer Iconia Tab A500
Date: Mon, 24 Aug 2020 13:11:04 +0300 [thread overview]
Message-ID: <eb2da40a-9dbb-0a18-4dbc-3eb93bd2968c@gmail.com> (raw)
In-Reply-To: <20200823223037.5fkeg5ai6hry3axj@duo.ucw.cz>
24.08.2020 01:30, Pavel Machek пишет:
> Hi!
Hello, Pavel! Thank you very much for the review! I'll take into account
yours comments in the v2!
>> Acer Iconia Tab A500 is an Android tablet device which has two LEDs
>> embedded into the Power Button. Orange LED indicates "battery charging"
>> status and white LED indicates "wake-up/charge-done" status. The new LED
>> driver provides control over both LEDs to userspace.
>
>> @@ -0,0 +1,121 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>
> Nice.
>
>> + * Copyright 2020 GRATE-driver project.
>
> Probably untrue.
>
>
>> + white_led->cdev.name = "power-button-white";
>
> "white:power"
>
>> + white_led->cdev.max_brightness = LED_ON;
>
> = 1. (And you'll need other adjustments over the code).
>
>> + orange_led->cdev.name = "power-button-orange";
>
> "orange:power" -- or what is this LED usually used for?
>
>> +MODULE_LICENSE("GPL v2");
>
> Should be "GPL"?
Yes, apparently it should be "GPL". I'll try to double-check it for the v2.
Thanks!
next prev parent reply other threads:[~2020-08-24 10:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 14:08 [PATCH v1 0/6] Introduce Embedded Controller driver for Acer A500 Dmitry Osipenko
2020-08-23 14:08 ` [PATCH v1 1/6] mfd: Add driver for Embedded Controller found on Acer Iconia Tab A500 Dmitry Osipenko
2020-08-23 18:16 ` Lubomir Rintel
2020-08-23 19:28 ` Dmitry Osipenko
2020-08-24 7:33 ` Lee Jones
2020-08-24 10:10 ` Dmitry Osipenko
2020-08-24 10:43 ` Lee Jones
2020-08-23 14:08 ` [PATCH v1 2/6] power: supply: Add battery gauge driver for " Dmitry Osipenko
2020-08-24 14:07 ` Sebastian Reichel
2020-08-24 18:55 ` Dmitry Osipenko
2020-08-24 21:38 ` Sebastian Reichel
2020-08-26 6:34 ` Dmitry Osipenko
2020-08-23 14:08 ` [PATCH v1 3/6] leds: Add " Dmitry Osipenko
2020-08-23 22:30 ` Pavel Machek
2020-08-24 10:11 ` Dmitry Osipenko [this message]
2020-08-24 11:38 ` Dmitry Osipenko
2020-08-23 22:34 ` Pavel Machek
2020-08-24 10:16 ` Dmitry Osipenko
2020-08-23 14:08 ` [PATCH v1 4/6] dt-bindings: mfd: ene-kb3930: Add compatibles for KB930 and Acer A500 Dmitry Osipenko
2020-08-23 18:20 ` Lubomir Rintel
2020-08-23 19:31 ` Dmitry Osipenko
2020-08-23 21:16 ` Lubomir Rintel
2020-08-24 10:09 ` Dmitry Osipenko
2020-09-08 21:53 ` Rob Herring
2020-09-08 22:01 ` Dmitry Osipenko
2020-08-23 14:08 ` [PATCH v1 5/6] dt-bindings: mfd: ene-kb3930: Document power-supplies and monitored-battery properties Dmitry Osipenko
2020-08-23 18:00 ` Lubomir Rintel
2020-08-23 14:08 ` [PATCH v1 6/6] ARM: tegra: acer-a500: Add Embedded Controller Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb2da40a-9dbb-0a18-4dbc-3eb93bd2968c@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jonathanh@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).