From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3741CC433FE for ; Mon, 28 Mar 2022 13:17:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243067AbiC1NTf (ORCPT ); Mon, 28 Mar 2022 09:19:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233955AbiC1NTf (ORCPT ); Mon, 28 Mar 2022 09:19:35 -0400 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FC755E15D; Mon, 28 Mar 2022 06:17:54 -0700 (PDT) Received: by mail-wm1-f48.google.com with SMTP id k124-20020a1ca182000000b0038c9cf6e2a6so8568328wme.0; Mon, 28 Mar 2022 06:17:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iKDE8EKlqOGJskgYoQA1+WaBLlsppzmH0dWUYgs6IH0=; b=lkiZQw/nLguP4/Ezdj7o5Ez7Esm3Szwhu/PlMbOD/KXjZ579EpukS+CdbopX13PRik BS8ZWDge+uA0x2YSZ6kPb6J2oQeIiFl0uBNp6y6prHagpXyQbp4Fawgrd6boHtFI5wR7 jxoib1zz89OmUq3EeQRWE1gj1tf2L1SjKR8HhVTqDNAzaI/4DnFTh2hySY7X3bw9h8tV z8GfdmHdkxfe1iRf+yVTJE/jE6kAm03EFkIZCv0p+RoCCWkOokeJIiR4TftMf+ZjAMR7 Xv7uODhfn1u1BT4+3liLdtfSTQwrg+fqVqjtooi+ktAkul/8ncRC/eJp1UBD0oXUH8U4 HXlg== X-Gm-Message-State: AOAM532AgUZnwbEPsA9EhkDUMMvpaJnd3YmR9ergD+WpmssZwOhm+MLK T8Dyk3KF41y8Tt1BD/YXrMw= X-Google-Smtp-Source: ABdhPJy7iH/wqrU8Pr8ZdxARVRkS2rt6Jr/9juTbM8WkYurgbz79GoxDq/vz+IwJ3dISjMIw/sQ3gw== X-Received: by 2002:a7b:c955:0:b0:38c:aafb:2991 with SMTP id i21-20020a7bc955000000b0038caafb2991mr35638188wml.114.1648473472638; Mon, 28 Mar 2022 06:17:52 -0700 (PDT) Received: from [192.168.0.162] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.googlemail.com with ESMTPSA id z5-20020a05600c0a0500b0037bb8df81a2sm18519327wmp.13.2022.03.28.06.17.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Mar 2022 06:17:52 -0700 (PDT) Message-ID: Date: Mon, 28 Mar 2022 15:17:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 3/5] arm64: dts: imx8mp: Enable HS400-ES Content-Language: en-US To: Adam Ford Cc: Ahmad Fatoum , Krzysztof Kozlowski , linux-mmc , devicetree , Ulf Hansson , Fabio Estevam , Shawn Guo , Sascha Hauer , Adam Ford-BE , Haibo Chen , Linux Kernel Mailing List , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , arm-soc References: <20220327123835.28329-1-aford173@gmail.com> <20220327123835.28329-3-aford173@gmail.com> <74e74ea8-1554-bf08-b0ea-36e77259cb18@pengutronix.de> <5c24c12b-3a12-1e18-9f03-2c54cad30bf9@kernel.org> <5282b39b-85d5-81d6-10d5-a45c66d4d4e9@kernel.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/03/2022 15:06, Adam Ford wrote: > On Mon, Mar 28, 2022 at 7:56 AM Krzysztof Kozlowski wrote: >> >> On 28/03/2022 14:45, Adam Ford wrote: >>> On Mon, Mar 28, 2022 at 6:49 AM Krzysztof Kozlowski wrote: >>>> >>>> On 28/03/2022 13:09, Ahmad Fatoum wrote: >>>>> Hello Adam, >>>>> >>>>> On 28.03.22 12:47, Adam Ford wrote: >>>>>> On Mon, Mar 28, 2022 at 2:20 AM Ahmad Fatoum wrote: >>>>>>> >>>>>>> Hello Adam, >>>>>>> >>>>>>> On 27.03.22 14:38, Adam Ford wrote: >>>>>>>> The SDHC controller in the imx8mp has the same controller >>>>>>>> as the imx8mm which supports HS400-ES. Change the compatible >>>>>>>> fallback to imx8mm to enable it. >>>>>>> >>>>>>> I believe that's a shortcoming of the Linux driver, which should explicitly list >>>>>>> fsl,imx8mp-usdhc in its compatibles and enable HS400-ES for it. >>>>>>> >>>>>>> I find dropping compatibles problematic, because like Linux matching >>>>>>> fsl,imx8mm-usdhc, but not fsl,imx8mp-usdhc, other software may match >>>>>>> fsl,imx7d-usdhc, but not fsl,imx8[mp]-usdhc. >>>>>>> >>>>>>> I'd prefer that either the kernel driver gains extra compatibles or that >>>>>>> the DTS lists extra compatibles and we refrain from dropping existing >>>>>>> (correct) ones. >>>>>>> >>>>>> >>>>>> I would argue that imx7d is not correct since the IP blocks between >>>>>> imx7d and imx8mm have different flags/quirks. One of which includes >>>>>> HS400-ES, but there are other differences as well. >>>>> >>>>> The DTS currently says that an fsl,imx7d-usdhc is a subset of an >>>>> fsl,imx8mm-usdhc. So a driver could treat both HW the exact same >>>>> by focusing on the i.MX7D parts. Linux apparently did exactly >>>>> that so far. Is this not accurate? >>>>> >>>>> >>>>>>> What do you think? >>>>>> >>>>>> From my understanding of the fallback compatibility strings is to >>>>>> avoid having to add more and more compatible strings to the drivers >>>>>> when they do not serve a functional purpose. Based On a conversation >>>>>> with Krzysztof [1], he suggested we update the YAML file based on the >>>>>> fallback, but he wanted NXP to give their feedback as to what the >>>>>> right fallback strings should be. Haibo from NXP sent me a hierarchy >>>>>> [1] which is what I used to update the YAML file. Based on the YAML >>>>>> file, the fallback in each DTSI file was updated to ensure the use of >>>>>> the proper IP block. >>>>> >>>>> Myself I am in favor of moving to three compatibles instead of dropping one. >>>>> For some theoretical fsl,imx8mf-usdhc that's supposed to be exactly the same >>>>> as a fsl,imx8mm-usdhc, I don't mind omitting the fsl,imx7d-usdhc compatible, >>>>> but for existing device trees, this may introduce needless potential breakage >>>>> for other software that also uses Linux device trees. >>>>> >>>> >>>> Affecting existing users is indeed a concern with this approach, because >>>> in-kernel DTS might be used in other projects as well. >>>> >>>> I still cannot find here the answer whether fsl,imx8mm-usdhc is actually >>>> compatible with fsl,imx7d-usdhc. It's not about driver, but about >>>> hardware and programming model. imx8mm can support additional features >>>> and still be compatible with imx7d. However if any flags of imx7d are >>>> actually not valid for imx8mm, then it's different case. >>> >>> The imx7d flags are: >>> ESDHC_FLAG_USDHC >>> ESDHC_FLAG_STD_TUNING >>> ESDHC_FLAG_HAVE_CAP1 >>> ESDHC_FLAG_HS200 >>> ESDHC_FLAG_HS400 >>> ESDHC_FLAG_STATE_LOST_IN_LPMODE >>> ESDHC_FLAG_BROKEN_AUTO_CMD23, >>> >>> The imx8mm flags are: >>> ESDHC_FLAG_USDHC >>> ESDHC_FLAG_STD_TUNING >>> ESDHC_FLAG_HAVE_CAP1 >>> ESDHC_FLAG_HS200 >>> ESDHC_FLAG_HS400 >>> ESDHC_FLAG_HS400_ES >>> ESDHC_FLAG_STATE_LOST_IN_LPMODE >>> >>> It does not have the ESDHC_FLAG_BROKEN_AUTO_CMD23 that is present in the imx7d. >> >> AFAIU, it looks imx8mm is compatible with imx7d, because the broken >> acmd23 only limits the features. If imx8mm binds according to imx7d, it >> will not support acmd23 and HS400-ES. >> >> Having three compatibles is therefore also OK. >> >> You could also add two cases: >> 1. three compatibles, deprecated: True, >> 2. two compatibles, without imx7d. >> >> Existing DTS stays with three compatibles for two years and later gets >> converted to two compatibles. New DTS should use two compatibles. >> >> It's quite a lot of churn, but would make in the long term bindings >> correct and also not break other users/projects. >> >>> >>> Maybe Haibo can comment on whether or not that would be an issue for the 8m[mnp] >>> >>> I will defer to Krzysztof and Haibo as to the proper method that we >>> should add HS400-ES. I don't have an issue adding the imx8mn or >>> imx8mp compatible flags to the esdhc driver if that's the decision. >> >> I don't get what's the problem with HS400-ES. In any case (your patch >> here, other ideas) your DTS will bind to imx8mm-usdhc which has HS400-ES. > > I was under the impression Ahmad didn't want me to add the imx8mm > compatible to the DTS, but instead, add the imx8mp compatible into the > driver so it binds directly to an imx8mp. > Based on that, I was assuming this patch series would be rejected and > I sould focus on just the driver file itself > > From what I am reading from you, I should make the imx8mn and imx8mp > device trees respectively read: > > compatible = "fsl,imx8mn-usdhc", "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc"; > > and > > compatible = "fsl,imx8mp-usdhc", "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc"; > > If that's true, do I need to change the YAML at all? Sorry, I do not remember all the Linux kernel bindings by heart, so you need to check by yourself whether they cover this case or not. Best regards, Krzysztof