From: Krzysztof Kozlowski <krzk@kernel.org>
To: Diogo Silva <diogompaissilva@gmail.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, aisheng.dong@nxp.com,
Frank.Li@nxp.com
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8: Fix lvds0 device tree
Date: Mon, 16 Sep 2024 22:23:13 +0200 [thread overview]
Message-ID: <eb3ec7f1-388c-4613-b995-69b8ad6ef2c0@kernel.org> (raw)
In-Reply-To: <20240916200255.2566209-1-diogo.pais@ttcontrol.com>
On 16/09/2024 22:02, Diogo Silva wrote:
> From: Diogo Silva <diogompaissilva@gmail.com>
>
> Some clock output names on lvds0 device tree were duplicated from mipi1,
> which caused an -EEXIST when registering these clocks during probe.
> Also fixed the device naming to be consistent with lvds1.
>
> Fixes: 0fba24b3b956 ("arm64: dts: imx8: add basic lvds0 and lvds1 subsystem")
> subsystem")
Broken tags. They do not line-brake, BTW.
> Signed-off-by: Diogo Silva <diogompaissilva@gmail.com>
> ---
> .../boot/dts/freescale/imx8-ss-lvds0.dtsi | 22 +++++++++----------
> arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 4 ++--
> .../boot/dts/freescale/imx8qm-ss-lvds.dtsi | 20 ++++++++---------
> 3 files changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-lvds0.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-lvds0.dtsi
> index d00036204a8c..a4d94467039f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-ss-lvds0.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-lvds0.dtsi
> @@ -10,34 +10,34 @@ lvds0_subsys: bus@56240000 {
> #size-cells = <1>;
> ranges = <0x56240000 0x0 0x56240000 0x10000>;
>
> - qm_lvds0_lis_lpcg: qxp_mipi1_lis_lpcg: clock-controller@56243000 {
> + lvds0_lis_lpcg: clock-controller@56243000 {
> compatible = "fsl,imx8qxp-lpcg";
> reg = <0x56243000 0x4>;
> #clock-cells = <1>;
> - clock-output-names = "mipi1_lis_lpcg_ipg_clk";
> + clock-output-names = "lvds0_lis_lpcg_ipg_clk";
> power-domains = <&pd IMX_SC_R_MIPI_1>;
> };
>
> - qm_lvds0_pwm_lpcg: qxp_mipi1_pwm_lpcg: clock-controller@5624300c {
> + lvds0_pwm_lpcg: clock-controller@5624300c {
> compatible = "fsl,imx8qxp-lpcg";
> reg = <0x5624300c 0x4>;
> #clock-cells = <1>;
> - clock-output-names = "mipi1_pwm_lpcg_clk",
> - "mipi1_pwm_lpcg_ipg_clk",
> - "mipi1_pwm_lpcg_32k_clk";
> + clock-output-names = "lvds0_pwm_lpcg_clk",
> + "lvds0_pwm_lpcg_ipg_clk",
> + "lvds0_pwm_lpcg_32k_clk";
> power-domains = <&pd IMX_SC_R_MIPI_1_PWM_0>;
> };
>
> - qm_lvds0_i2c0_lpcg: qxp_mipi1_i2c0_lpcg: clock-controller@56243010 {
> + lvds0_i2c0_lpcg: clock-controller@56243010 {
> compatible = "fsl,imx8qxp-lpcg";
> reg = <0x56243010 0x4>;
> #clock-cells = <1>;
> - clock-output-names = "mipi1_i2c0_lpcg_clk",
> - "mipi1_i2c0_lpcg_ipg_clk";
> + clock-output-names = "lvds0_i2c0_lpcg_clk",
> + "lvds0_i2c0_lpcg_ipg_clk";
> power-domains = <&pd IMX_SC_R_MIPI_1_I2C_0>;
> };
>
> - qm_pwm_lvds0: qxp_pwm_mipi_lvds1: pwm@56244000 {
> + pwm_lvds0: pwm@56244000 {
> compatible = "fsl,imx8qxp-pwm", "fsl,imx27-pwm";
> reg = <0x56244000 0x1000>;
> clock-names = "ipg", "per";
> @@ -48,7 +48,7 @@ qm_pwm_lvds0: qxp_pwm_mipi_lvds1: pwm@56244000 {
> status = "disabled";
> };
>
> - qm_i2c0_lvds0: qxp_i2c0_mipi_lvds1: i2c@56246000 {
> + i2c0_lvds0: i2c@56246000 {
> compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
> reg = <0x56246000 0x1000>;
> #address-cells = <1>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> index 62203eed6a6c..f7b9b319a58a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> @@ -96,7 +96,7 @@ vdevbuffer: memory@90400000 {
>
> lvds_backlight0: backlight-lvds0 {
> compatible = "pwm-backlight";
> - pwms = <&qm_pwm_lvds0 0 100000 0>;
> + pwms = <&pwm_lvds0 0 100000 0>;
> brightness-levels = <0 100>;
> num-interpolated-steps = <100>;
> default-brightness-level = <80>;
> @@ -541,7 +541,7 @@ &fec2 {
> status = "okay";
> };
>
> -&qm_pwm_lvds0 {
> +&pwm_lvds0 {
Why this cannot stay qm_pwm_lvds0? Are you sure nodes now have correct
order?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-16 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 20:02 [PATCH] arm64: dts: imx8: Fix lvds0 device tree Diogo Silva
2024-09-16 20:23 ` Krzysztof Kozlowski [this message]
2024-09-16 20:50 ` Diogo Silva
[not found] ` <CAJpoHp4Dija5jDDMZnqX_g5QpQWfYPjoHK-3orJsyxCQYv4N0Q@mail.gmail.com>
2024-09-17 6:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb3ec7f1-388c-4613-b995-69b8ad6ef2c0@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=diogompaissilva@gmail.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).